Create new `SelectionListWithSections` component by zfurtak · Pull Request #79957 · Expensify/App

zfurtak · 2026-01-20T10:46:44Z

Explanation of Change

This PR introduces a new, FlashList-based version of SelectionListWithSections. And also migrates TaxPicker to use new component.

Changes:

Replacement for the legacy section list component
Significant performance boost for datasets with multiple sections

Note

This version will be further developed during the migration of related components

Fixed Issues

$ #65657
PROPOSAL:

Tests

Go to a workspace with Taxes enabled
Add multiple taxes to test lists (over 12)
Go to taxes settings
Verify that the lists work correctly on pages:
- Workspace currency default and
- Foreign currency default

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

screen-20260121-113905-1768991915409.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-20.at.12.08.15.mov

codecov · 2026-01-21T09:33:57Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`85.47% <ø> (ø)`
src/components/SelectionList/BaseSelectionList.tsx	`68.34% <100.00%> (-0.41%)`	⬇️
.../components/SelectionList/components/TextInput.tsx	`100.00% <100.00%> (ø)`
src/components/SelectionList/index.native.tsx	`100.00% <ø> (ø)`
src/libs/TaxOptionsListUtils.ts	`71.05% <100.00%> (ø)`
...onents/SelectionList/ListItem/ListItemRenderer.tsx	`66.66% <0.00%> (-4.77%)`	⬇️
...ionList/SelectionListWithSections/index.native.tsx	`0.00% <0.00%> (ø)`
...mponents/SelectionList/hooks/useSearchFocusSync.ts	`88.88% <88.88%> (ø)`
...ts/SelectionList/hooks/useSelectedItemFocusSync.ts	`85.71% <85.71%> (ø)`
src/components/SelectionList/index.tsx	`0.00% <0.00%> (ø)`
... and 6 more
... and 52 files with indirect coverage changes

blazejkustra

Looks solid and well-structured!!! 🚀

staszekscp

Great job! I love new hooks! 🎉

melvin-bot · 2026-01-22T09:41:20Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e73c49cfe8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

dukenv0307 · 2026-01-22T12:03:29Z

+        try {
+            listRef.current.scrollToIndex({index});
+        } catch (error) {
+            // FlashList may throw if layout for this index doesn't exist yet


I think we should add the log here

dukenv0307 · 2026-01-22T12:27:52Z

+        initialFocusedIndex,
+        maxIndex: flattenedData.length - 1,
+        disabledIndexes,
+        isActive: isScreenFocused,


Should we active useArrowKeyFocusManager only when the flattenedData.length >0

I can add this however in normal SelectionList it woks fine without this check, wdyt? I don't think we've experienced any problems with it

@zfurtak I can't find the specific reason, but I see we're doing the same in other places like

App/src/pages/home/report/ReportActionCompose/SuggestionEmoji.tsx

Lines 56 to 59 in 03cf165

const isEmojiSuggestionsMenuVisible = suggestionValues.suggestedEmojis.length > 0 && suggestionValues.shouldShowSuggestionMenu;

const [highlightedEmojiIndex, setHighlightedEmojiIndex] = useArrowKeyFocusManager({

isActive: isEmojiSuggestionsMenuVisible,

so I think we can do it here

dukenv0307 · 2026-01-22T15:08:03Z

@zfurtak Can you please check the failed tests? The rest looks good. I'll start testing now

dukenv0307 · 2026-01-22T15:33:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-22.at.22.27.21.mov

Android: mWeb Chrome

Screen.Recording.2026-01-22.at.22.25.51.mov

iOS: HybridApp

Screen.Recording.2026-01-22.at.22.27.55.mov

iOS: mWeb Safari

Screen.Recording.2026-01-22.at.22.24.19.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-22.at.22.20.51.mov

zfurtak · 2026-01-22T15:35:13Z

@zfurtak Can you please check the failed tests? The rest looks good. I'll start testing now

these are some internal 500 errors, I guess they'll be fixed with a merge soon

OSBotify · 2026-01-23T10:28:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-23T22:34:55Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.8-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-26T21:57:04Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.8-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Create new list component

afe6912

melvin-bot Bot assigned zfurtak Jan 20, 2026

zfurtak added 5 commits January 20, 2026 13:23

Fix getItemType

f48b52e

Merge branch 'main' into @zfurtak/new-list-wth-sections

ea5ce5d

Fix eslint errors

726b04c

Extract common types and function for both lists

1699555

Fix unit test and run prettier

06e346b

zfurtak added 2 commits January 21, 2026 10:35

Change name of new component

f6b3e4b

Extract common behaviour to useWebSelectionListBehaviour

e22baf7

blazejkustra approved these changes Jan 21, 2026

View reviewed changes

Comment thread src/components/SelectionList/SelectionListWithSections/BaseSelectionListWithSections.tsx Outdated

war-in reviewed Jan 21, 2026

View reviewed changes

staszekscp reviewed Jan 21, 2026

View reviewed changes

zfurtak added 2 commits January 22, 2026 10:25

Improve SelectionListWithSections

617b3b1

Fix prop name

e73c49c

zfurtak marked this pull request as ready for review January 22, 2026 09:41

zfurtak requested review from a team as code owners January 22, 2026 09:41

melvin-bot Bot requested review from dukenv0307 and trjExpensify and removed request for a team January 22, 2026 09:41

melvin-bot Bot removed the request for review from a team January 22, 2026 09:41

github-actions Bot reviewed Jan 22, 2026

View reviewed changes

Comment thread src/components/SelectionList/hooks/useSelectedItemFocusSync.ts

github-actions Bot reviewed Jan 22, 2026

View reviewed changes

Comment thread src/components/SelectionList/SelectionListWithSections/index.native.tsx

github-actions Bot reviewed Jan 22, 2026

View reviewed changes

Comment thread src/components/SelectionList/SelectionListWithSections/index.tsx

Add comments

9a0a5c8

chatgpt-codex-connector Bot reviewed Jan 22, 2026

View reviewed changes

Comment thread src/components/SelectionList/SelectionListWithSections/BaseSelectionListWithSections.tsx

zfurtak added 2 commits January 22, 2026 11:20

Check if section is disabled

1d7df7d

Prettier

85aa08d

war-in reviewed Jan 22, 2026

View reviewed changes

Comment thread src/components/SelectionList/SelectionListWithSections/types.ts Outdated

zfurtak added 3 commits January 22, 2026 11:48

Fix type

9f8cf86

Merge branch 'main' into @zfurtak/new-list-wth-sections

32d9dff

Fix ts error

05a18c6

dukenv0307 reviewed Jan 22, 2026

View reviewed changes

Add log

137ebac

zfurtak added 2 commits January 22, 2026 16:46

Add check for arrow key focus manager

6a376c4

Merge branch 'main' into @zfurtak/new-list-wth-sections

1853cca

dukenv0307 approved these changes Jan 22, 2026

View reviewed changes

melvin-bot Bot requested a review from grgia January 22, 2026 17:12

grgia approved these changes Jan 23, 2026

View reviewed changes

grgia merged commit 16e02f4 into Expensify:main Jan 23, 2026
30 checks passed

OSBotify mentioned this pull request Jan 23, 2026

Deploy Checklist: New Expensify 2026-01-23 #80389

Closed

43 tasks

melvin-bot Bot mentioned this pull request Jan 26, 2026

[Due for payment 2026-02-02] [SelectionList Improvements][Phase 3] Improve performance of list with sections #65657

Closed

	const isEmojiSuggestionsMenuVisible = suggestionValues.suggestedEmojis.length > 0 && suggestionValues.shouldShowSuggestionMenu;

	const [highlightedEmojiIndex, setHighlightedEmojiIndex] = useArrowKeyFocusManager({
	isActive: isEmojiSuggestionsMenuVisible,

Conversation

zfurtak commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jan 21, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

staszekscp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

melvin-bot Bot commented Jan 22, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

dukenv0307 Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

zfurtak Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

zfurtak Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Jan 22, 2026

Uh oh!

dukenv0307 commented Jan 22, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

zfurtak commented Jan 22, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 23, 2026

Uh oh!

OSBotify commented Jan 23, 2026

Uh oh!

OSBotify commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

zfurtak commented Jan 20, 2026 •

edited

Loading

codecov Bot commented Jan 21, 2026 •

edited by github-actions Bot

Loading