Fix default props when using withOnyx

[alex-mechler]

Hold on Expensify/react-native-onyx#5

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/144333

Tests

Repeated on Web, Desktop, Simulator iOS, Simulator Android. These tests cover most cases we would run into. Happy to add more tests if there is anything you would like to see specifically

1. Signed into an account
2. Created a chat with a user account had previously not chatted with
3. Sent a message
4. Created a chat with a user account had previously chatted with
5. Sent a message
6. Created a group chat
7. Sent a message
8. Signed out

Screenshots

N/a

[roryabraham]

I ran into an issue using the chat switcher. To reproduce:

1. Start typing in ChatSwitcherSearchForm
2. Use the down arrow key to select a chat
3. Hit enter to go to the chat
4. The URL looks correct, but I get a white screen error:

And here are some log snippets:

Warning: Failed prop type: The prop `defaultValue` is marked as required in `TextInputFocusable`, but its value is `null`.
    in TextInputFocusable (created by ForwardRef)
    in ForwardRef (created by ReportActionCompose)
    in div (created by View)
    in View (created by ReportActionCompose)
    in div (created by View)
    in View (created by ReportActionCompose)
    in ReportActionCompose
    in withOnyx(ReportActionCompose) (created by ReportView)
    ...
    ...

Uncaught TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at new ReportTypingIndicator (ReportTypingIndicator.js:24)
    at constructClassInstance (react-dom.development.js:12880)
    at updateClassComponent (react-dom.development.js:17100)
    at beginWork (react-dom.development.js:18620)
    at HTMLUnknownElement.callCallback (react-dom.development.js:188)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:237)
    at invokeGuardedCallback (react-dom.development.js:292)
    at beginWork$1 (react-dom.development.js:23203)
    at performUnitOfWork (react-dom.development.js:22154)

[alex-mechler]

Hmmm, I'm having trouble reproducing. Did you make sure to npm i after pulling this branch?

[roryabraham]

Oops, no I did not. It worked after running npm i

[roryabraham]

LGTM

[alex-mechler]

Off hold, also bumped hash to latest changes

[roryabraham]

Cool, merging