Skip to content

Prevent Excel tag files from being uploaded (PR by ijmalik) #79186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuwenmemon merged 12 commits into from
Jan 12, 2026
Merged

Prevent Excel tag files from being uploaded (PR by ijmalik) #79186

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
174e18d
Prevent Excel tag files from being uploaded
SIMalik Jan 9, 2026
c92aade
Resolve ESLint no-lonely-if in ImportSpreadsheet
SIMalik Jan 9, 2026
4e71a4a
Resolve formatting diff
SIMalik Jan 9, 2026
3940cf2
Resolve formatting diff
SIMalik Jan 9, 2026
ad29d33
Resolve formatting diff
SIMalik Jan 9, 2026
feba3b3
Resolve formatting diff
SIMalik Jan 9, 2026
82bc90f
Resolve formatting diff and ESLint Check issue
SIMalik Jan 9, 2026
ee6280a
Simplify code - file extension validation
SIMalik Jan 9, 2026
79ca138
chore: re-run CI
SIMalik Jan 10, 2026
fe42c25
Remove redundant condition by using allowedExtensions
SIMalik Jan 10, 2026
27a5369
Remove redundant condition by using allowedExtensions
SIMalik Jan 10, 2026
5c45531
Removed unused const lowerExt
SIMalik Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/ImportSpreadsheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ function ImportSpreadsheet({backTo, goTo, isImportingMultiLevelTags}: ImportSpre

const validateFile = (file: FileObject) => {
const {fileExtension} = splitExtensionFromFileName(file?.name ?? '');
if (!CONST.ALLOWED_SPREADSHEET_EXTENSIONS.includes(fileExtension.toLowerCase() as TupleToUnion<typeof CONST.ALLOWED_SPREADSHEET_EXTENSIONS>)) {
const allowedExtensions: readonly string[] = isImportingMultiLevelTags ? CONST.MULTILEVEL_TAG_ALLOWED_SPREADSHEET_EXTENSIONS : CONST.ALLOWED_SPREADSHEET_EXTENSIONS;

if (!allowedExtensions.includes(fileExtension.toLowerCase())) {
setUploadFileError(true, 'attachmentPicker.wrongFileType', 'attachmentPicker.notAllowedExtension');
return false;
}
Expand Down
Loading