Skip to content

[NoQA] Allow cardList to be missing in ExpensifyCardContextProvider with a default value #79074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blimpich merged 2 commits into from
Jan 12, 2026
Merged

[NoQA] Allow cardList to be missing in ExpensifyCardContextProvider with a default value #79074

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee46112
Allow cardList to be missing in ExpensifyCardContextProvider with a d…
ShridharGoel Jan 8, 2026
563318f
Fix lint
ShridharGoel Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/pages/settings/Wallet/ExpensifyCardPage/ExpensifyCardContextProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ import React, {createContext, useEffect, useMemo, useState} from 'react';
import useOnyx from '@hooks/useOnyx';
import {filterPersonalCards} from '@libs/CardUtils';
import ONYXKEYS from '@src/ONYXKEYS';
import type {ExpensifyCardDetails} from '@src/types/onyx/Card';
import type {CardList, ExpensifyCardDetails} from '@src/types/onyx/Card';
import type {Errors} from '@src/types/onyx/OnyxCommon';
import {getEmptyObject} from '@src/types/utils/EmptyObject';

type ExpensifyCardContextProviderProps = {
cardsDetails: Record<number, ExpensifyCardDetails | null>;
Expand All @@ -28,7 +29,10 @@ const ExpensifyCardContext = createContext<ExpensifyCardContextProviderProps>({
* Context to display revealed expensify card data and pass it between screens.
*/
function ExpensifyCardContextProvider({children}: PropsWithChildren) {
const [cardList] = useOnyx(ONYXKEYS.CARD_LIST, {selector: filterPersonalCards, canBeMissing: false});
const [cardList = getEmptyObject<CardList>()] = useOnyx(ONYXKEYS.CARD_LIST, {
selector: filterPersonalCards,
canBeMissing: true,
});
const [cardsDetails, setCardsDetails] = useState<Record<number, ExpensifyCardDetails | null>>({});
const [isCardDetailsLoading, setIsCardDetailsLoading] = useState<Record<number, boolean>>({});
const [cardsDetailsErrors, setCardsDetailsErrors] = useState<Record<number, string>>({});
Expand Down
Loading