[CP STG] Remove screenwrapper since addressPage already has a screenWrapper in it#78308
Merged
Conversation
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
Running an adhoc build so that I can test on mobile |
| <AddressPage | ||
| isLoadingApp={false} | ||
| updateAddress={updatePolicyAddress} | ||
| title={translate('common.companyAddress')} |
Contributor
There was a problem hiding this comment.
❌ PERF-4 (docs)
The updatePolicyAddress function is created inline without memoization, causing a new function reference on every render. This triggers unnecessary re-renders of the AddressPage component.
Wrap the function with useCallback:
const updatePolicyAddress = useCallback((values: FormOnyxValues<typeof ONYXKEYS.FORMS.HOME_ADDRESS_FORM>) => {
if (!policy) {
return;
}
if (!isUserValidated) {
const currentRoute = ROUTES.TRAVEL_WORKSPACE_ADDRESS.getRoute(route.params.domain, policyID, route.params.backTo);
setTravelProvisioningNextStep(currentRoute);
Navigation.navigate(ROUTES.TRAVEL_VERIFY_ACCOUNT.getRoute(route.params.domain, policyID));
return;
}
updateAddress(policy?.id, {
addressStreet: `${values.addressLine1?.trim() ?? }\n${values.addressLine2?.trim() ?? }`,
city: values.city.trim(),
state: values.state.trim(),
zipCode: values?.zipPostCode?.trim().toUpperCase() ?? ,
country: values.country,
});
Navigation.navigate(ROUTES.TRAVEL_TCS.getRoute(route.params.domain ?? CONST.TRAVEL.DEFAULT_DOMAIN, policyID), {forceReplace: true});
}, [policy, isUserValidated, route.params.domain, route.params.backTo, policyID]);
Contributor
|
🚧 @stitesExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This comment has been minimized.
This comment has been minimized.
Contributor
|
Tests well #78204 (comment) |
Contributor
Author
|
@situchan can you try these steps too please? I think we have another bug
|
Contributor
|
Oh crashed. Also happens on main. Let me investigate 
|
Contributor
|
Please push this fix App/src/pages/Travel/MyTripsPage.tsx Line 14 in f032b34 - const {policyID} = route.params;
+ const policyID = route.params?.policyID; |
Contributor
Author
|
Pushed. Starting another adhoc build |
Contributor
|
🚧 @stitesExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
marcaaron
approved these changes
Dec 22, 2025
marcaaron
left a comment
Contributor
There was a problem hiding this comment.
QA is reporting that this issue is fixed, but I think they tested the AdHoc build. Approving.
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Contributor
|
This is another deploy blocker so we wanna test this as well before merge. |
Contributor
|
Btw I confirmed fix crash with this change locally so all good! |
situchan
approved these changes
Dec 22, 2025
OSBotify
pushed a commit
that referenced
this pull request
Dec 22, 2025
Remove screenwrapper since addressPage already has a screenWrapper in it (cherry picked from commit 44cc06e) (cherry-picked to staging by marcaaron)
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
87 tasks
Contributor
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.2.85-7 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.85-7 🚀
|
Contributor
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.2.86-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.86-4 🚀
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
We were wrapping
AddressPagein ascreenWrapper, butAddressPagealready has ascreenWrapperinside of it. This caused double padding. To prevent that we can remove the outerscreenWrapperFixed Issues
$ #78204
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari