Skip to content

fix: header shows wrong amount after dismissing distance rate error #77967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thienlnam merged 1 commit into from
Dec 19, 2025
Merged

fix: header shows wrong amount after dismissing distance rate error #77967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/components/ReportActionItem/MoneyRequestReceiptView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,14 @@

const [showConfirmDismissReceiptError, setShowConfirmDismissReceiptError] = useState(false);

const transactionAndReportActionErrors = useMemo(
() => ({
...transaction?.errors,
...parentReportAction?.errors,
}),
[transaction?.errors, parentReportAction?.errors],
);

const dismissReceiptError = useCallback(() => {
if (!report?.reportID) {
return;
Expand All @@ -227,8 +235,10 @@
clearAllRelatedReportActionErrors(report.reportID, parentReportAction);
return;
}
if (!isEmptyObject(errorsWithoutReportCreation)) {
if (!isEmptyObject(transactionAndReportActionErrors)) {
revert(transaction, getLastModifiedExpense(report?.reportID));
}
if (!isEmptyObject(errorsWithoutReportCreation)) {
clearError(transaction.transactionID);
clearAllRelatedReportActionErrors(report.reportID, parentReportAction);
}
Expand All @@ -238,7 +248,7 @@
}
navigateToConciergeChatAndDeleteReport(report.reportID, true, true);
}
}, [

Check warning on line 251 in src/components/ReportActionItem/MoneyRequestReceiptView.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

React Hook useCallback has a missing dependency: 'transactionAndReportActionErrors'. Either include it or remove the dependency array

Check warning on line 251 in src/components/ReportActionItem/MoneyRequestReceiptView.tsx

View workflow job for this annotation

GitHub Actions / ESLint check 

React Hook useCallback has a missing dependency: 'transactionAndReportActionErrors'. Either include it or remove the dependency array
transaction,
chatReport,
parentReportAction,
Expand Down
Loading