-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add members page to domain #77872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mountiny
merged 40 commits into
Expensify:main
from
software-mansion-labs:feature/kuba-nowakowski/add__domain_members_page
Jan 12, 2026
Merged
Add members page to domain #77872
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
7a4ba4b
add members page to domains
sumo-slonik 7d2aaef
Merge branch 'main' into feature/kuba-nowakowski/add__domain_members_…
sumo-slonik 276fd9e
fix general members component after marge from main
sumo-slonik 4fc8339
fix SecurityGroup type
sumo-slonik 5d2698e
review changes
sumo-slonik d376360
changes after review without components from main
sumo-slonik 984e680
Merge branch 'main' into feature/kuba-nowakowski/add__domain_members_…
sumo-slonik f8d5411
changes after review with components from main
sumo-slonik 010d826
add test to selector
sumo-slonik 896d64a
simplify selector
sumo-slonik 2cdf216
remove unnecessary useMemo, useCallback
sumo-slonik ac42828
Merge branch 'main' into feature/kuba-nowakowski/add__domain_members_…
sumo-slonik 00d70f1
add new admin features to page using baseMemberPage
sumo-slonik 5313572
remove callback
sumo-slonik 96e0d89
npm run prettier
sumo-slonik 7183f29
add spain translations
sumo-slonik fcd8581
remove polish comment
sumo-slonik 56ba188
Merge branch 'main' into feature/kuba-nowakowski/add__domain_members_…
sumo-slonik 6cbbbd8
Merge branch 'main' into feature/kuba-nowakowski/add__domain_members_…
sumo-slonik 900a841
remove polish comment
sumo-slonik 827b5fc
fix selector typing
sumo-slonik 4d9aa05
fix import
sumo-slonik b01543f
remove unnecessary if(loading)
sumo-slonik 2e74fa4
resolve Jan's comments
sumo-slonik 8baba9b
Merge branch 'main' into feature/kuba-nowakowski/add__domain_members_…
war-in 10467eb
chore: add translations
war-in a0a234a
fix: improve types in addAdminToDomain
war-in 7c2c1c4
feat: update icons
war-in ef1ced1
Merge branch 'main' into feature/kuba-nowakowski/add__domain_members_…
war-in 9bb3367
refactor: move expensify_adminPermissions_ and domain_securityGroup_ …
war-in 9bd0c0e
chore: compress svg
war-in 501fb34
chore: fix eslint
war-in f933295
Merge branch 'refs/heads/main' into feature/kuba-nowakowski/add__doma…
war-in 718e428
refactor: address review
war-in 0aeee27
fix: dont show Hidden as selected on add primary contact page
war-in b32bdc1
Merge branch 'main' into feature/kuba-nowakowski/add__domain_members_…
war-in d666c78
fix: prettier
war-in 50fe039
Merge branch 'refs/heads/main' into feature/kuba-nowakowski/add__doma…
war-in c5f471f
fix: post-merge fixes
war-in 8c48a19
Merge branch 'main' into feature/kuba-nowakowski/add__domain_members_…
war-in File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
assets/images/simple-illustrations/simple-illustration__user-shield.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -70,11 +70,13 @@ function DomainAddPrimaryContactPage({route}: DomainAddPrimaryContactPageProps) | |
| } | ||
|
|
||
| const details = personalDetails?.[accountID]; | ||
| if (details?.login === technicalContactSettings?.technicalContactEmail) { | ||
| let isSelected = false; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NAB: Since all we need from the |
||
| if (!!details?.login && !!technicalContactSettings?.technicalContactEmail && details.login === technicalContactSettings.technicalContactEmail) { | ||
| technicalContactEmailKey = String(accountID); | ||
| isSelected = true; | ||
| } | ||
| data.push({ | ||
| isSelected: details?.login === technicalContactSettings?.technicalContactEmail, | ||
| isSelected, | ||
| keyForList: String(accountID), | ||
| accountID, | ||
| login: details?.login ?? '', | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why the formatting is bit different for each of these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's how the parrot did that. I didn't change anything so not sure too 🤷
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try npm run prettier?
But as I remember, we have a similar format in other places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I tried that