[No QA]Reduce run time in cspell by 10x - #77828
Merged
Merged
Conversation
melvin-bot
Bot
requested review from
marcochavezf
and removed request for
a team
December 17, 2025 00:37
|
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
requested review from
trjExpensify
and removed request for
a team
December 17, 2025 00:46
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Hold as I am doing some testing, |
Codecov Report✅ All modified and coverable lines are covered by tests. |
trjExpensify
removed their request for review
December 17, 2025 16:30
Contributor
|
PR doesn’t need product input as a DevX PR. Unassigning and unsubscribing myself. |
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index d3f2b7f6..9c1467ad 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -833,7 +833,7 @@ const translations: TranslationDeepObject<typeof en> = {
searchForSomeone: 'Nach jemandem suchen',
},
customApprovalWorkflow: {
- title: 'Benutzerdefinierter Genehmigungsworkflow',
+ title: 'Benutzerdefinierter Genehmigungs-Workflow',
description: 'Ihr Unternehmen verwendet in diesem Workspace einen benutzerdefinierten Genehmigungs-Workflow. Bitte führen Sie diese Aktion in Expensify Classic aus',
goToExpensifyClassic: 'Zu Expensify Classic wechseln',
},
@@ -2249,7 +2249,7 @@ ${amount} für ${merchant} – ${date}`,
addApprovalTip: 'Dieser Standard-Workflow gilt für alle Mitglieder, sofern kein spezifischerer Workflow vorhanden ist.',
approver: 'Genehmiger',
addApprovalsDescription: 'Zusätzliche Genehmigung anfordern, bevor eine Zahlung autorisiert wird.',
- makeOrTrackPaymentsTitle: 'Zahlungen erstellen oder verfolgen',
+ makeOrTrackPaymentsTitle: 'Zahlungen ausführen oder nachverfolgen',
makeOrTrackPaymentsDescription:
'Fügen Sie eine autorisierte zahlende Person für Zahlungen hinzu, die in Expensify getätigt werden, oder verfolgen Sie Zahlungen, die andernorts vorgenommen wurden.',
customApprovalWorkflowEnabled:
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 9d7b9a18..3dbbc114 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -837,7 +837,7 @@ const translations: TranslationDeepObject<typeof en> = {
searchForSomeone: 'Rechercher quelqu’un',
},
customApprovalWorkflow: {
- title: 'Flux d’approbation personnalisé',
+ title: 'Workflow d’approbation personnalisé',
description: 'Votre entreprise utilise un flux de validation personnalisé sur cet espace de travail. Veuillez effectuer cette action dans Expensify Classic',
goToExpensifyClassic: 'Passer à Expensify Classic',
},
@@ -2244,7 +2244,7 @@ ${amount} pour ${merchant} - ${date}`,
workflowsPage: {
workflowTitle: 'Dépenses',
workflowDescription: 'Configurez un flux de travail depuis le moment où la dépense a lieu, en incluant l’approbation et le paiement.',
- submissionFrequency: 'Fréquence d’envoi',
+ submissionFrequency: 'Fréquence de soumission',
submissionFrequencyDescription: 'Choisissez un planning personnalisé pour soumettre les dépenses.',
submissionFrequencyDateOfMonth: 'Jour du mois',
disableApprovalPromptDescription: 'La désactivation des approbations effacera tous les workflows d’approbation existants.',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index cdecb098..7906cfcf 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -2242,7 +2242,7 @@ ${amount} per ${merchant} - ${date}`,
addApprovalTip: 'Questo flusso di lavoro predefinito si applica a tutti i membri, a meno che non esista un flusso di lavoro più specifico.',
approver: 'Approvatore',
addApprovalsDescription: "Richiedi un'approvazione aggiuntiva prima di autorizzare un pagamento.",
- makeOrTrackPaymentsTitle: 'Effettua o monitora pagamenti',
+ makeOrTrackPaymentsTitle: 'Effettua o tieni traccia dei pagamenti',
makeOrTrackPaymentsDescription: 'Aggiungi un pagatore autorizzato per i pagamenti effettuati in Expensify o tieni traccia dei pagamenti effettuati altrove.',
customApprovalWorkflowEnabled:
'<muted-text-label>Un flusso di approvazione personalizzato è abilitato in questo workspace. Per rivedere o modificare questo flusso di lavoro, contatta il tuo <account-manager-link>Account Manager</account-manager-link> o <concierge-link>Concierge</concierge-link>.</muted-text-label>',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 3e62d11f..310f1dd3 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -2235,7 +2235,7 @@ ${merchant} への ${amount}（${date}）`,
addApprovalTip: 'より詳細なワークフローが存在しない限り、このデフォルトのワークフローはすべてのメンバーに適用されます。',
approver: '承認者',
addApprovalsDescription: '支払いを承認する前に、追加の承認を要求する。',
- makeOrTrackPaymentsTitle: '支払いの作成や追跡を行う',
+ makeOrTrackPaymentsTitle: '支払いの作成または追跡',
makeOrTrackPaymentsDescription: 'Expensify で行われる支払い用の承認済み支払者を追加するか、他で行われた支払いを追跡します。',
customApprovalWorkflowEnabled:
'<muted-text-label>このワークスペースではカスタム承認ワークフローが有効になっています。このワークフローを確認または変更するには、<account-manager-link>アカウントマネージャー</account-manager-link>または<concierge-link>Concierge</concierge-link>までご連絡ください。</muted-text-label>',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index eaa4dfc0..e01bdcf7 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -2240,7 +2240,7 @@ ${amount} voor ${merchant} - ${date}`,
addApprovalTip: 'Deze standaardworkflow is van toepassing op alle leden, tenzij er een specifiekere workflow bestaat.',
approver: 'Fiatteur',
addApprovalsDescription: 'Extra goedkeuring vereisen voordat een betaling wordt geautoriseerd.',
- makeOrTrackPaymentsTitle: 'Betalingen uitvoeren of volgen',
+ makeOrTrackPaymentsTitle: 'Betalingen uitvoeren of bijhouden',
makeOrTrackPaymentsDescription: 'Voeg een gemachtigde betaler toe voor betalingen die in Expensify worden gedaan of houd betalingen bij die elders worden gedaan.',
customApprovalWorkflowEnabled:
'<muted-text-label>Er is een aangepast goedkeuringsworkflow ingeschakeld voor deze workspace. Neem contact op met uw <account-manager-link>Account Manager</account-manager-link> of <concierge-link>Concierge</concierge-link> om deze workflow te bekijken of te wijzigen.</muted-text-label>',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 7832371a..e5a6c9d4 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -885,7 +885,7 @@ const translations: TranslationDeepObject<typeof en> = {
sendAttachment: 'Wyślij załącznik',
addAttachment: 'Dodaj załącznik',
writeSomething: 'Napisz coś...',
- blockedFromConcierge: 'Komunikacja jest zabroniona',
+ blockedFromConcierge: 'Komunikacja jest zablokowana',
fileUploadFailed: 'Przesyłanie nie powiodło się. Plik nie jest obsługiwany.',
localTime: ({user, time}: LocalTimeParams) => `Jest ${time} dla ${user}`,
edited: '(edytowano)',
@@ -2228,7 +2228,7 @@ ${amount} dla ${merchant} - ${date}`,
workflowsPage: {
workflowTitle: 'Wydatki',
workflowDescription: 'Skonfiguruj proces od momentu poniesienia wydatku, obejmujący akceptację i płatność.',
- submissionFrequency: 'Częstotliwość zgłoszeń',
+ submissionFrequency: 'Częstotliwość przesyłania',
submissionFrequencyDescription: 'Wybierz niestandardowy harmonogram przesyłania wydatków.',
submissionFrequencyDateOfMonth: 'Dzień miesiąca',
disableApprovalPromptDescription: 'Wyłączenie zatwierdzeń usunie wszystkie istniejące przepływy pracy zatwierdzania.',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 8e3eec5a..ddde940d 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -885,7 +885,7 @@ const translations: TranslationDeepObject<typeof en> = {
sendAttachment: 'Enviar anexo',
addAttachment: 'Adicionar anexo',
writeSomething: 'Escreva algo...',
- blockedFromConcierge: 'A comunicação está bloqueada',
+ blockedFromConcierge: 'Comunicação está bloqueada',
fileUploadFailed: 'Falha no upload. Arquivo não é compatível.',
localTime: ({user, time}: LocalTimeParams) => `É ${time} para ${user}`,
edited: '(editado)',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 0ee2a324..499dbfbb 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -2206,7 +2206,7 @@ ${amount}，商户：${merchant} - ${date}`,
addApprovalTip: '此默认工作流程适用于所有成员，除非存在更具体的工作流程。',
approver: '审批人',
addApprovalsDescription: '在授权付款前需要额外审批。',
- makeOrTrackPaymentsTitle: '发起或跟踪付款',
+ makeOrTrackPaymentsTitle: '进行或跟踪付款',
makeOrTrackPaymentsDescription: '为在 Expensify 中进行的付款添加授权付款人，或跟踪在其他地方进行的付款。',
customApprovalWorkflowEnabled:
'<muted-text-label>此工作区已启用自定义审批流程。要查看或更改此流程，请联系您的<account-manager-link>客户经理</account-manager-link>或<concierge-link>Concierge</concierge-link>。</muted-text-label>',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
roryabraham
requested changes
Dec 17, 2025
Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
roryabraham
approved these changes
Dec 17, 2025
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.82-0 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.82-0 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.82-0 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.84-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.84-8 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
cspelltimes are taking ~7 minutes and is our third most used action (by total minutes). This will reduce the run time while still reliably checking spelling by doing the following:spellandspell-changedscript topackage.jsonspell-changedscript directly to only run on changed files asincremental_files_onlyis not workingcspelland use it across runsTests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop