Skip to content

[CP Staging] Revert "fix: Duplicate Self DM chat displayed in LHN after unreporting an expense" #77686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoisl merged 1 commit into from
Dec 15, 2025
+0 −13
Merged

[CP Staging] Revert "fix: Duplicate Self DM chat displayed in LHN after unreporting an expense" #77686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/ONYXKEYS.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,9 +538,6 @@ const ONYXKEYS = {
/** The user's Concierge reportID */
CONCIERGE_REPORT_ID: 'conciergeReportID',

/** The user's Self DM reportID */
SELF_DM_REPORT_ID: 'selfDMReportID',

/** The details of unknown user while sharing a file - we don't know if they exist */
SHARE_UNKNOWN_USER_DETAILS: 'shareUnknownUserDetails',

Expand Down Expand Up @@ -1304,7 +1301,6 @@ type OnyxValuesMapping = {
[ONYXKEYS.IS_USING_IMPORTED_STATE]: boolean;
[ONYXKEYS.NVP_EXPENSIFY_COMPANY_CARDS_CUSTOM_NAMES]: Record<string, string>;
[ONYXKEYS.CONCIERGE_REPORT_ID]: string;
[ONYXKEYS.SELF_DM_REPORT_ID]: string;
[ONYXKEYS.SHARE_UNKNOWN_USER_DETAILS]: Participant;
[ONYXKEYS.SHARE_TEMP_FILE]: OnyxTypes.ShareTempFile;
[ONYXKEYS.VALIDATED_FILE_OBJECT]: OnyxTypes.FileObject | undefined;
Expand Down
9 changes: 0 additions & 9 deletions src/libs/ReportUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1199,12 +1199,6 @@ Onyx.connectWithoutView({
},
});

let cachedSelfDMReportID: OnyxEntry<string>;
Onyx.connectWithoutView({
key: ONYXKEYS.SELF_DM_REPORT_ID,
callback: (value) => (cachedSelfDMReportID = value),
});

let hiddenTranslation = '';
let unavailableTranslation = '';

Expand Down Expand Up @@ -1868,9 +1862,6 @@ function isConciergeChatReport(report: OnyxInputOrEntry<Report>): boolean {
}

function findSelfDMReportID(): string | undefined {
if (cachedSelfDMReportID) {
return cachedSelfDMReportID;
}
if (!allReports) {
return;
}
Expand Down
Loading