Skip to content

Do not show removed reports in LHN #77670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 2 commits into from
Dec 19, 2025
Merged

Do not show removed reports in LHN #77670

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29b63a7
Do not show removed reports in LHN
jnowakow Dec 15, 2025
673b481
Merge branch 'main' of github.com:Expensify/App into jnowakow/dont-sh…
jnowakow Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libs/SidebarUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@ function updateReportsToDisplayInLHN({
for (const reportID of updatedReportsKeys) {
const report = reports?.[reportID];
if (!report?.reportID && report?.pendingFields?.reportID !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {
delete displayedReportsCopy[reportID];

@mountiny mountiny Dec 18, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnowakow Are you sure there were no other cases where we might want to still show the report in the LHN when this conditions runs? It sounds odd we would not be deleting the reports already

@jnowakow jnowakow Dec 19, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it wouldn't make sense to display report that doesn't have reportID because we would not be able to navigate to it

@mountiny mountiny Dec 19, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, though it is one of those things that sounds so obvious that I would like to know why we dont already do this 😂

continue;
}

Expand Down
Loading