Skip to content

Revert "[CP staging] Hide Change approver option when Add approvals is disabled in Workflows"#77470

Merged
yuwenmemon merged 1 commit into
mainfrom
revert-77321-fix/77319
Dec 12, 2025
Merged

Revert "[CP staging] Hide Change approver option when Add approvals is disabled in Workflows"#77470
yuwenmemon merged 1 commit into
mainfrom
revert-77321-fix/77319

Conversation

@yuwenmemon

Copy link
Copy Markdown
Contributor

@jasperhuangg please review

I need to revert this hotfix PR so that I can revert the actual PR (#75729) that caused 3+ blockers in the deploy.

Reverts #77321

Next time, please follow this StackOverflow: https://stackoverflowteams.com/c/expensify/questions/11964

@yuwenmemon yuwenmemon self-assigned this Dec 12, 2025
@yuwenmemon yuwenmemon requested review from a team as code owners December 12, 2025 00:09
@melvin-bot melvin-bot Bot requested review from heyjennahay and madmax330 and removed request for a team December 12, 2025 00:09
@melvin-bot

melvin-bot Bot commented Dec 12, 2025

Copy link
Copy Markdown

@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@codecov

codecov Bot commented Dec 12, 2025

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/SearchUIUtils.ts 73.36% <100.00%> (-0.03%) ⬇️
... and 3 files with indirect coverage changes

@yuwenmemon yuwenmemon merged commit 72aae9c into main Dec 12, 2025
32 of 34 checks passed
@yuwenmemon yuwenmemon deleted the revert-77321-fix/77319 branch December 12, 2025 00:21
@melvin-bot melvin-bot Bot added the Emergency label Dec 12, 2025
@melvin-bot

melvin-bot Bot commented Dec 12, 2025

Copy link
Copy Markdown

@yuwenmemon looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@yuwenmemon

Copy link
Copy Markdown
Contributor Author

Not an emergency, straight revert

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Dec 12, 2025
Revert "[CP staging] Hide Change approver option when Add approvals is disabled in Workflows"

(cherry picked from commit 72aae9c)

(cherry-picked to staging by yuwenmemon)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Dec 12, 2025
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.2.75-9 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.2.75-11 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.2.77-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.77-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.2.78-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.78-8 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

marcaaron pushed a commit that referenced this pull request Apr 3, 2026
@OSBotify

OSBotify commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.3.53-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes are required for this PR.

This PR reverts a single code condition in src/libs/SearchUIUtils.ts that controlled when the "Change approver" action appears in search results. The change:

  • Removes an approvalMode check that was hiding the "Change approver" option when approvals were disabled
  • Does not add, remove, or rename any user-facing features, settings labels, or workflows
  • Does not change any documented user flows

The existing help article (docs/articles/new-expensify/workspaces/Add-Approvals.md) covers approval workflow configuration and is unaffected by this revert.

@OSBotify

OSBotify commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.3.53-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

@m-natarajan

Copy link
Copy Markdown

@yuwenmemon @madmax330 No QA steps, OK to checkoff this one?

@OSBotify

OSBotify commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.53-7 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging Emergency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants