Skip to content

[No QA] fix(ci/prettier): Export 'hasAction' is not defined #77194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcaaron merged 2 commits into from
Dec 10, 2025
Merged

[No QA] fix(ci/prettier): Export 'hasAction' is not defined #77194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5625a10
fix(ci/prettier): Export 'hasAction' is not defined
gelocraft Dec 10, 2025
d6dc9e3
restore: restore to previous state
gelocraft Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/prettier.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:

- name: Verify there's no Prettier diff
run: |
npm run prettier -- --log-level silent
npm run prettier -- --log-level error
if ! git diff --name-only --exit-code; then
# shellcheck disable=SC2016
echo 'Error: Prettier diff detected! Please run `npm run prettier` and commit the changes.'
Expand Down
5 changes: 3 additions & 2 deletions src/types/expo-store-review.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
declare module 'expo-store-review' {
const hasAction: (() => boolean) | undefined;
// eslint-disable-next-line rulesdir/no-inline-named-export
export const hasAction: (() => boolean) | undefined;
function isAvailableAsync(): Promise<boolean>;
function requestReview(): Promise<void>;

export {hasAction, isAvailableAsync, requestReview};

@marcaaron marcaaron Dec 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this would cause an error one way but not the other way.

@marcaaron marcaaron Dec 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a prettier bug maybe?

@gelocraft gelocraft Dec 10, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because in declare block you're not actually defining the code, you only describe it shape that's why we get this error Export 'hasAction' is not defined

export {isAvailableAsync, requestReview};
}
Loading