Skip to content

fix-77145 #77153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DylanDylann wants to merge 6 commits into from
Closed

fix-77145 #77153

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aebb437
fix-77145
DylanDylann Dec 9, 2025
8b41584
Merge branch 'main' into fix/77145
DylanDylann Dec 9, 2025
9413848
update
DylanDylann Dec 9, 2025
6959dd4
prettier
DylanDylann Dec 9, 2025
108e960
Merge branch 'main' of github.com:Expensify/App into fix/77145
yuwenmemon Dec 10, 2025
ba6bc3e
ESLint again
yuwenmemon Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/libs/ReportUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@
import Parser from './Parser';
import {getParsedMessageWithShortMentions} from './ParsingUtils';
import Permissions from './Permissions';
import {getReportName as getReportNameReportNameUtils} from '@libs/ReportNameUtils';

Check failure on line 134 in src/libs/ReportUtils.ts

View workflow job for this annotation

GitHub Actions / ESLint check 

`@libs/ReportNameUtils` import should occur before import of `./actions/BankAccounts`

Check failure on line 134 in src/libs/ReportUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

`@libs/ReportNameUtils` import should occur before import of `./actions/BankAccounts`

Check warning on line 134 in src/libs/ReportUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Unexpected subpath import via alias '@libs/ReportNameUtils'. Use './ReportNameUtils' instead
import {
getAccountIDsByLogins,
getDisplayNameOrDefault,
Expand Down Expand Up @@ -6846,7 +6847,7 @@
};
}

if (isInstantSubmitEnabledLocal) {
if (isInstantSubmitEnabledLocal && !isEmptyOptimisticReport) {
return {
stateNum: CONST.REPORT.STATE_NUM.SUBMITTED,
statusNum: CONST.REPORT.STATUS_NUM.SUBMITTED,
Expand Down Expand Up @@ -7025,7 +7026,7 @@
const fromReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${fromReportID}`];

const report = fromReport ?? toReport;
const reportName = getReportName(report) ?? report?.reportName ?? '';
const reportName = getReportNameReportNameUtils(report) ?? report?.reportName ?? '';
let reportUrl = getReportURLForCurrentContext(report?.reportID);
if (typeof fromReportID === 'undefined') {
// eslint-disable-next-line @typescript-eslint/no-deprecated
Expand Down Expand Up @@ -7054,7 +7055,7 @@

const fromReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${fromReportID}`];

const reportName = getReportName(fromReport) ?? fromReport?.reportName ?? '';
const reportName = getReportNameReportNameUtils(fromReport) ?? fromReport?.reportName ?? '';

let reportUrl = `${environmentURL}/r/${fromReport?.reportID}`;

Expand Down
Loading