Fix empty task and profile image showing on secondary device after leaving group#77122
Conversation
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
heyjennahay
left a comment
There was a problem hiding this comment.
No concern with product change
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-12-11.at.7.22.54.PM.movAndroid: mWeb ChromeScreen.Recording.2025-12-11.at.7.24.11.PM.moviOS: HybridAppScreen.Recording.2025-12-11.at.7.14.51.PM.moviOS: mWeb SafariScreen.Recording.2025-12-11.at.7.16.34.PM.movMacOS: Chrome / SafariScreen.Recording.2025-12-11.at.7.11.58.PM.mov |
abdulrahuman5196
left a comment
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @AndrewGable
🎀 👀 🎀
C+ Reviewed
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.2.78-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.78-8 🚀
|
Explanation of Change
Since the group report is removed on all devices when the user leaves the group, we should add a check for quickActionReport before displaying the quick action from QUICK_ACTION_GLOBAL_CREATE. That way, if the associated report no longer exists, we avoid rendering invalid quick actions
Fixed Issues
$ #74143
PROPOSAL: #74143 (comment)
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-12-09.at.17.23.22.mov
Android: mWeb Chrome
Screen.Recording.2025-12-09.at.17.11.59.mov
iOS: Native
Screen.Recording.2025-12-09.at.17.03.04.mov
iOS: mWeb Safari
Screen.Recording.2025-12-09.at.17.01.14.mov
MacOS: Chrome / Safari
Screen.Recording.2025-12-09.at.17.00.33.mov