Migrate icons integration - status & indicators to lazy loading by annaweber830 · Pull Request #76965 · Expensify/App

annaweber830 · 2025-12-08T07:05:09Z

Explanation of Change

Fixed Issues

$#75257
PROPOSAL:#75257 (comment)

Tests

Click + button and check menu icons
Click right mouse button and check menu icons
Go to workspace and enable accounting feature and in account check icons

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console
Same as Tests

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-12-11.at.9.41.07.PM.mp4

Android: mWeb Chrome

Screen.Recording.2025-12-11.at.9.46.41.PM.mp4

iOS: Native

Screen.Recording.2025-12-11.at.7.07.48.PM.mp4

iOS: mWeb Safari

Screen.Recording.2025-12-11.at.7.15.11.PM.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-12-11.at.1.37.36.PM.mp4

melvin-bot · 2025-12-08T07:05:15Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2025-12-08T07:05:15Z

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-12-08T07:13:19Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/AttachmentOfflineIndicator.tsx	`63.63% <100.00%> (+3.63%)`	⬆️
src/components/FormHelpMessage.tsx	`73.33% <100.00%> (+1.90%)`	⬆️
src/components/GrowlNotification/index.tsx	`100.00% <100.00%> (ø)`
src/components/InlineSystemMessage.tsx	`57.14% <100.00%> (+7.14%)`	⬆️
src/components/OfflineIndicator.tsx	`100.00% <100.00%> (ø)`
src/components/ThumbnailImage.tsx	`87.09% <100.00%> (ø)`
src/hooks/useSearchTypeMenuSections.ts	`100.00% <100.00%> (ø)`
src/libs/SearchUIUtils.ts	`73.38% <ø> (ø)`
...ortActionCompose/AttachmentPickerWithMenuItems.tsx	`48.43% <100.00%> (ø)`
...es/home/sidebar/FloatingActionButtonAndPopover.tsx	`51.90% <100.00%> (ø)`
... and 42 more
... and 13 files with indirect coverage changes

linhvovan29546

Could you please fix some warning and eslint error?

linhvovan29546 · 2025-12-08T07:49:23Z

            },
        ],
-        [icons.NewWindow, shouldShowEnterCredentials, shouldShowReinstallConnectorMenuItem, translate, isOffline, policy, connectedIntegration, startIntegrationFlow],
+        [


Please fix this warning

linhvovan29546 · 2025-12-08T07:49:43Z

@@ -400,7 +418,7 @@ function PolicyAccountingPage({policy}: PolicyAccountingPageProps) {
            ...(isEmptyObject(policy?.connections) || !isConnectionVerified ? [] : configurationOptions),
        ];
    }, [


Please fix this warning

I am checking lint error and fixing. Could you wait me?

linhvovan29546 · 2025-12-08T09:53:14Z

@annaweber830 Is this ready for review?

annaweber830 · 2025-12-08T11:14:20Z

@annaweber830 Is this ready for review?

Yes

linhvovan29546 · 2025-12-08T11:25:40Z

Next time, please only mark the PR as 'Ready' when it is actually ready.
And If you've made changes and want another review, leave a comment on the PR that says 'Updated' per the contributing guidelines .

linhvovan29546 · 2025-12-08T11:33:01Z

    return getMostRecentlyVisitedReport(reportsValues, allReportMetadata);
 }

+/**


Why do we need to change these lines? This PR's scope is only icon migration. If that's triggering an ESLint failure, why is the lint error appearing only in this PR and not in others?

linhvovan29546 · 2025-12-08T11:37:31Z

                    : {
                          description: translate('workspace.intacct.entity'),
-                          iconRight: Expensicons.ArrowRight,
+                          iconRight: icons.ArrowRight,


Missing dependency icons

trjExpensify · 2025-12-08T11:52:34Z

PR doesn’t need product input as a migration PR. Unassigning and unsubscribing myself.

linhvovan29546 · 2025-12-09T02:06:00Z

 * Whether the provided report has expenses
 */
-function hasExpenses(reportID?: string, transactions?: Array<OnyxEntry<Transaction>>): boolean {
+function hasExpenses(reportID?: string, transactions?: Transaction[] | Array<OnyxEntry<Transaction>>): boolean {


Same as #76965 (comment) Could you please re-check all changes in this file? These unnecessary modifications create noisy commits

Could you please re-check all changes in this file?

👆

There are still many unnecessary modification types. I didn't add a comment since it changes too much lines.

Got it, I will look into it further.

annaweber830 · 2025-12-09T16:41:49Z

Hi @linhvovan29546, should I go ahead and resolve these conflicts, or should I wait?

linhvovan29546 · 2025-12-10T02:00:02Z

Hi @linhvovan29546, should I go ahead and resolve these conflicts, or should I wait?

Please resolve the conflict. Also, please don't forget this comment

linhvovan29546

Could you please fix the ESLint failure by adding // eslint-disable-next-line @typescript-eslint/no-deprecated?

linhvovan29546 · 2025-12-11T11:34:37Z


    const transaction = linkedTransaction ?? getLinkedTransaction(reportAction ?? undefined);

-    // In case the transaction is failed to be created, we should disable editing the money request


Please re-add this comment

I re-added this comment and ready for review.

…o refix-75257

linhvovan29546 · 2025-12-11T14:20:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-11.at.19.02.10.mov

Android: mWeb Chrome

Screen.Recording.2025-12-11.at.18.59.43.mov

iOS: HybridApp

Screen.Recording.2025-12-11.at.19.05.56.mov

iOS: mWeb Safari

Screen.Recording.2025-12-11.at.19.03.39.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-11.at.18.55.00.mov

mollfpr · 2025-12-11T15:07:58Z

QA can test this, so we should have a few simple test step to verify the migrated assets is working.

@annaweber830 Could you add the test step and you should have recording verifying the asset like in the reviewer checklist.

annaweber830 · 2025-12-12T06:17:06Z

QA can test this, so we should have a few simple test step to verify the migrated assets is working.

@annaweber830 Could you add the test step and you should have recording verifying the asset like in the reviewer checklist.

Hi @mollfpr I added test step and recording my PR.

mollfpr

LGTM! Thank you all!

OSBotify · 2025-12-12T07:03:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-12T22:28:41Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.2.78-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-16T22:25:36Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.78-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

annaweber added 2 commits December 7, 2025 23:00

fix: 75257 issue

5b6f868

fix: issue report action menu

94f4106

annaweber830 requested review from a team as code owners December 8, 2025 07:05

melvin-bot Bot assigned annaweber830 Dec 8, 2025

melvin-bot Bot requested a review from linhvovan29546 December 8, 2025 07:05

melvin-bot Bot requested review from trjExpensify and removed request for a team December 8, 2025 07:05

linhvovan29546 reviewed Dec 8, 2025

View reviewed changes

annaweber830 added 2 commits December 8, 2025 00:26

fix: lint error

3d84aec

fix: prettier

71a02a4

linhvovan29546 reviewed Dec 8, 2025

View reviewed changes

trjExpensify removed their request for review December 8, 2025 11:52

fix: remove code error

05dee85

annaweber830 requested a review from linhvovan29546 December 8, 2025 19:39

linhvovan29546 reviewed Dec 9, 2025

View reviewed changes

fix: remove unnecessay code

9190583

annaweber830 added 2 commits December 10, 2025 04:59

Merge branch 'main' into refix-75257

a55cbe9

fix: lint error

2d1539f

annaweber830 added 4 commits December 10, 2025 07:10

fix: getreoport name deprecated

5884075

fix: report remove unnecessay change

da965ea

fix: report remove unnecessay change

8fc3ac4

Merge branch 'main' into refix-75257

40cfc54

linhvovan29546 reviewed Dec 11, 2025

View reviewed changes

annaweber830 added 4 commits December 11, 2025 04:16

fix: report comment

827087d

Merge branch 'refix-75257' of https://github.com/annaweber830/App int…

2256eb6

…o refix-75257

fix: lint error

329f48b

fix: prettier error

80b7656

linhvovan29546 approved these changes Dec 11, 2025

View reviewed changes

melvin-bot Bot requested a review from mollfpr December 11, 2025 14:24

mollfpr changed the title ~~[No QA] Migrate icons integration - status & indicators to lazy loading~~ Migrate icons integration - status & indicators to lazy loading Dec 12, 2025

mollfpr approved these changes Dec 12, 2025

View reviewed changes

mollfpr merged commit bef3a14 into Expensify:main Dec 12, 2025
34 of 35 checks passed

OSBotify mentioned this pull request Dec 12, 2025

Deploy Checklist: New Expensify 2025-12-12 #77578

Closed

linhvovan29546 mentioned this pull request Dec 24, 2025

[Payment due 12-23-25][$125] Migrate icons integration - status & indicators to lazy loading #75257

Closed


		const transaction = linkedTransaction ?? getLinkedTransaction(reportAction ?? undefined);

		// In case the transaction is failed to be created, we should disable editing the money request

Uh oh!

Conversation

annaweber830 commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 8, 2025

Uh oh!

melvin-bot Bot commented Dec 8, 2025

Uh oh!

codecov Bot commented Dec 8, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

linhvovan29546 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 commented Dec 8, 2025

Uh oh!

annaweber830 commented Dec 8, 2025

Uh oh!

linhvovan29546 commented Dec 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

trjExpensify commented Dec 8, 2025

Uh oh!

linhvovan29546 Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

annaweber830 commented Dec 9, 2025

Uh oh!

linhvovan29546 commented Dec 10, 2025

Uh oh!

linhvovan29546 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mollfpr commented Dec 11, 2025

Uh oh!

annaweber830 commented Dec 12, 2025

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

annaweber830 commented Dec 8, 2025 •

edited

Loading

codecov Bot commented Dec 8, 2025 •

edited by github-actions Bot

Loading

linhvovan29546 left a comment •

edited

Loading

linhvovan29546 Dec 8, 2025 •

edited

Loading

linhvovan29546 Dec 9, 2025 •

edited

Loading

linhvovan29546 commented Dec 11, 2025 •

edited

Loading