fix: Reports - Workspace name in search input, changes to a code when member is removed#76879
Conversation
… member is removed
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
…licyNameWithFallback
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…ch-input-changes-to-a-code-when-member-is-removed
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Fine from a product perspective
…ch-input-changes-to-a-code-when-member-is-removed
…llback instead of module-level subscription
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-12-11.at.22.35.40.movAndroid: mWeb ChromeScreen.Recording.2025-12-11.at.22.39.21.moviOS: HybridAppScreen.Recording.2025-12-11.at.22.29.01.moviOS: mWeb SafarimSafari.movMacOS: Chrome / SafariScreen.Recording.2025-12-11.at.22.15.34.mov |
…ch-input-changes-to-a-code-when-member-is-removed
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.2.78-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.78-8 🚀
|
Explanation of Change
This PR fixes workspace name in search input changing to policy ID when user is removed from workspace by falling back to cached names in reports.
Fixed Issues
$ #75957
PROPOSAL: #75957 (comment)
Tests
Prerequisite: Have two accounts opened on two different devices or environments.
Prerequisite 2: User A has at least one workspace created.
Offline tests
Same as tests
QA Steps
Same as tests
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android-Native.mp4
Android: mWeb Chrome
Android-mWeb.mp4
iOS: Native
iOS-App.mp4
iOS: mWeb Safari
iOS-Safari.mp4
MacOS: Chrome / Safari
Macbook-Chrome.mp4