Skip to content

Revert "Make CustomCloseDateSelectionList use new SelectionList"#76494

Merged
mollfpr merged 1 commit into
mainfrom
revert-76235-@zfurtak/CustomCloseDateSelectionList
Dec 2, 2025
Merged

Revert "Make CustomCloseDateSelectionList use new SelectionList"#76494
mollfpr merged 1 commit into
mainfrom
revert-76235-@zfurtak/CustomCloseDateSelectionList

Conversation

@Beamanator

@Beamanator Beamanator commented Dec 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@Beamanator Beamanator requested review from a team as code owners December 2, 2025 07:18
@melvin-bot melvin-bot Bot requested review from amyevans and trjExpensify and removed request for a team December 2, 2025 07:18
@melvin-bot

melvin-bot Bot commented Dec 2, 2025

Copy link
Copy Markdown

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

github-actions Bot commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

🚧 @Beamanator has triggered a test Expensify/App build. You can view the workflow run here.

@codecov

codecov Bot commented Dec 2, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...DateSelectionList/CustomCloseDateSelectionList.tsx 0.00% <0.00%> (ø)
... and 11 files with indirect coverage changes

@github-actions

github-actions Bot commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #76494.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/76494/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/76494/index.html
Android iOS
Web 🕸️
https://76494.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@Beamanator

Beamanator commented Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

FYI seems like type issues are already on main: https://expensify.slack.com/archives/C01GTK53T8Q/p1764665322139969

@mollfpr mollfpr merged commit 31904cb into main Dec 2, 2025
32 of 36 checks passed
@mollfpr mollfpr deleted the revert-76235-@zfurtak/CustomCloseDateSelectionList branch December 2, 2025 09:31
@melvin-bot

melvin-bot Bot commented Dec 2, 2025

Copy link
Copy Markdown

@mollfpr looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label Dec 2, 2025
@mollfpr mollfpr removed the Emergency label Dec 2, 2025
OSBotify pushed a commit that referenced this pull request Dec 2, 2025
@mollfpr @OSBotify
Merge pull request #76494 from Expensify/revert-76235-@zfurtak/Custom…
19f973c 
…CloseDateSelectionList

Revert "Make `CustomCloseDateSelectionList` use new `SelectionList`"

(cherry picked from commit 31904cb)

(cherry-picked to staging by Beamanator)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Dec 2, 2025
@OSBotify OSBotify mentioned this pull request Dec 2, 2025
Closed
@OSBotify

OSBotify commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.2.67-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Beamanator Beamanator mentioned this pull request Dec 2, 2025
Merged
53 tasks
@OSBotify

OSBotify commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.2.67-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.2.70-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.70-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.2.71-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.71-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mollfpr mollfpr mollfpr approved these changes
@trjExpensify trjExpensify Awaiting requested review from trjExpensify
@amyevans amyevans Awaiting requested review from amyevans

Assignees

@Beamanator Beamanator

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Beamanator @OSBotify @mollfpr