[No QA] fix(eslint): fix unicorn/no-array-for-each rule violations

src/hooks/useCardFeeds.tsx

@@ -49,16 +49,15 @@ const useCardFeeds = (policyID: string | undefined): [CombinedCardFeeds | undefi
                 return acc;
             }
 
-            // eslint-disable-next-line unicorn/no-array-for-each
-            Object.entries(feed.settings.companyCards).forEach(([key, feedSettings]) => {
+            for (const [key, feedSettings] of Object.entries(feed.settings.companyCards)) {
                 const feedName = key as CompanyCardFeed;
                 const feedOAuthAccountDetails = feed.settings.oAuthAccountDetails?.[feedName];
                 const feedCompanyCardNickname = feed.settings.companyCardNicknames?.[feedName];
                 const domainID = onyxKey.split('_').at(-1);
                 const shouldAddFeed = domainID && (feedSettings.preferredPolicy ? feedSettings.preferredPolicy === policyID : domainID === workspaceAccountID.toString());
 
                 if (!shouldAddFeed) {
-                    return;
+                    continue;
                 }
 
                 const combinedFeedKey = getCompanyCardFeedWithDomainID(feedName, domainID);
@@ -70,7 +69,7 @@ const useCardFeeds = (policyID: string | undefined): [CombinedCardFeeds | undefi
                     domainID: Number(domainID),
                     feed: feedName,
                 };
-            });
+            }
 
             return acc;
         }, result);

src/hooks/useDuplicateTransactionsAndViolations.ts

@@ -82,13 +82,14 @@ function selectTransactionsWithDuplicates(
             continue;
         }
 
-        transactionViolations
-            .filter((violations) => violations.name === CONST.VIOLATIONS.DUPLICATED_TRANSACTION)
-            .flatMap((violations) => violations?.data?.duplicates ?? [])
-            // eslint-disable-next-line unicorn/no-array-for-each
-            .forEach((duplicateID) => {
+        for (const violation of transactionViolations) {
+            if (violation.name !== CONST.VIOLATIONS.DUPLICATED_TRANSACTION) {
+                continue;
+            }
+
+            for (const duplicateID of violation.data?.duplicates ?? []) {
                 if (!duplicateID) {
-                    return;
+                    continue;
                 }
 
                 const duplicateKey = `${ONYXKEYS.COLLECTION.TRANSACTION}${duplicateID}`;
@@ -97,7 +98,8 @@ function selectTransactionsWithDuplicates(
                 if (duplicateTransaction) {
                     result[duplicateKey] = duplicateTransaction;
                 }
-            });
+            }
+        }
     }
     return result;
 }

src/libs/CardFeedUtils.ts

@@ -424,13 +424,12 @@ function getCardFeedsForDisplay(allCardFeeds: OnyxCollection<CardFeeds>, allCard
             continue;
         }
 
-        // eslint-disable-next-line unicorn/no-array-for-each
-        Object.keys(getOriginalCompanyFeeds(cardFeeds)).forEach((key) => {
+        for (const key of Object.keys(getOriginalCompanyFeeds(cardFeeds))) {
             const feed = key as CompanyCardFeed;
             const id = `${fundID}_${feed}`;
 
             if (cardFeedsForDisplay[id]) {
-                return;
+                continue;
             }
 
             cardFeedsForDisplay[id] = {
@@ -439,7 +438,7 @@ function getCardFeedsForDisplay(allCardFeeds: OnyxCollection<CardFeeds>, allCard
                 fundID,
                 name: getCustomOrFormattedFeedName(feed, cardFeeds?.settings?.companyCardNicknames?.[feed], false) ?? feed,
             };
-        });
+        }
     }
 
     for (const card of Object.values(allCards)) {
@@ -479,8 +478,7 @@ function getCardFeedsForDisplayPerPolicy(allCardFeeds: OnyxCollection<CardFeeds>
             continue;
         }
 
-        // eslint-disable-next-line unicorn/no-array-for-each
-        Object.entries(getOriginalCompanyFeeds(cardFeeds)).forEach(([key, feedData]) => {
+        for (const [key, feedData] of Object.entries(getOriginalCompanyFeeds(cardFeeds))) {
             const preferredPolicy = 'preferredPolicy' in feedData ? (feedData.preferredPolicy ?? '') : '';
             const feed = key as CompanyCardFeed;
             const id = `${fundID}_${feed}`;
@@ -491,7 +489,7 @@ function getCardFeedsForDisplayPerPolicy(allCardFeeds: OnyxCollection<CardFeeds>
                 fundID,
                 name: getCustomOrFormattedFeedName(feed, cardFeeds?.settings?.companyCardNicknames?.[feed], false) ?? feed,
             });
-        });
+        }
     }
 
     return cardFeedsForDisplayPerPolicy;

src/libs/CategoryOptionListUtils.ts

@@ -55,16 +55,22 @@ function getCategoryOptionTree(options: Record<string, Category> | Category[], i
             continue;
         }
 
-        // eslint-disable-next-line unicorn/no-array-for-each
-        option.name.split(CONST.PARENT_CHILD_SEPARATOR).forEach((optionName, index, array) => {
+        const array = option.name.split(CONST.PARENT_CHILD_SEPARATOR);
+
+        for (let index = 0; index < array.length; index++) {
+            const optionName = array.at(index);
+            if (!optionName) {
+                continue;
+            }
+
             const indents = times(index, () => CONST.INDENTS).join('');
             const isChild = array.length - 1 === index;
             const searchText = array.slice(0, index + 1).join(CONST.PARENT_CHILD_SEPARATOR);
             const selectedParentOption = !isChild && Object.values(selectedOptions).find((op) => op.name === searchText);
             const isParentOptionDisabled = !selectedParentOption || !selectedParentOption.enabled || selectedParentOption.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;
 
             if (optionCollection.has(searchText)) {
-                return;
+                continue;
             }
 
             const decodedCategoryName = getDecodedCategoryName(optionName);
@@ -77,7 +83,7 @@ function getCategoryOptionTree(options: Record<string, Category> | Category[], i
                 isSelected: isChild ? !!option.isSelected : !!selectedParentOption,
                 pendingAction: option.pendingAction,
             });
-        });
+        }
     }
 
     return Array.from(optionCollection.values());