[Policy Change Logs] Implement policy change log for: Workflows - Adding or modifying workflows by rayane-d · Pull Request #76260 · Expensify/App

rayane-d · 2025-11-27T22:29:37Z

Explanation of Change

Auth PR:

https://github.com/Expensify/Auth/pull/18466

Web-E PR:

https://github.com/Expensify/Web-Expensify/pull/49633

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/568305
PROPOSAL:

Tests

Prerequisites

A workspace with the Control plan (required for advanced approval workflows)
At least 4 workspace members: Admin (you), Member A, Member B, Member C
Go to workspace settings
Rename the workspace two times
Go the workspace #admins room
Verify that a system messages thread is created

Test Cases

Test 1: Change Default Approver

Navigate to Settings > Workspaces > [Your Workspace] > Workflows
Enable Add approvals if not already enabled
Click on the default approval workflow (showing "Everyone")
Click on the current approver
Select a different workspace member as the new approver
Save the changes
Navigate to the #admins room
Open the system messages thread

Expected Results:

A changelog entry appears in the system messages thread in the #admins room
Message format: changed the default approver to [new_approver_email] (previously [old_approver_email])
The LHN sidebar preview shows the correct changelog message text
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
Change app language, and verify that the changelog message is translated as expected
Create a thread under the changelog comment, and Verify that the thread report title displays the changelog message correctly

Screeenshot:

Recording:

1.mov

Test 2: Create New Approval Workflow - Single Member

Navigate to Settings > Workspaces > [Your Workspace] > Workflows
Click Add approval workflow button
In "Expenses from", select one member (e.g., Member A)
Click Next
Select an approver (e.g., Member B)
Save the workflow
Navigate to the #admins room
Open the system messages thread

Expected Results:

Message format: changed the approval workflow for [member_a_email] to submit reports to [member_b_email] (previously default approver [default_approver_email])
The LHN sidebar preview shows the correct changelog message text
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
Change app language, and verify that the changelog message is translated as expected
Create a thread under the changelog comment, and Verify that the thread report title displays the changelog message correctly

Screeenshot:

Recording:

2.mov

Test 3: Create New Approval Workflow - Two Members

Navigate to Settings > Workspaces > [Your Workspace] > Workflows
Click Add approval workflow button
In "Expenses from", select two members (e.g., Member A and Member B)
Click Next
Select an approver (e.g., Member C)
Save the workflow
Navigate to the #admins room
Open the system messages thread

Expected Results:

Message format: changed the approval workflow for [member_a_email] and [member_b_email] to submit reports to [member_c_email] (previously default approver [default_approver_email])
Members emails are joined with "and" (not comma)
The LHN sidebar preview shows the correct changelog message text
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
Change app language, and verify that the changelog message is translated as expected
Create a thread under the changelog comment, and Verify that the thread report title displays the changelog message correctly

Screeenshot:

Recording:

3.mov

Test 4: Create New Approval Workflow - Three or More Members

Navigate to Settings > Workspaces > [Your Workspace] > Workflows
Click Add approval workflow button
In "Expenses from", select three or more members
Click Next
Select an approver
Save the workflow
Navigate to the #admins room
Open the system messages thread

Expected Results:

Message format: changed the approval workflow for [member1], [member2], and [member3] to submit reports to [approver] (previously default approver [default_approver_email])
Oxford comma is used (comma before "and")
The LHN sidebar preview shows the correct changelog message text
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
Change app language, and verify that the changelog message is translated as expected
Create a thread under the changelog comment, and Verify that the thread report title displays the changelog message correctly

Screeenshot:

Recording:

4.mov

Test 5: Create Multi-Level Approval Workflow (forwardsTo)

Steps:

Navigate to Settings > Workspaces > [Your Workspace] > Workflows
Click Add approval workflow button
In "Expenses from", select Member A
Click Next
Select first approver (e.g., Member B)
Click Additional approver
Select second approver (e.g., Member C)
Save the workflow
Navigate to the #admins room
Open the system messages thread

Expected Results:

Two changelog entries appear in the #admins room:
1. changed the approval workflow for [member_a_email] to submit reports to [member_b_email] (previously default approver [default_approver_email])
2. changed the approval workflow for [member_b_email] to forward approved reports to [member_c_email] (previously final approved reports)
The LHN sidebar preview shows the correct changelog message text
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
Change app language, and verify that the changelog message is translated as expected
Create a thread under the changelog comment, and Verify that the thread report title displays the changelog message correctly

Screeenshot:

Recording:

5.mov

Test 6: Edit Workflow - Change Approver

Precondition: An existing non-default approval workflow exists.

Steps:

Navigate to Settings > Workspaces > [Your Workspace] > Workflows
Click on an existing non-default approval workflow
Click on the current approver
Select a different workspace member
Save the changes
Navigate to the #admins room
Open the system messages thread

Expected Results:

Message format: changed the approval workflow for [member_emails] to submit reports to [new_approver_email] (previously [old_approver_email])
The LHN sidebar preview shows the correct changelog message text
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
Change app language, and verify that the changelog message is translated as expected
Create a thread under the changelog comment, and Verify that the thread report title displays the changelog message correctly

Screeenshot:

Recording:

6.mov

Test 7: Edit Workflow - Add Additional Approver

Precondition: An existing approval workflow with only one approver.

Steps:

Navigate to the existing approval workflow
Click Additional approver
Select a second approver
Save the changes
Navigate to the #admins room
Open the system messages thread

Expected Results:

Message format: changed the approval workflow for [first_approver_email] to forward approved reports to [new_second_approver_email] (previously final approved reports)
The LHN sidebar preview shows the correct changelog message text
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
Change app language, and verify that the changelog message is translated as expected
Create a thread under the changelog comment, and Verify that the thread report title displays the changelog message correctly

Screeenshot:

Recording:

7.mov

Test 8: Edit Workflow - Remove Additional Approver

Precondition: An existing approval workflow with two or more approvers.

Steps:

Navigate to the existing approval workflow
Remove the additional approver(s), leaving only the first approver
Save the changes
Navigate to the #admins room
Open the system messages thread

Expected Results:

Message format: changed the approval workflow for [approver_email] to stop forwarding approved reports (previously forwarded to [old_forwardsTo_email])
The LHN sidebar preview shows the correct changelog message text
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
Change app language, and verify that the changelog message is translated as expected
Create a thread under the changelog comment, and Verify that the thread report title displays the changelog message correctly

Screeenshot:

Recording:

8.mov

Test 9: Edit Workflow - Change ForwardsTo Approver

Precondition: An existing approval workflow with two approvers.

Steps:

Navigate to the existing approval workflow
Click on the second approver
Select a different workspace member
Save the changes
Navigate to the #admins room
Open the system messages thread

Expected Results:

Message format: changed the approval workflow for [first_approver_email] to forward approved reports to [new_second_approver_email] (previously forwarded to [old_second_approver_email])
The LHN sidebar preview shows the correct changelog message text
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
Change app language, and verify that the changelog message is translated as expected
Create a thread under the changelog comment, and Verify that the thread report title displays the changelog message correctly

Screeenshot:

Recording:

9.mov

Test 10: Move Members Back to Default Approver

Precondition: An existing non-default approval workflow with members.

Steps:

Navigate to the existing approval workflow
Edit the workflow to remove all members (or delete the workflow)
Save the changes
Navigate to the #admins room
Open the system messages thread

Expected Results:

Message format: changed the approval workflow for [member_emails] to submit reports to the default approver [default_approver_email] (previously [old_approver_email])
The LHN sidebar preview shows the correct changelog message text
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
Change app language, and verify that the changelog message is translated as expected
Create a thread under the changelog comment, and Verify that the thread report title displays the changelog message correctly

Screeenshot:

Recording:

10.mov

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…actions

melvin-bot · 2025-11-27T22:29:43Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2025-11-27T22:38:14Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`85.84% <ø> (ø)`
src/libs/ReportUtils.ts	`73.37% <50.00%> (-0.04%)`	⬇️
src/libs/SidebarUtils.ts	`80.76% <50.00%> (-0.40%)`	⬇️
src/pages/home/report/PureReportActionItem.tsx	`52.10% <50.00%> (-0.02%)`	⬇️
...ges/home/report/ContextMenu/ContextMenuActions.tsx	`0.81% <0.00%> (-0.02%)`	⬇️
src/libs/ReportActionsUtils.ts	`48.98% <0.00%> (-1.30%)`	⬇️
... and 7 files with indirect coverage changes

melvin-bot · 2025-12-01T13:15:14Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify

Has @jamesdeanexpensify final approved the copy for these?

rayane-d · 2025-12-02T14:02:58Z

Has @jamesdeanexpensify final approved the copy for these?

Yes, Discussion is here

trjExpensify · 2025-12-03T00:33:52Z

Great, thanks for confirming!

rayane-d · 2025-12-05T17:17:22Z

Resolved merge conflicts

rayane-d · 2025-12-08T10:50:38Z

Resolved merge conflicts

eh2077 · 2025-12-08T12:52:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-10.at.10.41.17.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-12-10.at.10.43.08.PM.mov

iOS: HybridApp

Screen.Recording.2025-12-10.at.10.43.57.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-12-10.at.10.40.11.PM.mov

MacOS: Chrome / Safari

eh2077

Looks good overall, still doing tests and preparing recordings

rayane-d · 2025-12-09T23:50:19Z

Sign in to view

+    previousForwardsTo?: {email: string; name: string; accountID: number};
+};
+
+function formatMemberListWithAnd(members: Array<{email: string; name: string}>): string {


We're showing the email/phone number, just as we already do in the policy change log when inviting a member to the workspace

eh2077

Looks good

melvin-bot · 2025-12-10T14:47:37Z

🎯 @eh2077, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #77246.

OSBotify · 2025-12-11T11:59:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-12T22:27:41Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.2.78-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-16T22:24:36Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.78-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

rayane-d added 6 commits November 27, 2025 23:23

add approval workflows changelog report actions types

792ac1d

add message builders methods for approval workflows changelog report …

a37b664

…actions

handle approval workflows changelog report actions types

5de5bfc

implement copy logic for approval workflows changelog report actions

cefcdf1

add Spanish translation

91dbeee

add translations

47c3017

melvin-bot Bot assigned rayane-d Nov 27, 2025

rayane-d changed the title ~~Approval workflow changelogs~~ [Policy Change Logs] Implement policy change log for: Workflows - Adding or modifying workflows Nov 27, 2025

rayane-d commented Nov 28, 2025

View reviewed changes

Comment thread src/languages/es.ts

rayane-d marked this pull request as ready for review December 1, 2025 13:15

rayane-d requested review from a team as code owners December 1, 2025 13:15

melvin-bot Bot requested review from ahmedGaber93 and trjExpensify and removed request for a team December 1, 2025 13:15

melvin-bot Bot removed the request for review from a team December 1, 2025 13:15

rayane-d marked this pull request as draft December 1, 2025 13:15

rayane-d added 4 commits December 1, 2025 14:49

Merge branch 'main' into approval-workflow-changelogs

49da179

include default approver email in submit to messages

043faf1

Merge branch 'main' into approval-workflow-changelogs

be39741

update translations

082d84d

rayane-d changed the title ~~[Policy Change Logs] Implement policy change log for: Workflows - Adding or modifying workflows~~ [Hold Auth #18466] [Policy Change Logs] Implement policy change log for: Workflows - Adding or modifying workflows Dec 1, 2025

rayane-d requested a review from mjasikowski December 2, 2025 00:10

rayane-d changed the title ~~[Hold Auth #18466] [Policy Change Logs] Implement policy change log for: Workflows - Adding or modifying workflows~~ [Hold Auth#18466 Web#49633] [Policy Change Logs] Implement policy change log for: Workflows - Adding or modifying workflows Dec 2, 2025

trjExpensify reviewed Dec 2, 2025

View reviewed changes

update spanish translation

49c1f50

Merge branch 'Expensify:main' into approval-workflow-changelogs

734ce16

Merge branch 'Expensify:main' into approval-workflow-changelogs

9ec8cf3

rayane-d marked this pull request as ready for review December 3, 2025 01:37

rayane-d added 2 commits December 4, 2025 11:42

Ignore lint-changed deprecation errors

606f62e

Merge branch 'main' into approval-workflow-changelogs

89566f3

rayane-d changed the title ~~[Hold Auth#18466 Web#49633] [Policy Change Logs] Implement policy change log for: Workflows - Adding or modifying workflows~~ [Policy Change Logs] Implement policy change log for: Workflows - Adding or modifying workflows Dec 4, 2025

mjasikowski requested review from eh2077 and removed request for ahmedGaber93 December 5, 2025 10:30

Merge branch 'main' into approval-workflow-changelogs

b57639c

Merge branch 'main' into approval-workflow-changelogs

af5ddd4

Merge branch 'main' into approval-workflow-changelogs

4df0ad8

eh2077 reviewed Dec 9, 2025

View reviewed changes

Merge branch 'main' into approval-workflow-changelogs

25ca19c

eh2077 approved these changes Dec 10, 2025

View reviewed changes

melvin-bot Bot mentioned this pull request Dec 10, 2025

Payment issue for E/App PR#76260 #77246

Closed

rayane-d added 3 commits December 10, 2025 15:50

Merge branch 'Expensify:main' into approval-workflow-changelogs

e1cf9d8

fix lint-changed errors

18f8d88

Merge branch 'main' into approval-workflow-changelogs

b51e17d

mjasikowski approved these changes Dec 11, 2025

View reviewed changes

mjasikowski merged commit 7e199a6 into Expensify:main Dec 11, 2025
39 of 40 checks passed

rayane-d deleted the approval-workflow-changelogs branch December 11, 2025 14:41

OSBotify mentioned this pull request Dec 12, 2025

Deploy Checklist: New Expensify 2025-12-12 #77578

Closed

Uh oh!

Conversation

rayane-d commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Prerequisites

Test Cases

Test 1: Change Default Approver

Test 2: Create New Approval Workflow - Single Member

Test 3: Create New Approval Workflow - Two Members

Test 4: Create New Approval Workflow - Three or More Members

Test 5: Create Multi-Level Approval Workflow (forwardsTo)

Test 6: Edit Workflow - Change Approver

Test 7: Edit Workflow - Add Additional Approver

Test 8: Edit Workflow - Remove Additional Approver

Test 9: Edit Workflow - Change ForwardsTo Approver

Test 10: Move Members Back to Default Approver

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 27, 2025

Uh oh!

codecov Bot commented Nov 27, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

melvin-bot Bot commented Dec 1, 2025

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

rayane-d commented Dec 2, 2025

Uh oh!

trjExpensify commented Dec 3, 2025

Uh oh!

rayane-d commented Dec 5, 2025

Uh oh!

rayane-d commented Dec 8, 2025

Uh oh!

eh2077 commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

rayane-d Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Dec 10, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 11, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

OSBotify commented Dec 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rayane-d commented Nov 27, 2025 •

edited

Loading

codecov Bot commented Nov 27, 2025 •

edited by github-actions Bot

Loading

eh2077 commented Dec 8, 2025 •

edited

Loading