Skip to content

[No QA] Upgrade react-native-safe-area-context to latest#76247

Merged
mountiny merged 3 commits into
Expensify:mainfrom
zainAwan9175:upgrade/safe-area-context
Dec 11, 2025
Merged

[No QA] Upgrade react-native-safe-area-context to latest#76247
mountiny merged 3 commits into
Expensify:mainfrom
zainAwan9175:upgrade/safe-area-context

Conversation

@zainAwan9175

@zainAwan9175 zainAwan9175 commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

Explanation of Change

Upgraded react-native-safe-area-context to the latest version.
This resolves the dependency conflict flagged by align-deps, enabling the React Native upgrade to proceed without blocking.

Note: Podfile.lock has been committed to ensure proper iOS dependency management.

Fixed Issues

$ #75701
PROPOSAL: #75701 (comment)

Tests

  1. Installed updated dependency and rebuilt the project.
  2. Verified the app starts with no build errors.
  3. Navigated between screens using safe-area context.
  4. Verified UI elements render correctly and safe areas behave as expected.
  5. Checked that no errors appear in the JS console.
  • Verify that no errors appear in the JS console

Offline tests

  1. Disabled network connection.
  2. Verified app loads without crashing.
  3. Confirmed default offline UI behavior works as expected.

QA Steps

Same as Tests above.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline tests section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e., verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline
  • I tested this PR with a High Traffic account
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors
  • I verified there are no new alerts related to canBeMissing param for useOnyx
  • I followed proper code patterns
  • I verified callback names follow naming conventions
  • I added comments to non-self-explanatory code
  • I verified comments are clear and correct
  • I verified all copy/text is localized
  • I verified translations follow guidelines
  • I verified all numbers/dates/amounts use localization methods
  • I verified new text is grammatically correct
  • I followed file naming conventions
  • I verified JSDocs guidelines were followed
  • Confirmed new code patterns were approved (if applicable)
  • I followed all Review Guidelines
  • I tested components impacted by this change
  • I verified all code is DRY
  • I verified constants are defined correctly
  • I verified all function usage updates if their arguments changed
  • I verified new file headers are added (if applicable)
  • For any new CSS styles:
    • Verified similar style does not exist
    • Verified StyleUtils couldn't replace it
  • If new assets were modified/added:
    • Compressed SVGs
    • Verified cross-platform loading
  • If message-editing/sending code was affected, verified markdown behavior
  • Tested components with Storybook (if related)
  • Verified deep-link behavior (logged in + logged out)
  • If UI changed:
    • Verified form inputs are aligned
    • Added Design label or tagged @Expensify/design
  • If a new page is added: verified ScrollView usage
  • Added unit tests where required
  • Retested after merging main into PR if applicable

Screenshots/Videos

Android: Native

Android Native

Android: mWeb Chrome

Android mWeb

iOS: Native

iOS Native

iOS: mWeb Safari

iOS mWeb

MacOS: Chrome / Safari

MacOS

@zainAwan9175 zainAwan9175 requested a review from a team as a code owner November 27, 2025 15:26
@melvin-bot melvin-bot Bot requested review from aimane-chnaif and removed request for a team November 27, 2025 15:26
@melvin-bot

melvin-bot Bot commented Nov 27, 2025

Copy link
Copy Markdown

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@github-actions

github-actions Bot commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@aimane-chnaif aimane-chnaif left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Screenshots are missing on all platforms. You should verify that app is working as normal.
  • Please add [No QA] in PR title.
  • Many items are missing in PR Author Checklist.
  • Please sign by following #76247 (comment)
  • Podfile.lock should be commited as well

Comment thread package.json Outdated
@zainAwan9175 zainAwan9175 changed the title Upgrade react-native-safe-area-context to latest [No QA] Upgrade react-native-safe-area-context to latest Nov 28, 2025
@zainAwan9175

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@zainAwan9175

Copy link
Copy Markdown
Contributor Author

recheck

CLABotify added a commit to Expensify/CLA that referenced this pull request Nov 29, 2025
@aimane-chnaif

aimane-chnaif commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android.mov
Android: mWeb Chrome
mchrome.mov
iOS: HybridApp
ios.mov
iOS: mWeb Safari
msafari.mov
MacOS: Chrome / Safari
web.mov

@melvin-bot melvin-bot Bot requested a review from mountiny December 1, 2025 14:53

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aimane-chnaif this dependency is not in the OldDot right @aimane-chnaif ?so we do not need to make a change there?

@aimane-chnaif

Copy link
Copy Markdown
Contributor

We should update OD podfile.lock too

@mountiny

mountiny commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

@aimane-chnaif Since the contributor does not have access to that, could you raise the PR please and tag me?

@codecov

codecov Bot commented Dec 1, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 8 files with indirect coverage changes

@mountiny

mountiny commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

@zainAwan9175 could you please merge main to fix the jest?

@aimane-chnaif

Copy link
Copy Markdown
Contributor

Not sure what you did but why merging main involves too many other commits?

@zainAwan9175

Copy link
Copy Markdown
Contributor Author

Not sure what you did but why merging main involves too many other commits?

Hi @aimane-chnaif,

Thanks for pointing this out. I believe the reason for the additional commits appearing in this PR is that my fork was outdated. The upgrade/safe-area-context branch was created from that old fork, which didn’t have the latest history from the upstream main. As a result, when merging main into my branch, all the previous commits from upstream got included in this PR.

@mountiny

mountiny commented Dec 6, 2025

Copy link
Copy Markdown
Contributor

@zainAwan9175 can you please fix that and force push in with less commits?

@zainAwan9175 zainAwan9175 force-pushed the upgrade/safe-area-context branch from d9bf02a to e55bc85 Compare December 7, 2025 18:32
@melvin-bot melvin-bot Bot requested a review from mountiny December 8, 2025 06:02
@mountiny mountiny merged commit b465b79 into Expensify:main Dec 11, 2025
38 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.78-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.78-8 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants