[No QA] Upgrade react-native-safe-area-context to latest#76247
Conversation
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
|
All contributors have signed the CLA ✍️ ✅ |
aimane-chnaif
left a comment
There was a problem hiding this comment.
- Screenshots are missing on all platforms. You should verify that app is working as normal.
- Please add [No QA] in PR title.
- Many items are missing in PR Author Checklist.
- Please sign by following #76247 (comment)
- Podfile.lock should be commited as well
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb Chromemchrome.moviOS: HybridAppios.moviOS: mWeb Safarimsafari.movMacOS: Chrome / Safariweb.mov |
mountiny
left a comment
There was a problem hiding this comment.
@aimane-chnaif this dependency is not in the OldDot right @aimane-chnaif ?so we do not need to make a change there?
|
We should update OD podfile.lock too |
|
@aimane-chnaif Since the contributor does not have access to that, could you raise the PR please and tag me? |
Codecov Report✅ All modified and coverable lines are covered by tests. |
|
@zainAwan9175 could you please merge main to fix the jest? |
|
Not sure what you did but why merging main involves too many other commits? |
Hi @aimane-chnaif, Thanks for pointing this out. I believe the reason for the additional commits appearing in this PR is that my fork was outdated. The |
|
@zainAwan9175 can you please fix that and force push in with less commits? |
d9bf02a to
e55bc85
Compare
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.78-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.78-8 🚀
|
Explanation of Change
Upgraded
react-native-safe-area-contextto the latest version.This resolves the dependency conflict flagged by
align-deps, enabling the React Native upgrade to proceed without blocking.Note:
Podfile.lockhas been committed to ensure proper iOS dependency management.Fixed Issues
$ #75701
PROPOSAL: #75701 (comment)
Tests
Offline tests
QA Steps
Same as Tests above.
PR Author Checklist
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari