Skip to content

[NoQA] Revert "fix: adapt elf workflow to remote rock build"#75742

Merged
mountiny merged 1 commit into
mainfrom
revert-75341-kureev/fix-elf-ci-workflow
Nov 21, 2025
Merged

[NoQA] Revert "fix: adapt elf workflow to remote rock build"#75742
mountiny merged 1 commit into
mainfrom
revert-75341-kureev/fix-elf-ci-workflow

Conversation

@mountiny

Copy link
Copy Markdown
Contributor

Reverts #75341

Straight revert

There was some confusion on this one and it broke the rock builds https://expensify.slack.com/archives/C01GTK53T8Q/p1763650909890079 for android, the tests on the original pr were not completed successfully

@mountiny mountiny requested a review from a team as a code owner November 21, 2025 14:10
@melvin-bot melvin-bot Bot requested a review from carlosmiceli November 21, 2025 14:11
@melvin-bot

melvin-bot Bot commented Nov 21, 2025

Copy link
Copy Markdown

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team November 21, 2025 14:11

@NikkiWines NikkiWines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mountiny mountiny merged commit a290b1a into main Nov 21, 2025
12 of 15 checks passed
@mountiny mountiny deleted the revert-75341-kureev/fix-elf-ci-workflow branch November 21, 2025 14:17
@melvin-bot melvin-bot Bot added the Emergency label Nov 21, 2025
@melvin-bot

melvin-bot Bot commented Nov 21, 2025

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny

Copy link
Copy Markdown
Contributor Author

Straight revert

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.63-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.63-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants