Skip to content

Delay navigation to confirmation page after participant select #75726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arosiclair merged 4 commits into from
Nov 24, 2025
Merged

Delay navigation to confirmation page after participant select #75726

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a65bfc
fix:73728: delay navigation to next page after participants to let On…
Eskalifer1 Nov 21, 2025
58a4ee3
fix:73728: same fix for selfDM
Eskalifer1 Nov 21, 2025
5cec5c6
chore: added comments
Eskalifer1 Nov 21, 2025
18e2e53
chore: C+ comment
Eskalifer1 Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/pages/iou/request/step/IOURequestStepParticipants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,11 @@ function IOURequestStepParticipants({
// We don't want to compare params because we just changed the participants.
Navigation.goBack(iouConfirmationPageRoute, {compareParams: false});
} else {
Navigation.navigate(iouConfirmationPageRoute);
// We wrap navigation in setNavigationActionToMicrotaskQueue so that data loading in Onyx and navigation do not occur simultaneously, which resets the amount to 0.
// More information can be found here: https://github.com/Expensify/App/issues/73728
Navigation.setNavigationActionToMicrotaskQueue(() => {
Comment thread
Eskalifer1 marked this conversation as resolved.
Navigation.navigate(iouConfirmationPageRoute);
});
}
});
}, [selfDMReportID, transactions, action, initialTransactionID, waitForKeyboardDismiss, iouType, selfDMReport, isActivePolicyRequest, backTo]);
Expand Down Expand Up @@ -355,7 +359,11 @@ function IOURequestStepParticipants({
// We don't want to compare params because we just changed the participants.
Navigation.goBack(route, {compareParams: false});
} else {
Navigation.navigate(route);
// We wrap navigation in setNavigationActionToMicrotaskQueue so that data loading in Onyx and navigation do not occur simultaneously, which resets the amount to 0.
// More information can be found here: https://github.com/Expensify/App/issues/73728
Navigation.setNavigationActionToMicrotaskQueue(() => {
Navigation.navigate(route);
Comment thread
arosiclair marked this conversation as resolved.
});
}
});
}, [action, participants, iouType, initialTransaction, transactions, initialTransactionID, reportID, waitForKeyboardDismiss, isMovingTransactionFromTrackExpense, backTo, introSelected]);
Expand Down
Loading