Skip to content

Fix empty per diem view is shown briefly after clear cache #75716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosmiceli merged 1 commit into from
Nov 22, 2025
Merged

Fix empty per diem view is shown briefly after clear cache #75716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pages/iou/request/step/IOURequestStepDestination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import Button from '@components/Button';
import DestinationPicker from '@components/DestinationPicker';
import FixedFooter from '@components/FixedFooter';
import * as Illustrations from '@components/Icon/Illustrations';

Check warning on line 8 in src/pages/iou/request/step/IOURequestStepDestination.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

'@components/Icon/Illustrations' import is restricted from being used by a pattern. Direct imports from Icon/Illustrations are deprecated. Please use lazy loading hooks instead. Use `useMemoizedLazyIllustrations` from @hooks/useLazyAsset. See docs/LAZY_ICONS_AND_ILLUSTRATIONS.md for details

Check warning on line 8 in src/pages/iou/request/step/IOURequestStepDestination.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

'@components/Icon/Illustrations' import is restricted from being used. Direct imports from @components/Icon/Illustrations are deprecated. Please use lazy loading hooks instead. Use `useMemoizedLazyIllustrations` from @hooks/useLazyAsset. See docs/LAZY_ICONS_AND_ILLUSTRATIONS.md for details
import ScreenWrapper from '@components/ScreenWrapper';
import type {ListItem} from '@components/SelectionListWithSections/types';
import WorkspaceEmptyStateSection from '@components/WorkspaceEmptyStateSection';
Expand Down Expand Up @@ -73,8 +73,8 @@
const shouldShowNotFoundPage = isEmptyObject(policy);

const {isOffline} = useNetwork();
const isLoading = !isOffline && isLoadingOnyxValue(policyMetadata);
const shouldShowEmptyState = isEmptyObject(customUnit?.rates) && !isOffline;
const isLoading = !isOffline && (!customUnit?.rates || isLoadingOnyxValue(policyMetadata));
const shouldShowEmptyState = isEmptyObject(customUnit?.rates) && !isOffline && !isLoading;
const shouldShowOfflineView = isEmptyObject(customUnit?.rates) && isOffline;

const navigateBack = () => {
Expand Down
Loading