fix: hide qa guide from workspace invite list#75345
Conversation
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Failing check no related to this PR. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-11-18.at.12.26.40.movAndroid: mWeb ChromeScreen.Recording.2025-11-18.at.12.27.31.moviOS: HybridAppScreen.Recording.2025-11-18.at.12.23.33.moviOS: mWeb SafariScreen.Recording.2025-11-18.at.12.24.37.movMacOS: Chrome / SafariScreen.Recording.2025-11-18.at.11.30.11.movMacOS: DesktopScreen.Recording.2025-11-18.at.12.21.37.mov |
This step is unclear. I think we should update to |
Could you please merge main as well?, the issue resolved on main |
heyjennahay
left a comment
There was a problem hiding this comment.
No concern with product change
| STUDENT_AMBASSADOR: Number(Config?.EXPENSIFY_ACCOUNT_ID_STUDENT_AMBASSADOR ?? 10476956), | ||
| SVFG: Number(Config?.EXPENSIFY_ACCOUNT_ID_SVFG ?? 2012843), | ||
| MANAGER_MCTEST: Number(Config?.EXPENSIFY_ACCOUNT_ID_MANAGER_MCTEST ?? 18964612), | ||
| QA_GUIDE: Number(Config?.EXPENSIFY_ACCOUNT_ID_QA_GUIDE ?? 14365522), |
There was a problem hiding this comment.
Ah where are we getting this ID?
There was a problem hiding this comment.
@marcochavezf Get this from availableOptions.personalDetails before adding QA in EXPENSIFY_EMAILS
|
@marcochavezf friendly bump. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.2.63-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.63-8 🚀
|
Explanation of Change
Fixed Issues
$ #74202
PROPOSAL: #74202 (comment)
Tests
isagoicotest@tstsg.comOffline tests
QA Steps
Same as test
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android.Native.mov
Android: mWeb Chrome
Android.mWeb.chrome.mp4
iOS: Native
Build issue
iOS: mWeb Safari
IOS.mWeb.safari.mp4
MacOS: Chrome / Safari
macOS.chrome.mp4
MacOS: Desktop
Desktop.mp4