Skip to content

fix(eslint): auto-fix unicorn/no-array-foreach rule violations #75282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 2 commits into from
Nov 17, 2025
Merged

fix(eslint): auto-fix unicorn/no-array-foreach rule violations #75282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6abc35a
fix(eslint): auto-fix unicorn/no-array-foreach rule violations
gelocraft Nov 17, 2025
420cf43
ci: run gh-actions-build
gelocraft Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/actions/javascript/authorChecklist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15890,43 +15890,43 @@ class GithubUtils {
// PR list
if (sortedPRList.length > 0) {
issueBody += '**This release contains changes from the following pull requests:**\r\n';
sortedPRList.forEach((URL) => {
for (const URL of sortedPRList) {
issueBody += verifiedOrNoQAPRs.has(URL) ? '- [x]' : '- [ ]';
issueBody += ` ${URL}\r\n`;
});
}
issueBody += '\r\n\r\n';
}
// Mobile-Expensify PR list
if (sortedPRListMobileExpensify.length > 0) {
issueBody += '**Mobile-Expensify PRs:**\r\n';
sortedPRListMobileExpensify.forEach((URL) => {
for (const URL of sortedPRListMobileExpensify) {
issueBody += verifiedOrNoQAPRs.has(URL) ? '- [x]' : '- [ ]';
issueBody += ` ${URL}\r\n`;
});
}
issueBody += '\r\n\r\n';
}
// Internal QA PR list
if (!(0, isEmptyObject_1.isEmptyObject)(internalQAPRMap)) {
console.log('Found the following verified Internal QA PRs:', resolvedInternalQAPRs);
issueBody += '**Internal QA:**\r\n';
Object.keys(internalQAPRMap).forEach((URL) => {
for (const URL of Object.keys(internalQAPRMap)) {
const merger = internalQAPRMap[URL];
const mergerMention = `@${merger}`;
issueBody += `${resolvedInternalQAPRs.includes(URL) ? '- [x]' : '- [ ]'} `;
issueBody += `${URL}`;
issueBody += ` - ${mergerMention}`;
issueBody += '\r\n';
});
}
issueBody += '\r\n\r\n';
}
// Deploy blockers
if (deployBlockers.length > 0) {
issueBody += '**Deploy Blockers:**\r\n';
sortedDeployBlockers.forEach((URL) => {
for (const URL of sortedDeployBlockers) {
issueBody += resolvedDeployBlockers.includes(URL) ? '- [x] ' : '- [ ] ';
issueBody += URL;
issueBody += '\r\n';
});
}
issueBody += '\r\n\r\n';
}
issueBody += '**Deployer verifications:**';
Expand Down
16 changes: 8 additions & 8 deletions .github/actions/javascript/awaitStagingDeploys/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12694,43 +12694,43 @@ class GithubUtils {
// PR list
if (sortedPRList.length > 0) {
issueBody += '**This release contains changes from the following pull requests:**\r\n';
sortedPRList.forEach((URL) => {
for (const URL of sortedPRList) {
issueBody += verifiedOrNoQAPRs.has(URL) ? '- [x]' : '- [ ]';
issueBody += ` ${URL}\r\n`;
});
}
issueBody += '\r\n\r\n';
}
// Mobile-Expensify PR list
if (sortedPRListMobileExpensify.length > 0) {
issueBody += '**Mobile-Expensify PRs:**\r\n';
sortedPRListMobileExpensify.forEach((URL) => {
for (const URL of sortedPRListMobileExpensify) {
issueBody += verifiedOrNoQAPRs.has(URL) ? '- [x]' : '- [ ]';
issueBody += ` ${URL}\r\n`;
});
}
issueBody += '\r\n\r\n';
}
// Internal QA PR list
if (!(0, isEmptyObject_1.isEmptyObject)(internalQAPRMap)) {
console.log('Found the following verified Internal QA PRs:', resolvedInternalQAPRs);
issueBody += '**Internal QA:**\r\n';
Object.keys(internalQAPRMap).forEach((URL) => {
for (const URL of Object.keys(internalQAPRMap)) {
const merger = internalQAPRMap[URL];
const mergerMention = `@${merger}`;
issueBody += `${resolvedInternalQAPRs.includes(URL) ? '- [x]' : '- [ ]'} `;
issueBody += `${URL}`;
issueBody += ` - ${mergerMention}`;
issueBody += '\r\n';
});
}
issueBody += '\r\n\r\n';
}
// Deploy blockers
if (deployBlockers.length > 0) {
issueBody += '**Deploy Blockers:**\r\n';
sortedDeployBlockers.forEach((URL) => {
for (const URL of sortedDeployBlockers) {
issueBody += resolvedDeployBlockers.includes(URL) ? '- [x] ' : '- [ ] ';
issueBody += URL;
issueBody += '\r\n';
});
}
issueBody += '\r\n\r\n';
}
issueBody += '**Deployer verifications:**';
Expand Down
16 changes: 8 additions & 8 deletions .github/actions/javascript/checkAndroidStatus/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737437,43 +737437,43 @@ class GithubUtils {
// PR list
if (sortedPRList.length > 0) {
issueBody += '**This release contains changes from the following pull requests:**\r\n';
sortedPRList.forEach((URL) => {
for (const URL of sortedPRList) {
issueBody += verifiedOrNoQAPRs.has(URL) ? '- [x]' : '- [ ]';
issueBody += ` ${URL}\r\n`;
});
}
issueBody += '\r\n\r\n';
}
// Mobile-Expensify PR list
if (sortedPRListMobileExpensify.length > 0) {
issueBody += '**Mobile-Expensify PRs:**\r\n';
sortedPRListMobileExpensify.forEach((URL) => {
for (const URL of sortedPRListMobileExpensify) {
issueBody += verifiedOrNoQAPRs.has(URL) ? '- [x]' : '- [ ]';
issueBody += ` ${URL}\r\n`;
});
}
issueBody += '\r\n\r\n';
}
// Internal QA PR list
if (!(0, isEmptyObject_1.isEmptyObject)(internalQAPRMap)) {
console.log('Found the following verified Internal QA PRs:', resolvedInternalQAPRs);
issueBody += '**Internal QA:**\r\n';
Object.keys(internalQAPRMap).forEach((URL) => {
for (const URL of Object.keys(internalQAPRMap)) {
const merger = internalQAPRMap[URL];
const mergerMention = `@${merger}`;
issueBody += `${resolvedInternalQAPRs.includes(URL) ? '- [x]' : '- [ ]'} `;
issueBody += `${URL}`;
issueBody += ` - ${mergerMention}`;
issueBody += '\r\n';
});
}
issueBody += '\r\n\r\n';
}
// Deploy blockers
if (deployBlockers.length > 0) {
issueBody += '**Deploy Blockers:**\r\n';
sortedDeployBlockers.forEach((URL) => {
for (const URL of sortedDeployBlockers) {
issueBody += resolvedDeployBlockers.includes(URL) ? '- [x] ' : '- [ ] ';
issueBody += URL;
issueBody += '\r\n';
});
}
issueBody += '\r\n\r\n';
}
issueBody += '**Deployer verifications:**';
Expand Down
16 changes: 8 additions & 8 deletions .github/actions/javascript/checkDeployBlockers/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11961,43 +11961,43 @@ class GithubUtils {
// PR list
if (sortedPRList.length > 0) {
issueBody += '**This release contains changes from the following pull requests:**\r\n';
sortedPRList.forEach((URL) => {
for (const URL of sortedPRList) {
issueBody += verifiedOrNoQAPRs.has(URL) ? '- [x]' : '- [ ]';
issueBody += ` ${URL}\r\n`;
});
}
issueBody += '\r\n\r\n';
}
// Mobile-Expensify PR list
if (sortedPRListMobileExpensify.length > 0) {
issueBody += '**Mobile-Expensify PRs:**\r\n';
sortedPRListMobileExpensify.forEach((URL) => {
for (const URL of sortedPRListMobileExpensify) {
issueBody += verifiedOrNoQAPRs.has(URL) ? '- [x]' : '- [ ]';
issueBody += ` ${URL}\r\n`;
});
}
issueBody += '\r\n\r\n';
}
// Internal QA PR list
if (!(0, isEmptyObject_1.isEmptyObject)(internalQAPRMap)) {
console.log('Found the following verified Internal QA PRs:', resolvedInternalQAPRs);
issueBody += '**Internal QA:**\r\n';
Object.keys(internalQAPRMap).forEach((URL) => {
for (const URL of Object.keys(internalQAPRMap)) {
const merger = internalQAPRMap[URL];
const mergerMention = `@${merger}`;
issueBody += `${resolvedInternalQAPRs.includes(URL) ? '- [x]' : '- [ ]'} `;
issueBody += `${URL}`;
issueBody += ` - ${mergerMention}`;
issueBody += '\r\n';
});
}
issueBody += '\r\n\r\n';
}
// Deploy blockers
if (deployBlockers.length > 0) {
issueBody += '**Deploy Blockers:**\r\n';
sortedDeployBlockers.forEach((URL) => {
for (const URL of sortedDeployBlockers) {
issueBody += resolvedDeployBlockers.includes(URL) ? '- [x] ' : '- [ ] ';
issueBody += URL;
issueBody += '\r\n';
});
}
issueBody += '\r\n\r\n';
}
issueBody += '**Deployer verifications:**';
Expand Down
34 changes: 18 additions & 16 deletions .github/actions/javascript/checkSVGCompression/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20486,43 +20486,43 @@ class GithubUtils {
// PR list
if (sortedPRList.length > 0) {
issueBody += '**This release contains changes from the following pull requests:**\r\n';
sortedPRList.forEach((URL) => {
for (const URL of sortedPRList) {
issueBody += verifiedOrNoQAPRs.has(URL) ? '- [x]' : '- [ ]';
issueBody += ` ${URL}\r\n`;
});
}
issueBody += '\r\n\r\n';
}
// Mobile-Expensify PR list
if (sortedPRListMobileExpensify.length > 0) {
issueBody += '**Mobile-Expensify PRs:**\r\n';
sortedPRListMobileExpensify.forEach((URL) => {
for (const URL of sortedPRListMobileExpensify) {
issueBody += verifiedOrNoQAPRs.has(URL) ? '- [x]' : '- [ ]';
issueBody += ` ${URL}\r\n`;
});
}
issueBody += '\r\n\r\n';
}
// Internal QA PR list
if (!(0, isEmptyObject_1.isEmptyObject)(internalQAPRMap)) {
console.log('Found the following verified Internal QA PRs:', resolvedInternalQAPRs);
issueBody += '**Internal QA:**\r\n';
Object.keys(internalQAPRMap).forEach((URL) => {
for (const URL of Object.keys(internalQAPRMap)) {
const merger = internalQAPRMap[URL];
const mergerMention = `@${merger}`;
issueBody += `${resolvedInternalQAPRs.includes(URL) ? '- [x]' : '- [ ]'} `;
issueBody += `${URL}`;
issueBody += ` - ${mergerMention}`;
issueBody += '\r\n';
});
}
issueBody += '\r\n\r\n';
}
// Deploy blockers
if (deployBlockers.length > 0) {
issueBody += '**Deploy Blockers:**\r\n';
sortedDeployBlockers.forEach((URL) => {
for (const URL of sortedDeployBlockers) {
issueBody += resolvedDeployBlockers.includes(URL) ? '- [x] ' : '- [ ] ';
issueBody += URL;
issueBody += '\r\n';
});
}
issueBody += '\r\n\r\n';
}
issueBody += '**Deployer verifications:**';
Expand Down Expand Up @@ -21042,7 +21042,9 @@ function validateSvgFiles(filePaths) {
}
if (errors.length) {
console.error('Validation errors:');
errors.forEach((error) => console.error(` ${error}`));
for (const error of errors) {
console.error(` ${error}`);
}
throw new Error('SVG file validation failed');
}
return validFiles;
Expand Down Expand Up @@ -21073,19 +21075,19 @@ function logIgnoredFiles(ignoredFiles) {
return;
}
console.log('\nFiles skipped (ignore-compression):');
ignoredFiles.forEach((filePath) => {
for (const filePath of ignoredFiles) {
console.log(`${filePath}: ⏭️ Skipped`);
});
}
}
function logSummary(summary) {
const { totalFiles, totalCompressedFilesLength, totalOriginalSize, totalCompressedSize, totalSavings, totalSavingsPercent, results, ignoredFiles } = summary;
logIgnoredFiles(ignoredFiles);
if (totalCompressedFilesLength) {
console.log('\nFiles compressed:');
results.forEach((result) => {
for (const result of results) {
const { compressedSize, originalSize, savings, savingsPercent, filePath } = result;
if (!result.savings) {
return;
continue;
}
const prefix = `${filePath}: ✅`;
console.log(getSummarySavingString({
Expand All @@ -21095,7 +21097,7 @@ function logSummary(summary) {
savings,
savingsPercent,
}));
});
}
const ignoreFilesLength = ignoredFiles.length;
console.log(`\nFiles processed: ${totalFiles}`);
console.log(`Files already properly compressed: ${totalFiles - ignoreFilesLength - totalCompressedFilesLength}`);
Expand All @@ -21116,10 +21118,10 @@ function logSummary(summary) {
function logSummaryCheck(summary) {
const { totalFiles, totalCompressedFilesLength, results, ignoredFiles } = summary;
console.log('');
results.forEach((result) => {
for (const result of results) {
const { filePath, savings } = result;
console.log(`${filePath}: ${savings > 0 ? 'Not properly compressed ❌' : 'Compressed ✅'}`);
});
}
logIgnoredFiles(ignoredFiles);
console.log(`\nFiles processed: ${totalFiles}`);
console.log(`Files ignored: ${ignoredFiles.length}`);
Expand Down
26 changes: 13 additions & 13 deletions .github/actions/javascript/createOrUpdateStagingDeploy/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11921,25 +11921,25 @@ function getPreviousExistingTag(tag, level) {
*/
function getValidMergedPRs(commits) {
const mergedPRs = new Set();
commits.forEach((commit) => {
for (const commit of commits) {
const author = commit.authorName;
if (author === CONST_1.default.OS_BOTIFY) {
return;
continue;
}
// Retrieve the PR number from the commit subject,
const match = commit.subject.match(/Merge pull request #(\d+) from (?!Expensify\/.*-cherry-pick-(staging|production))/);
if (!Array.isArray(match) || match.length < 2) {
return;
continue;
}
const pr = Number.parseInt(match[1], 10);
if (mergedPRs.has(pr)) {
// If a PR shows up in the log twice, that means that the PR was deployed in the previous checklist.
// That also means that we don't want to include it in the current checklist, so we remove it now.
mergedPRs.delete(pr);
return;
continue;
}
mergedPRs.add(pr);
});
}
return Array.from(mergedPRs);
}
/**
Expand Down Expand Up @@ -12248,43 +12248,43 @@ class GithubUtils {
// PR list
if (sortedPRList.length > 0) {
issueBody += '**This release contains changes from the following pull requests:**\r\n';
sortedPRList.forEach((URL) => {
for (const URL of sortedPRList) {
issueBody += verifiedOrNoQAPRs.has(URL) ? '- [x]' : '- [ ]';
issueBody += ` ${URL}\r\n`;
});
}
issueBody += '\r\n\r\n';
}
// Mobile-Expensify PR list
if (sortedPRListMobileExpensify.length > 0) {
issueBody += '**Mobile-Expensify PRs:**\r\n';
sortedPRListMobileExpensify.forEach((URL) => {
for (const URL of sortedPRListMobileExpensify) {
issueBody += verifiedOrNoQAPRs.has(URL) ? '- [x]' : '- [ ]';
issueBody += ` ${URL}\r\n`;
});
}
issueBody += '\r\n\r\n';
}
// Internal QA PR list
if (!(0, isEmptyObject_1.isEmptyObject)(internalQAPRMap)) {
console.log('Found the following verified Internal QA PRs:', resolvedInternalQAPRs);
issueBody += '**Internal QA:**\r\n';
Object.keys(internalQAPRMap).forEach((URL) => {
for (const URL of Object.keys(internalQAPRMap)) {
const merger = internalQAPRMap[URL];
const mergerMention = `@${merger}`;
issueBody += `${resolvedInternalQAPRs.includes(URL) ? '- [x]' : '- [ ]'} `;
issueBody += `${URL}`;
issueBody += ` - ${mergerMention}`;
issueBody += '\r\n';
});
}
issueBody += '\r\n\r\n';
}
// Deploy blockers
if (deployBlockers.length > 0) {
issueBody += '**Deploy Blockers:**\r\n';
sortedDeployBlockers.forEach((URL) => {
for (const URL of sortedDeployBlockers) {
issueBody += resolvedDeployBlockers.includes(URL) ? '- [x] ' : '- [ ] ';
issueBody += URL;
issueBody += '\r\n';
});
}
issueBody += '\r\n\r\n';
}
issueBody += '**Deployer verifications:**';
Expand Down
Loading
Loading