[No QA] Update report state names in HelpDot by kadiealexander · Pull Request #75273 · Expensify/App

kadiealexander · 2025-11-17T00:23:12Z

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/550502
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-11-17T00:23:23Z

melvin-bot · 2025-11-17T00:23:25Z

@CortneyOfstad Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-11-17T00:25:11Z

HelpDot Documentation Review

Overall Assessment

This PR updates report state terminology from "processing state" to "outstanding state" in Expensify Classic documentation. This is a positive change that aligns with the official terminology used elsewhere in the help documentation. However, the update is incomplete - only one of two instances was updated.

Scores Summary

Readability: 9/10 - The updated text is clear and maintains good readability. The term "outstanding state" is accurately descriptive of a submitted report awaiting approval.
AI Readiness: 8/10 - The terminology is now consistent with the official Expensify Classic report state naming convention, improving AI comprehension. However, the incomplete update creates a terminology inconsistency issue.
Style Compliance: 9/10 - The change properly uses bold formatting for the state name and maintains the existing article structure and tone.

Key Findings

Positive Aspects:

Correct terminology alignment with official Expensify Classic report states (as documented in Edit-and-Submit-Expense-Reports.md)
Maintains proper bold formatting for emphasis on the state name
No changes to sentence structure, keeping the explanation clear

Critical Issue:

INCOMPLETE UPDATE: The term "processing state" still appears in docs/articles/expensify-classic/workspaces/Remove-Members.md at line 37. This creates a terminology inconsistency across the documentation.
- Found: "If a member is a Preferred Exporter, Billing Owner, Report Approver, or has submitted reports in the processing state, follow these steps before removing them:"
- Should be: "...has submitted reports in the outstanding state..."

Context Verification:
According to docs/articles/expensify-classic/reports/Edit-and-Submit-Expense-Reports.md (lines 313-315), the official mapping is:

Old terminology: "Processing" → New terminology: "Outstanding"
This confirms the change is correct and should be applied consistently

Recommendations

MUST FIX: Update the remaining instance in Remove-Members.md (line 37) to use "outstanding state" for complete consistency
Consider adding this to the redirects or creating a documentation style guide entry to prevent future uses of deprecated terminology
After fixing the remaining instance, verify no other report state terminology inconsistencies exist (e.g., "Open" vs "Draft", etc.)

Files Reviewed

✅ docs/articles/expensify-classic/reports/Assign-report-approvers-to-specific-employees.md - Updated correctly
⚠️ docs/articles/expensify-classic/workspaces/Remove-Members.md - Needs update (not included in this PR)

Overall Score: 8.7/10

The change is technically correct and improves documentation accuracy, but the incomplete application prevents this from being a complete solution. Once the remaining instance is updated, this will be a solid documentation improvement.

OSBotify · 2025-11-17T00:27:06Z

A preview of your ExpensifyHelp changes have been deployed to https://3266cbab.helpdot.pages.dev ⚡️

Updated articles:

kadiealexander · 2025-11-19T05:44:09Z

@CortneyOfstad bump on this as the feature goes live tomorrow!

RachCHopkins · 2025-11-24T03:12:39Z

 1. Filter the expenses to display only Unreported or Deleted expenses.
 2. Select all relevant expenses and click **Add to a Report** > **Auto Report**.
-3. If an open report exists in the cardholder’s account, the expenses will be added to it. Otherwise, a new report will be created.
+3. If an draft report exists in the cardholder’s account, the expenses will be added to it. Otherwise, a new report will be created.


Needs correction - A draft report, not AN draft report.

RachCHopkins

LGTM!

melvin-bot · 2025-11-24T03:27:50Z

@RachCHopkins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

kadiealexander · 2025-11-24T03:37:06Z

Not an emergency, Rach didn't do the checklist.

RachCHopkins · 2025-11-24T03:38:15Z

Done now!

OSBotify · 2025-11-24T20:24:03Z

🚀 Deployed to staging by https://github.com/RachCHopkins in version: 9.2.63-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-26T01:22:29Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.63-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Update report state names in HelpDot

e467a36

kadiealexander requested a review from a team as a code owner November 17, 2025 00:23

melvin-bot Bot assigned kadiealexander Nov 17, 2025

melvin-bot Bot requested a review from CortneyOfstad November 17, 2025 00:23

melvin-bot Bot removed the request for review from a team November 17, 2025 00:23

github-actions Bot changed the title ~~Update report state names in HelpDot~~ [No QA] Update report state names in HelpDot Nov 17, 2025

kadiealexander added 15 commits November 17, 2025 13:49

Update Add-an-expense.md

b22243d

Update Edit-expenses.md

efbb4f0

Update Configure-Netsuite.md

6e9f5a7

Update Export- Expenses-from-the-Expenses-Page.md

1282967

Update Expense-Types.md

856ff2c

Update Manage-Company-Cards.md

019a500

Update Reconcile-Company-Card-Expenses.md

aecb2be

Update Connect-Personal-Credit-Cards.md

592a643

Update Remove-Members.md

dd539af

Update Accelo-Troubleshooting.md

ad622e9

Update Configure-Accelo.md

1fb4f05

Update Merging-expenses.md

8b16c90

Update Xero-Troubleshooting.md

30b47a6

Update Quickbooks-Online-Troubleshooting.md

cffee2f

Update Understanding-Report-Statuses-and-Actions.md

8d5d5bc

RachCHopkins reviewed Nov 24, 2025

View reviewed changes

kadiealexander added 3 commits November 24, 2025 16:14

Update Reconcile-Company-Card-Expenses.md

1159587

Update Export- Expenses-from-the-Expenses-Page.md

eb81a03

Update Export- Expenses-from-the-Expenses-Page.md

95b6779

RachCHopkins approved these changes Nov 24, 2025

View reviewed changes

RachCHopkins merged commit 7407b8c into main Nov 24, 2025
12 of 13 checks passed

RachCHopkins deleted the kadiealexander-patch-5 branch November 24, 2025 03:27

melvin-bot Bot added the Emergency label Nov 24, 2025

kadiealexander removed the Emergency label Nov 24, 2025

OSBotify mentioned this pull request Nov 24, 2025

Deploy Checklist: New Expensify 2025-11-24 #75927

Closed

98 tasks

Uh oh!

Conversation

kadiealexander commented Nov 17, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 17, 2025 • edited by RachCHopkins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Concierge reviewer checklist:

Uh oh!

melvin-bot Bot commented Nov 17, 2025

Uh oh!

github-actions Bot commented Nov 17, 2025

HelpDot Documentation Review

Overall Assessment

Scores Summary

Key Findings

Recommendations

Files Reviewed

Overall Score: 8.7/10

Uh oh!

OSBotify commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kadiealexander commented Nov 19, 2025

Uh oh!

RachCHopkins Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

RachCHopkins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot Bot commented Nov 24, 2025

Uh oh!

kadiealexander commented Nov 24, 2025

Uh oh!

RachCHopkins commented Nov 24, 2025

Uh oh!

OSBotify commented Nov 24, 2025

Uh oh!

OSBotify commented Nov 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

melvin-bot Bot commented Nov 17, 2025 •

edited by RachCHopkins

Loading

OSBotify commented Nov 17, 2025 •

edited

Loading