Skip to content

[CP Staging] Revert "issue#68721"#74723

Merged
cristipaval merged 1 commit into
mainfrom
revert-74254-dev#68721
Nov 10, 2025
Merged

[CP Staging] Revert "issue#68721"#74723
cristipaval merged 1 commit into
mainfrom
revert-74254-dev#68721

Conversation

@carlosmiceli

@carlosmiceli carlosmiceli commented Nov 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Straight revert to fix blocker: #74254

@carlosmiceli carlosmiceli self-assigned this Nov 10, 2025
@carlosmiceli carlosmiceli requested review from a team as code owners November 10, 2025 17:13
@melvin-bot melvin-bot Bot requested review from deetergp and trjExpensify and removed request for a team November 10, 2025 17:14
@melvin-bot

melvin-bot Bot commented Nov 10, 2025

Copy link
Copy Markdown

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team November 10, 2025 17:14
@cristipaval cristipaval merged commit f953674 into main Nov 10, 2025
26 of 30 checks passed
@cristipaval cristipaval deleted the revert-74254-dev#68721 branch November 10, 2025 17:16
@melvin-bot melvin-bot Bot added the Emergency label Nov 10, 2025
@melvin-bot

melvin-bot Bot commented Nov 10, 2025

Copy link
Copy Markdown

@cristipaval looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@cristipaval cristipaval changed the title Revert "issue#68721" [CP Staging] Revert "issue#68721" Nov 10, 2025
@carlosmiceli

carlosmiceli commented Nov 10, 2025

Copy link
Copy Markdown
Contributor Author

Straight revert, no emergency.

OSBotify pushed a commit that referenced this pull request Nov 10, 2025
@cristipaval @OSBotify
Merge pull request #74723 from Expensify/revert-74254-dev#68721
6267833 
(cherry picked from commit f953674)

(cherry-picked to staging by cristipaval)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Nov 10, 2025
@OSBotify OSBotify mentioned this pull request Nov 10, 2025
Closed
20 tasks
@OSBotify

OSBotify commented Nov 10, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.2.48-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@github-actions github-actions Bot mentioned this pull request Nov 10, 2025
Closed
@OSBotify

OSBotify commented Nov 10, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@cristipaval cristipaval mentioned this pull request Nov 10, 2025
Closed
8 tasks
@codecov

codecov Bot commented Nov 10, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/pages/ReportDetailsPage.tsx 59.30% <100.00%> (ø)
src/components/DisplayNames/index.native.tsx 88.88% <66.66%> (-11.12%) ⬇️
src/components/DisplayNames/index.tsx 0.00% <0.00%> (ø)
... and 6 files with indirect coverage changes

@OSBotify

OSBotify commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.48-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.2.49-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

1 similar comment
@OSBotify

OSBotify commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.2.49-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.2.52-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 cancelled 🔪
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.54-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.2.52-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 cancelled 🔪
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cristipaval cristipaval cristipaval approved these changes
@trjExpensify trjExpensify Awaiting requested review from trjExpensify
@deetergp deetergp Awaiting requested review from deetergp

Assignees

@carlosmiceli carlosmiceli

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlosmiceli @OSBotify @cristipaval