Skip to content

Revert "fix: show Mark As Resolved as primary action"#74305

Merged
luacmartins merged 1 commit into
mainfrom
revert-72947-fix/72393
Nov 5, 2025
Merged

Revert "fix: show Mark As Resolved as primary action"#74305
luacmartins merged 1 commit into
mainfrom
revert-72947-fix/72393

Conversation

@grgia

@grgia grgia commented Nov 5, 2025 •
edited by luacmartins
Loading

Copy link
Copy Markdown
Contributor

Reverts #72947

Fixed issue

$ #74273

@grgia grgia self-assigned this Nov 5, 2025
@github-actions

github-actions Bot commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #74305.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://74305.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@codecov

codecov Bot commented Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/CONST/index.ts 85.71% <ø> (ø)
src/libs/ReportPrimaryActionUtils.ts 91.75% <ø> (+0.21%) ⬆️
src/libs/ReportSecondaryActionUtils.ts 91.16% <ø> (+0.23%) ⬆️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@grgia
grgia marked this pull request as ready for review November 5, 2025 15:30
@grgia
grgia requested review from a team as code owners November 5, 2025 15:30
@melvin-bot
melvin-bot Bot requested review from MonilBhavsar and heyjennahay and removed request for a team November 5, 2025 15:30
@melvin-bot

melvin-bot Bot commented Nov 5, 2025

Copy link
Copy Markdown

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins
luacmartins approved these changes Nov 5, 2025
View reviewed changes

@luacmartins luacmartins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luacmartins

luacmartins commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

Straight revert. Merging without checklists and stuck Claude review check

@luacmartins
luacmartins merged commit 7b9e448 into main Nov 5, 2025
28 of 32 checks passed
@luacmartins
luacmartins deleted the revert-72947-fix/72393 branch November 5, 2025 15:32
@melvin-bot melvin-bot Bot added the Emergency label Nov 5, 2025
@melvin-bot

melvin-bot Bot commented Nov 5, 2025

Copy link
Copy Markdown

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@github-actions

github-actions Bot commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

LGTM :feelsgood:. Thank you for your hard work!

@github-actions github-actions Bot mentioned this pull request Nov 5, 2025
Closed
OSBotify pushed a commit that referenced this pull request Nov 5, 2025
@luacmartins @OSBotify
Merge pull request #74305 from Expensify/revert-72947-fix/72393
31765f4 
Revert "fix: show Mark As Resolved as primary action"

(cherry picked from commit 7b9e448)

(cherry-picked to staging by luacmartins)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Nov 5, 2025
@OSBotify OSBotify mentioned this pull request Nov 5, 2025
Closed
56 tasks
@OSBotify

OSBotify commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.2.44-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 success ✅

@kavimuru

kavimuru commented Nov 5, 2025

Copy link
Copy Markdown

@grgia @luacmartins Failing on desktop with fixed issue #74273 https://platform.applause.com/services/links/v1/external/05f3cd2db2d892ceb805e280ee1cd9a84645fef499c818774857862b1c11c37d

@mountiny mountiny removed the Emergency label Nov 5, 2025
@mountiny

mountiny commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

Straight revert, not emergency

@OSBotify

OSBotify commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.44-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.2.45-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.45-6 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luacmartins luacmartins luacmartins approved these changes
@heyjennahay heyjennahay Awaiting requested review from heyjennahay
@MonilBhavsar MonilBhavsar Awaiting requested review from MonilBhavsar

Assignees

@grgia grgia

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@grgia @luacmartins @OSBotify @kavimuru @mountiny