perf: optimize useShortMentionList#74069
Merged
mountiny merged 5 commits intoNov 4, 2025
Merged
Conversation
Contributor
|
LGTM |
. Thank you for your hard work!
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
adhorodyski
reviewed
Nov 3, 2025
TMisiukiewicz
marked this pull request as ready for review
November 4, 2025 08:28
melvin-bot
Bot
requested review from
jjcoffee and
joekaufmanexpensify
and removed request for
a team
November 4, 2025 08:28
| }) | ||
| .filter((login): login is string => !!login); | ||
| }, [currentUserPersonalDetails.login, personalDetails]); | ||
| }, [currentUserDomain, isCurrentUserPublicDomain, personalDetails]); |
Contributor
There was a problem hiding this comment.
❌ PERF-6 (docs)
The useMemo dependency array uses derived values (currentUserDomain, isCurrentUserPublicDomain) instead of the source property they depend on (currentUserPersonalDetails.login). This reduces dependency tracking granularity and can cause issues with React's exhaustive-deps rules.
Suggested fix:
Move the domain extraction logic inside the useMemo and depend on the original property:
const availableLoginsList = useMemo(() => {
if (!personalDetails) {
return [];
}
const currentUserDomain = getEmailDomain(currentUserPersonalDetails.login ?? '');
const isCurrentUserPublicDomain = isDomainPublic(currentUserDomain);
return Object.values(personalDetails)
.map((personalDetail) => {
if (!personalDetail?.login || isCurrentUserPublicDomain) {
return;
}
const personalDetailDomain = getEmailDomain(personalDetail.login);
const isPersonalDetailPublicDomain = isDomainPublic(personalDetailDomain);
if (isPersonalDetailPublicDomain || personalDetailDomain !== currentUserDomain) {
return;
}
const [username] = personalDetail.login.split('@');
return username;
})
.filter((login): login is string => !!login);
}, [currentUserPersonalDetails.login, personalDetails]);
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
|
Contributor
|
Performance change, no product considerations. Unsubscribing and removing my review 👍 |
joekaufmanexpensify
removed their request for review
November 4, 2025 16:09
mountiny
approved these changes
Nov 4, 2025
mountiny
left a comment
Contributor
There was a problem hiding this comment.
Moving this ahead, but can you please follow up on Adding unit tests for those methods, this should be the default practice for any utils method even if its simple
Comment on lines
+42
to
+52
| function isDomainPublic(domain: string): boolean { | ||
| return PUBLIC_DOMAINS_SET.has(domain); | ||
| } | ||
|
|
||
| /** | ||
| * Get the domain for an email | ||
| */ | ||
| function getEmailDomain(email: string): string { | ||
| return Str.extractEmailDomain(email).toLowerCase(); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Albeit very simple methods, can you please add unit tests for these?
Contributor
Author
There was a problem hiding this comment.
@mountiny sorry I forgot about doing that in this PR, I was in a hell of switching between contexts yesterday 😄 Will open a follow up PR shortly!
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
56 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.44-0 🚀
|
54 tasks
Contributor
Author
|
Follow up PR: #74314 |
Contributor
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.44-5 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #74088
PROPOSAL:
Tests
@Offline tests
n/a
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
iOS: Native
ios.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov