useSearchSelector hook and remove useless code v3 by nkdengineer · Pull Request #73908 · Expensify/App

nkdengineer · 2025-10-31T04:18:40Z

Explanation of Change

Fixed Issues

$ #71057
#72586
#72523
#72516
#73874
#73875
PROPOSAL: #71057 (comment)

Tests

Login with the new account
Choose Track and budget expenses
Enter your name and choose create workspace
In invite members step, type any email
Choose this user and click continue
Go to workspace -> members
Verify that: there are 2 members
Open 1:1 DM with new user
Go to workspace member page
Try to invite a new member to this workspace
Verify that: The DM user will appear in the contact list.
Enter the email of the DM user from Step 4.
Verify that: "No results found" will not show up after entering contact email and the message '${login} is already a member of ${workspace}' should still be shown

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

android-mweb-resize.mp4

iOS: Native

ios-resize.mp4

iOS: mWeb Safari

ios-mweb-resize.mp4

MacOS: Chrome / Safari

bug-resize.mp4

MacOS: Desktop

desktop-resize.mp4

…move useless code""

codecov · 2025-10-31T04:28:45Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/pages/workspace/WorkspaceInvitePage.tsx	`0.00% <0.00%> (ø)`
...gWorkspaceInvite/BaseOnboardingWorkspaceInvite.tsx	`1.09% <0.00%> (-0.04%)`	⬇️
... and 153 files with indirect coverage changes

melvin-bot · 2025-11-03T16:11:40Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-11-03T16:12:53Z

LGTM . Thank you for your hard work!

nkdengineer · 2025-11-11T09:42:57Z

@allroundexperts Friendly bump.

joekaufmanexpensify · 2025-11-11T15:59:34Z

No product considerations, removing my review

allroundexperts · 2025-11-13T16:55:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-29.at.3.12.46.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-10-29.at.3.09.50.AM.mov

iOS: HybridApp

iOS: mWeb Safari

Screen.Recording.2025-10-29.at.3.06.50.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-29.at.2.54.46.AM.mov

MacOS: Desktop

Screen.Recording.2025-10-29.at.3.04.01.AM.mov

OSBotify · 2025-11-16T04:24:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-18T12:07:12Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.2.60-0 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-18T16:29:24Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.2.60-0 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-18T16:50:10Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.2.60-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

danieldoglas · 2025-11-18T17:44:42Z

@nkdengineer seems like this caused a regression - #75418

OSBotify · 2025-11-19T16:07:30Z

🚀 Deployed to production by https://github.com/grgia in version: 9.2.60-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

ZhenjaHorbach · 2025-12-18T07:23:07Z

-        const newSelectedOptions: MemberForList[] = [];
-        if (firstRenderRef.current) {
-            // We only want to add the saved selected user on first render
-            firstRenderRef.current = false;
-            Object.entries(invitedEmailsToAccountIDsDraft ?? {}).forEach(([login, accountID]) => {
-                if (login in detailsMap) {
-                    newSelectedOptions.push({...detailsMap[login], isSelected: true});
-                } else {
-                    const optimisticOption = getUserToInviteOption({
-                        searchValue: login,
-                    });
-                    if (optimisticOption) {
-                        optimisticOption.accountID = Number(accountID);
-                        const memberOption = formatMemberForList({
-                            ...optimisticOption,
-                            accountID: Number(accountID),
-                            isSelected: true,
-                        });
-                        newSelectedOptions.push(memberOption);
-                    }
-                }


Came from this issue
More context here

Revert "[CP Staging] Revert "follow up: useSearchSelector hook and re…

062dd48

…move useless code""

melvin-bot Bot assigned nkdengineer Oct 31, 2025

Merge branch 'main' into revert-73877-revert-72677-follow-up-71057

0363710

nkdengineer changed the title ~~Revert "[CP Staging] Revert "follow up: useSearchSelector hook and remove useless code""~~ useSearchSelector hook and remove useless code v3 Nov 3, 2025

fix no result found

2b66115

nkdengineer marked this pull request as ready for review November 3, 2025 16:11

nkdengineer requested a review from a team as a code owner November 3, 2025 16:11

melvin-bot Bot requested review from allroundexperts and removed request for a team November 3, 2025 16:11

nkdengineer added 2 commits November 3, 2025 23:15

remove recent report options

a482b34

resolve conflict

b5a39d2

nkdengineer requested a review from a team as a code owner November 11, 2025 09:42

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team November 11, 2025 09:42

joekaufmanexpensify removed their request for review November 11, 2025 15:59

Merge branch 'main' into revert-73877-revert-72677-follow-up-71057

037ff8f

Christinadobrzyn mentioned this pull request Nov 12, 2025

[Due for payment 2025-12-04] [$250] Refactor provided component to use useSearchSelector hook and remove unused and duplicated code (Task 1) #71057

Closed

allroundexperts approved these changes Nov 13, 2025

View reviewed changes

melvin-bot Bot requested a review from mollfpr November 13, 2025 16:55

mollfpr approved these changes Nov 16, 2025

View reviewed changes

mollfpr merged commit 7ab470f into Expensify:main Nov 16, 2025
27 checks passed

OSBotify mentioned this pull request Nov 18, 2025

Deploy Checklist: New Expensify 2025-11-18 #75383

Closed

58 tasks

mitarachim mentioned this pull request Nov 18, 2025

Workspace - "No results found" is shown when searching for already selected user #75418

Closed

8 tasks

bernhardoj mentioned this pull request Nov 24, 2025

[$250] Workspace - Selected members are deselected after refreshing the Confirm details page #75799

Closed

16 tasks

ZhenjaHorbach reviewed Dec 18, 2025

View reviewed changes

Uh oh!

Conversation

nkdengineer commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 31, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Nov 3, 2025

Uh oh!

github-actions Bot commented Nov 3, 2025

Uh oh!

nkdengineer commented Nov 11, 2025

Uh oh!

joekaufmanexpensify commented Nov 11, 2025

Uh oh!

allroundexperts commented Nov 13, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Nov 16, 2025

Uh oh!

OSBotify commented Nov 18, 2025

Uh oh!

OSBotify commented Nov 18, 2025

Uh oh!

OSBotify commented Nov 18, 2025

Uh oh!

danieldoglas commented Nov 18, 2025

Uh oh!

OSBotify commented Nov 19, 2025

Uh oh!

ZhenjaHorbach Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nkdengineer commented Oct 31, 2025 •

edited

Loading

codecov Bot commented Oct 31, 2025 •

edited by github-actions Bot

Loading