Fix: Magic code error does not appear above Verify button when revealing details by ryntgh · Pull Request #73605 · Expensify/App

ryntgh · 2025-10-28T01:40:39Z

Explanation of Change

Fixed Issues

$ #73134
PROPOSAL: #73134 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Precondition:

User has assigned themselves a virtual card

Go to Account > Wallet
Click on the virtual card
Click Reveal details
Close the RHP
Repeat steps 3 and 4 until the error message "Failed to send a new magic code. Please wait a bit and try again." appears
Click the X button next to the message
Verify that the error is dismissed
Enter an incorrect magic code
Verify that the magic code error is displayed above the Verify button
Click the X button next to the message
Verify that the error is dismissed

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-Native.mp4

Android: mWeb Chrome

Android-mWeb.mp4

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

iOS-mWeb.mp4

MacOS: Chrome / Safari

MacOS-Chrome.mp4

MacOS: Desktop

MacOS-Desktop.mp4

…ing details

codecov · 2025-10-28T01:52:30Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines	Coverage Δ
...pensifyCardPage/ExpensifyCardVerifyAccountPage.tsx	`0.00% <ø> (ø)`

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-29T11:52:31Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2025-10-29T14:35:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: HybridApp

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

Sign in to view

                        clearValidateCodeActionError(validateCodeActionErrorField);
                    }
+                    if (!isEmptyObject(validateCodeAction?.errorFields?.actionVerified)) {
+                        clearValidateCodeActionError('actionVerified');


ryntgh · 2025-10-30T06:04:34Z

Seems like this PR implements the same logic for clearing the actionVerified error on BaseValidationCodeForm, so I reverted the changes here. Do you think we should define the const for actionVerified in this case? @bernhardoj

bernhardoj · 2025-10-30T07:06:07Z

Oh, I think we can leave it as it is then. Thanks!

bernhardoj

LGTM!

OSBotify · 2025-10-31T05:08:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-31T21:48:05Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.2.42-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2025-11-03T09:19:53Z

@ryntgh PR failed with the original issue

1762110376375.Screen_Recording_2025-11-02_at_21.04.31.mp4

ryntgh · 2025-11-03T13:19:28Z

Hi @IuliiaHerets, could you please clarify which step is failing in this case? From what I can see in the attached video, the magic code error is displayed correctly above the Verify button

IuliiaHerets · 2025-11-03T14:46:26Z

@ryntgh The magic code error is still appearing on the previous page, under the Reveal details button. Shared one more video

1761954059388.73605-Web.mp4

ryntgh · 2025-11-03T15:41:35Z

@IuliiaHerets Isn’t the error message expected? In the original issue, the expected result only states that the magic code error should appear above the Verify button

Expected Result:
In Step 5, magic code error will appear above Verify button

cc @bernhardoj @danieldoglas for clarity

bernhardoj · 2025-11-03T16:34:34Z

Yeah, I think it's a different issue.

The error shown in the card page is from the error state set locally here,

App/src/pages/settings/Wallet/ExpensifyCardPage/ExpensifyCardVerifyAccountPage.tsx

Lines 55 to 61 in 33eaba5

    
           .catch((error: string) => { 
        
               // Displaying magic code errors is handled in the modal, no need to set it on the card 
        
               setCardsDetailsErrors((prevState) => ({ 
        
                   ...prevState, 
        
                   [cardID]: error, 
        
               })); 
        
           })

while the error on the magic code page is solely received from the BE.

@danieldoglas do you think we should create a new issue for that or just let @ryntgh handle it on a new PR and increase the price?

danieldoglas · 2025-11-03T18:01:24Z

@bernhardoj Let's increase the price and fix the other issue.

IuliiaHerets · 2025-11-03T18:03:46Z

@bernhardoj @danieldoglas do we need to log a new issue?

danieldoglas · 2025-11-03T18:05:54Z

nope, it's fine to use the same one.

OSBotify · 2025-11-03T22:41:18Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.42-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

bernhardoj · 2025-11-04T02:07:22Z

@danieldoglas to clarify, I think we don't need to show the (non-dismissable) error message on the card page, and instead show it on the magic code page, right?

With the current code, if somehow the reveal details request fails, there won't be an error message on the magic code page, and the user needs to go back to see the error message.

(I turned on simulate failing network request when entering the magic code)

w.mp4

ryntgh · 2025-11-04T13:24:44Z

Based on @bernhardoj comment here, is this the expected behavior? Are we not going to use the error received from the BE on the magic code page?

MacOS-Chrome.mp4

RCA

When the user enters a wrong magic code, the error gets stored in the card details context (cardsDetailsErrors). This context is used by the main card page to display errors under the "Reveal details" button

App/src/pages/settings/Wallet/ExpensifyCardPage/ExpensifyCardVerifyAccountPage.tsx

Lines 55 to 61 in 28ede48

    
           .catch((error: string) => { 
        
               // Displaying magic code errors is handled in the modal, no need to set it on the card 
        
               setCardsDetailsErrors((prevState) => ({ 
        
                   ...prevState, 
        
                   [cardID]: error, 
        
               })); 
        
           })

Solution

Handle the magic code validation error locally

            .catch((error: TranslationPaths) => {
                setValidateError(getMicroSecondOnyxErrorWithTranslationKey(error));
            })

App/src/pages/settings/Wallet/ExpensifyCardPage/ExpensifyCardVerifyAccountPage.tsx

Lines 55 to 61 in 28ede48

    
           .catch((error: string) => { 
        
               // Displaying magic code errors is handled in the modal, no need to set it on the card 
        
               setCardsDetailsErrors((prevState) => ({ 
        
                   ...prevState, 
        
                   [cardID]: error, 
        
               })); 
        
           })

Then we can also set validateCodeActionErrorField to an empty string

            validateCodeActionErrorField=""

App/src/pages/settings/Wallet/ExpensifyCardPage/ExpensifyCardVerifyAccountPage.tsx

Line 72 in 28ede48

validateCodeActionErrorField="revealExpensifyCardDetails"

bernhardoj · 2025-11-05T06:43:49Z

@danieldoglas hi, can you confirm the expected behavior? The video on my previous comment shows the current behavior, while the video on @ryntgh comment above is the new behavior.

danieldoglas · 2025-11-18T20:27:07Z

to clarify, I think we don't need to show the (non-dismissable) error message on the card page, and instead show it on the magic code page, right?

Yes, that's what I expect in this case too.

bernhardoj · 2025-11-19T00:54:26Z

@ryntgh you can go create the new PR

ryntgh · 2025-11-19T23:02:25Z

Sure, I'll raise the PR ASAP

Fix: Magic code error does not appear above Verify button when reveal…

12ca386

…ing details

melvin-bot Bot assigned ryntgh Oct 28, 2025

ryntgh marked this pull request as ready for review October 29, 2025 11:52

ryntgh requested a review from a team as a code owner October 29, 2025 11:52

melvin-bot Bot requested a review from bernhardoj October 29, 2025 11:52

melvin-bot Bot removed the request for review from a team October 29, 2025 11:52

ryntgh mentioned this pull request Oct 29, 2025

[READY FOR PAYMENT] [$500] Expensify Card - Magic code error does not appear above Verify button when revealing details #73134

Closed

16 tasks

bernhardoj reviewed Oct 29, 2025

View reviewed changes

ryntgh added 2 commits October 30, 2025 13:30

Add ACTION_VERIFIED_ERROR_FIELD constant

03e944a

Merge branch 'main' into issue-73134

b85beb3

bernhardoj approved these changes Oct 30, 2025

View reviewed changes

melvin-bot Bot requested a review from danieldoglas October 30, 2025 07:06

danieldoglas approved these changes Oct 31, 2025

View reviewed changes

danieldoglas merged commit 91cf31f into Expensify:main Oct 31, 2025
25 checks passed

OSBotify mentioned this pull request Oct 31, 2025

Deploy Checklist: New Expensify 2025-10-31 #73985

Closed

Uh oh!

Conversation

ryntgh commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 29, 2025

Uh oh!

bernhardoj commented Oct 29, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

This comment was marked as resolved.

Uh oh!

ryntgh commented Oct 30, 2025

Uh oh!

bernhardoj commented Oct 30, 2025

Uh oh!

bernhardoj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 31, 2025

Uh oh!

OSBotify commented Oct 31, 2025

Uh oh!

IuliiaHerets commented Nov 3, 2025

Uh oh!

ryntgh commented Nov 3, 2025

Uh oh!

IuliiaHerets commented Nov 3, 2025

Uh oh!

ryntgh commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bernhardoj commented Nov 3, 2025

Uh oh!

danieldoglas commented Nov 3, 2025

Uh oh!

IuliiaHerets commented Nov 3, 2025

Uh oh!

danieldoglas commented Nov 3, 2025

Uh oh!

OSBotify commented Nov 3, 2025

Uh oh!

bernhardoj commented Nov 4, 2025

Uh oh!

ryntgh commented Nov 4, 2025

RCA

Solution

Uh oh!

bernhardoj commented Nov 5, 2025

Uh oh!

danieldoglas commented Nov 18, 2025

Uh oh!

bernhardoj commented Nov 19, 2025

Uh oh!

ryntgh commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ryntgh commented Oct 28, 2025 •

edited

Loading

codecov Bot commented Oct 28, 2025 •

edited

Loading

ryntgh commented Nov 3, 2025 •

edited

Loading