refactor: isolate dismissDuplicateTransactionViolation from Onyx.connect data by Skalakid · Pull Request #72955 · Expensify/App

Skalakid · 2025-10-20T09:54:32Z

Explanation of Change

This PR is part of a refactor to remove Onyx.connect for the keys: ONYXKEYS.COLLECTION.TRANSACTION and ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS from the src/libs/actions/Transaction.ts file and replace it with useOnyx.

It isolates the dismissDuplicateTransactionViolation function from the Onyx.connect data.

To ensure this refactor doesn't break anything, it adds automated tests to the dismissDuplicateTransactionViolation function.

Fixed Issues

$ #67777
$ #67780
PROPOSAL:

Tests

Submit two or more of the same expense scans
After finishing scanning, those expenses should be put on hold
Open one of them and click the Review duplicates button
The new screen should be open
Click Keep all button, it should dismiss the violations
Verify if all violations were dismissed and all expenses are kept

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

web2.mov

…ect data

…ect TRANSACTION_VIOLATIONS data

codecov · 2025-10-20T10:06:21Z

Codecov Report

❌ Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/pages/TransactionDuplicate/Review.tsx	0.00%	12 Missing ⚠️

Files with missing lines	Coverage Δ
src/libs/actions/Transaction.ts	`59.24% <100.00%> (+11.79%)`	⬆️
src/pages/TransactionDuplicate/Review.tsx	`0.00% <0.00%> (ø)`

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…nnect/dismissDuplicateTransactionViolation-src-libs-actions-Transaction.ts

dariusz-biela · 2025-10-29T10:33:15Z

file with test for actions/Transaction.ts exist under path tests/unit/TransactionTest.ts.

I would keep only one file with tests for Transaction.
You can choose which is better old or new one and move all tests there.

Okay, I moved my tests to already existing file with unit tests

melvin-bot · 2025-10-29T14:30:39Z

@DylanDylann @tgolen One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tgolen · 2025-10-29T15:51:02Z

+    const [allTransactions] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION, {canBeMissing: false});
+    const [allTransactionViolation] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS, {canBeMissing: false});


Can these use selectors at all? It looks like they should each be using a selector to only get the transactionIDs transactions.

You mean to select only these transactions and transactionViolation with ids from transactionIDs?

Yeah, exactly.

Fixed in 1d09d0f

…nnect/dismissDuplicateTransactionViolation-src-libs-actions-Transaction.ts

tgolen

Please don't force push on your branches once they have begun to be reviewed. It loses all the history when you do that.

blazejkustra · 2025-11-03T18:45:41Z

Any next steps other than a merge? @tgolen

tgolen · 2025-11-03T18:46:46Z

Looks like it needs a checklist from @DylanDylann

DylanDylann · 2025-11-04T11:10:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2025-11-04.at.18.10.45.mov

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

DylanDylann

LGTM

OSBotify · 2025-11-04T15:23:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-04T21:13:40Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.2.44-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-05T20:07:03Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.44-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Skalakid added 4 commits October 20, 2025 10:59

refactor: isolate dismissDuplicateTransactionViolation from Onyx.conn…

d890e48

…ect data

test: add dismissDuplicateTransactionViolation action tests

8a8b292

refactor: isolate dismissDuplicateTransactionViolation from Onyx.conn…

6fd4fbc

…ect TRANSACTION_VIOLATIONS data

test: fix tests

89a32b9

melvin-bot Bot assigned Skalakid Oct 20, 2025

Skalakid added 5 commits October 20, 2025 12:53

refactor: fix check errors

d824088

lint: fix errors

93be8de

fix: fix import

04e7af5

Merge branch 'main' into @Skalakid/refactor/useonyx-deprecate-onyx-co…

f794f1f

…nnect/dismissDuplicateTransactionViolation-src-libs-actions-Transaction.ts

Merge branch 'main' into @Skalakid/refactor/useonyx-deprecate-onyx-co…

0d17106

…nnect/dismissDuplicateTransactionViolation-src-libs-actions-Transaction.ts

dariusz-biela approved these changes Oct 29, 2025

View reviewed changes

refactor: move new tests to unit tests

ba43d7c

Skalakid requested a review from dariusz-biela October 29, 2025 14:30

Skalakid marked this pull request as ready for review October 29, 2025 14:30

Skalakid requested a review from a team as a code owner October 29, 2025 14:30

melvin-bot Bot requested review from DylanDylann and tgolen and removed request for a team October 29, 2025 14:30

tgolen requested changes Oct 29, 2025

View reviewed changes

Skalakid added 3 commits October 31, 2025 11:51

Merge branch 'main' into @Skalakid/refactor/useonyx-deprecate-onyx-co…

c11aa8e

…nnect/dismissDuplicateTransactionViolation-src-libs-actions-Transaction.ts

Merge branch 'main' into @Skalakid/refactor/useonyx-deprecate-onyx-co…

ee32a3d

…nnect/dismissDuplicateTransactionViolation-src-libs-actions-Transaction.ts

refactor: add review changes

1d09d0f

Skalakid force-pushed the @Skalakid/refactor/useonyx-deprecate-onyx-connect/dismissDuplicateTransactionViolation-src-libs-actions-Transaction.ts branch from bfdbbbf to 1d09d0f Compare November 3, 2025 11:38

tgolen approved these changes Nov 3, 2025

View reviewed changes

DylanDylann approved these changes Nov 4, 2025

View reviewed changes

melvin-bot Bot requested a review from tgolen November 4, 2025 11:11

tgolen merged commit c2517a8 into Expensify:main Nov 4, 2025
25 of 26 checks passed

OSBotify mentioned this pull request Nov 4, 2025

Deploy Checklist: New Expensify 2025-11-04 #74235

Closed

56 tasks

This was referenced Nov 5, 2025

[CP Staging] Revert "refactor: isolate dismissDuplicateTransactionViolation from Onyx.connect data" #74330

Merged

[Due for payment 2025-11-13] [Due for payment 2025-11-12] Expense - No system message after resolving duplicates by "Keep All" button #74255

Closed

		const [allTransactions] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION, {canBeMissing: false});
		const [allTransactionViolation] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS, {canBeMissing: false});

Uh oh!

Conversation

Skalakid commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dariusz-biela Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Skalakid Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Oct 29, 2025

Uh oh!

tgolen Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Skalakid Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

tgolen Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Skalakid Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgolen left a comment

Choose a reason for hiding this comment

Uh oh!

blazejkustra commented Nov 3, 2025

Uh oh!

tgolen commented Nov 3, 2025

Uh oh!

DylanDylann commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Nov 4, 2025

Uh oh!

OSBotify commented Nov 4, 2025

Uh oh!

OSBotify commented Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Skalakid commented Oct 20, 2025 •

edited

Loading

codecov Bot commented Oct 20, 2025 •

edited

Loading

Skalakid Oct 29, 2025 •

edited

Loading

Skalakid Nov 3, 2025 •

edited

Loading

DylanDylann commented Nov 4, 2025 •

edited

Loading