Skip to content

fix: misspelled copy in bank account validation step#7289

Merged
AndrewGable merged 2 commits into
Expensify:mainfrom
mdneyazahmad:fix/6980-misspelled-copy
Jan 18, 2022
Merged

fix: misspelled copy in bank account validation step#7289
AndrewGable merged 2 commits into
Expensify:mainfrom
mdneyazahmad:fix/6980-misspelled-copy

Conversation

@mdneyazahmad

Copy link
Copy Markdown
Contributor

Details

Update copy in bank account validation step.

Fixed Issues

$ #6980

Tests

  1. Workspace -> Connect bank account
  • Verify that no errors appear in the JS console

QA Steps

  1. Same as test steps
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2022-01-18 at 4 19 05 PM

Screenshot 2022-01-18 at 4 41 13 PM

Mobile Web

Simulator Screen Shot - iPhone 13 - 2022-01-18 at 16 45 26
Simulator Screen Shot - iPhone 13 - 2022-01-18 at 16 43 19

Desktop

Screenshot 2022-01-18 at 4 51 41 PM

Screenshot 2022-01-18 at 4 20 47 PM

iOS

Simulator Screen Shot - iPhone 13 - 2022-01-18 at 16 27 24
Simulator Screen Shot - iPhone 13 - 2022-01-18 at 16 39 13

Android

Same as iOS

@mdneyazahmad mdneyazahmad requested a review from a team as a code owner January 18, 2022 11:35
@MelvinBot MelvinBot requested review from AndrewGable and rushatgabhane and removed request for a team January 18, 2022 11:35
Comment thread src/languages/es.js Outdated
letsChatCTA: '¡Sí, vamos a chatear!',
letsChatText: '¡Gracias! Necesitamos tu ayuda para verificar la información, pero podemos hacerlo rápidamente a través del chat. ¿Estás listo?',
letsChatCTA: 'Sí, vamos a chatear',
letsChatText: 'Gracias Necesitamos tu ayuda para verificar la información, pero podemos hacerlo rápidamente a través del chat. ¿Estás listo?',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing a period after Gracias

@rushatgabhane rushatgabhane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, suggested a change

@rushatgabhane rushatgabhane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndrewGable LGTM! 🎉

Adding Spanish copy as it isn't in screenshots.

@AndrewGable AndrewGable merged commit b39fc9a into Expensify:main Jan 18, 2022
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @AndrewGable in version: 1.1.30-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants