[CP Staging] Fix: Copilot is redirected to https://expensifycom.cloudflareaccess.com/ after being deleted#72776
Merged
Merged
Conversation
MariaHCD
approved these changes
Oct 16, 2025
Contributor
Author
|
Also verified that supportal action works well after recent changes: Screen.Recording.2025-10-16.at.7.57.04.PM.mov |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
mountiny
approved these changes
Oct 16, 2025
mountiny
left a comment
Contributor
There was a problem hiding this comment.
Changes look safe and @allgandalf tested the blocker flow, will ask applause for a retest
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
OSBotify
pushed a commit
that referenced
this pull request
Oct 16, 2025
[CP Staging] Fix: Copilot is redirected to https://expensifycom.cloudflareaccess.com/ after being deleted (cherry picked from commit 2e9d6d9) (cherry-picked to staging by mountiny)
52 tasks
Contributor
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.32-6 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.32-6 🚀
|
8 tasks
Contributor
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.33-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.33-4 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
While addressing supportal logout issue, I didn't take into account the delegate case where the access is revoked when delegate is already into the delegators account.
With this PR we perform the logic specifically when we are logging out as supportal agent
Fixed Issues
$ #72734
PROPOSAL: N/A
Tests
Offline tests
QA Steps
Precondition:
Verify that the copilot should be logged out when the primary account removes access
Screen.Recording.2025-10-16.at.7.54.17.PM.mov
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.