[No QA] Update Translation model to GPT-5#72640
Conversation
|
@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Bonus reason to make this change according to ChatGPT:
|
| this.client.chat.completions.create({ | ||
| model, | ||
| messages, | ||
| temperature: 0.3, |
There was a problem hiding this comment.
I see we're not passing a reasoning parameter here, is that intentional?
There was a problem hiding this comment.
Yeah it's not a required parameter so I'd say it's intentional to leave it to the default.
There was a problem hiding this comment.
after chatting 1:1 with @jasperhuangg, we added reasoning_effort: 'low' to speed it up. Apparently we don't even use reasoning_effort: 'medium' for AgentZero, so this is probably good enough for translating one phrase at a time.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.2.33-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.33-4 🚀
|
Explanation of Change
GPT-5 is generally better for translations than 4o. Might as well upgrade before we start refining all of our translations.
Fixed Issues
related to #72168
Tests
Covered by existing automated tests.
Ran
npx ts-node scripts/generateTranslations.ts --paths validateCodeForm.requestNewCodeas a test.Verify that no errors appear in the JS console
Offline tests
None.
QA Steps
None
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop