Skip to content

[CP Staging] fix: Tags - Tag icon on upgrade page is black. #72576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 1 commit into from
Oct 14, 2025
Merged

[CP Staging] fix: Tags - Tag icon on upgrade page is black. #72576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/components/Icon/chunks/illustrations.chunk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import InvoiceBlue from '@assets/images/simple-illustrations/simple-illustration
import MagnifyingGlassMoney from '@assets/images/simple-illustrations/simple-illustration__magnifyingglass-money.svg';
import MoneyReceipts from '@assets/images/simple-illustrations/simple-illustration__money-receipts.svg';
import MoneyWings from '@assets/images/simple-illustrations/simple-illustration__moneywings.svg';
import Pencil from '@assets/images/simple-illustrations/simple-illustration__pencil.svg';
import PerDiem from '@assets/images/simple-illustrations/simple-illustration__perdiem.svg';
import ReceiptWrangler from '@assets/images/simple-illustrations/simple-illustration__receipt-wrangler.svg';
import ReportReceipt from '@assets/images/simple-illustrations/simple-illustration__report-receipt.svg';
Expand Down Expand Up @@ -67,6 +68,7 @@ const Illustrations = {
CompanyCard,
Workflows,
CarIce,
Pencil,
// Legacy aliases for compatibility
Car: CompanyCard, // Fallback for Car illustration requests
};
Expand Down Expand Up @@ -124,6 +126,8 @@ function getIllustration(illustrationName: string): unknown {
return CompanyCard;
case 'CarIce':
return CarIce;
case 'Pencil':
return Pencil;
default:
// Fallback to object lookup for any other cases
return (Illustrations as Record<string, unknown>)[illustrationName];
Expand Down
4 changes: 2 additions & 2 deletions src/pages/workspace/upgrade/UpgradeIntro.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ function UpgradeIntro({feature, onUpgrade, buttonDisabled, loading, isCategorizi
const allIconNames = Object.values(CONST.UPGRADE_FEATURE_INTRO_MAPPING)
.map((feat) => feat?.icon)
.filter((icon) => icon !== undefined);
const illustrations = useMemoizedLazyIllustrations(['FolderOpen', 'Tag', 'Coins', 'Rules', 'CompanyCard', 'PerDiem', 'ReportReceipt', 'CarIce']);
const illustrationIcons = useMemoizedLazyExpensifyIcons(['Pencil', 'Tag', 'IntacctSquare', 'NetSuiteSquare', 'QBDSquare', 'AdvancedApprovalsSquare', 'Luggage', 'Unlock']);
const illustrations = useMemoizedLazyIllustrations(['FolderOpen', 'Tag', 'Coins', 'Rules', 'CompanyCard', 'PerDiem', 'ReportReceipt', 'CarIce', 'Pencil']);
const illustrationIcons = useMemoizedLazyExpensifyIcons(['IntacctSquare', 'NetSuiteSquare', 'QBDSquare', 'AdvancedApprovalsSquare', 'Luggage', 'Unlock']);
const imported = new Set([...Object.keys(illustrations), ...Object.keys(illustrationIcons)]);
const missing = allIconNames.filter((n): n is string => !!n && !imported.has(n));
if (missing.length) {
Expand Down
Loading