-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Migrate ShareDetailsPage to use attachment modal screen #72570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mountiny
merged 14 commits into
Expensify:main
from
margelo:@chrispader/share-details-attachment-modal-migration
Nov 10, 2025
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
713ace0
feat: add attachment modal route for Share
chrispader 3e476a6
Merge branch 'main' into @chrispader/share-details-attachment-modal-m…
chrispader d6e1565
fix: ShareDetailsAttachment screen type
chrispader 8170ce7
fix: use old source validation logic
chrispader a7fb882
revert: AvatarUtils changes
chrispader b587730
refactor: extract variables
chrispader 16fcb35
Merge branch 'main' into @chrispader/share-details-attachment-modal-m…
chrispader 929b926
fix: use `validateFileName` like before
chrispader 1451482
Merge branch 'main' into @chrispader/share-details-attachment-modal-m…
chrispader 23398bd
Merge branch 'main' into pr/72570
chrispader 28b0eae
Merge branch 'main' into pr/72570
chrispader 1e0abd2
fix: invalid source prop
chrispader 59fd83f
fix: remove unnecessary `SafeAreaView`
chrispader 2e66016
remove unused input
chrispader File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
src/pages/media/AttachmentModalScreen/routes/ShareDetailsAttachmentModalContent.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import React, {useMemo} from 'react'; | ||
| import tryResolveUrlFromApiRoot from '@libs/tryResolveUrlFromApiRoot'; | ||
| import type {AttachmentModalBaseContentProps} from '@pages/media/AttachmentModalScreen/AttachmentModalBaseContent/types'; | ||
| import AttachmentModalContainer from '@pages/media/AttachmentModalScreen/AttachmentModalContainer'; | ||
| import type {AttachmentModalScreenProps} from '@pages/media/AttachmentModalScreen/types'; | ||
| import type SCREENS from '@src/SCREENS'; | ||
| import useDownloadAttachment from './hooks/useDownloadAttachment'; | ||
| import useReportAttachmentModalType from './hooks/useReportAttachmentModalType'; | ||
|
|
||
| function ShareDetailsAttachmentModalContent({route, navigation}: AttachmentModalScreenProps<typeof SCREENS.SHARE.SHARE_DETAILS_ATTACHMENT>) { | ||
| const {source: sourceParam, originalFileName: originalFileNameParam, headerTitle, onShow, onClose} = route.params; | ||
|
|
||
| const source = useMemo(() => Number(sourceParam) || (typeof sourceParam === 'string' ? tryResolveUrlFromApiRoot(decodeURIComponent(sourceParam)) : undefined), [sourceParam]); | ||
| const originalFileName = originalFileNameParam ?? ''; | ||
|
|
||
| const onDownloadAttachment = useDownloadAttachment({}); | ||
|
|
||
| const contentProps = useMemo<AttachmentModalBaseContentProps>( | ||
| () => ({ | ||
| source, | ||
| originalFileName, | ||
| headerTitle, | ||
| onDownloadAttachment, | ||
| }), | ||
| [headerTitle, onDownloadAttachment, originalFileName, source], | ||
| ); | ||
|
|
||
| const modalType = useReportAttachmentModalType(source); | ||
| return ( | ||
| <AttachmentModalContainer<typeof SCREENS.SHARE.SHARE_DETAILS_ATTACHMENT> | ||
| navigation={navigation} | ||
| contentProps={contentProps} | ||
| modalType={modalType} | ||
| onShow={onShow} | ||
| onClose={onClose} | ||
| /> | ||
| ); | ||
| } | ||
| ShareDetailsAttachmentModalContent.displayName = 'ReportAttachmentModalContent'; | ||
|
|
||
| export default ShareDetailsAttachmentModalContent; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.