[No QA] Update Automatically-submit-employee-reports.md#72510
Conversation
Updating to change "delay submissions" to "submission frequency" Expensify/Expensify#556179
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@greg-schroeder Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR updates the terminology in the Automatically Submit Employee Reports documentation from "Delay Submissions" to "Submission Frequency" to align with current UI labeling in Expensify Classic. The changes are systematic and maintain consistency throughout the document. Scores Summary
Key FindingsStrengths:
Critical Issue:
Minor Inconsistencies:
Recommendations
Files Reviewed
Note: This is a focused terminology update that improves user experience by aligning documentation with the current product interface. |
|
A preview of your ExpensifyHelp changes have been deployed to https://e64c4c86.helpdot.pages.dev ⚡️ Updated articles: |
|
Looking |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
Test build of the article looks good to me |
|
🚀 Deployed to staging by https://github.com/greg-schroeder in version: 9.2.32-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.32-6 🚀
|
Updating to change "delay submissions" to "submission frequency"
https://github.com/Expensify/Expensify/issues/556179
$ https://github.com/Expensify/Expensify/issues/556179
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.