[NO-QA]Add Workflow run URL to triggerWorkflowAndWait#7250
Merged
Conversation
triggerWorkflowAndWaittriggerWorkflowAndWait
roryabraham
approved these changes
Jan 17, 2022
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
56 tasks
Contributor
Author
|
Confirmed this is working as intended, tests pass ✅
|
Contributor
|
🚀 Deployed to staging by @roryabraham in version: 1.1.30-4 🚀
|
Contributor
|
🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Adds the workflow run URL to
triggerWorkflowAndWait, which will be a small QOL improvement for us when viewing logs.Fixed Issues
$ #7239
Tests
Since this code is deep in the weeds, it seems very hard to test this specific code without running some production code, therefore I would suggest:
triggerWorkflowAndWait