[No QA] Use manual signing for provisioning profile#7241
Merged
Conversation
Contributor
|
|
roryabraham
requested changes
Jan 14, 2022
roryabraham
left a comment
Contributor
There was a problem hiding this comment.
Oh, I'm 99% sure I've made this same mistake in the past. Let's add a simple automated test in test.yml to make sure it doesn't happen again?
if grep -q 'ProvisioningStyle = Automatic;' ios/NewExpensify.xcodeproj/project.pbxproj; then
echo 'Error: Automatic provisioning style is not allowed!'
exit 1
else
exit 0
fi
AndrewGable
approved these changes
Jan 14, 2022
66 tasks
Contributor
|
🚀 Deployed to staging by @roryabraham in version: 1.1.29-9 🚀
|
Contributor
|
🚀 Deployed to production by @roryabraham in version: 1.1.30-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Julesssss
Details
In https://github.com/Expensify/App/pull/6773/files#diff-1b579b2c321f383fcd88594bcf7023d2154da98817b50ee7ec9bc523acb56f35R290 we accidentally changed the signing options (likely for local testing) which resulted in a deploy failure here. This PR reverts the automatic signing change to use our manual provisioning profile.
Fixed Issues
Slack thread: https://expensify.slack.com/archives/C03V9A4TB/p1642190414341000
Tests
QA Steps
No QA
Tested On