[CP Staging] fix: Category - The "GL & Payroll codes" feature shows a fallback avatar icon. by Krishna2323 · Pull Request #72367 · Expensify/App

Krishna2323 · 2025-10-10T22:44:19Z

Explanation of Change

Fixed Issues

$ #72319
PROPOSAL:

Tests

Create a Workspace
Go to Categories > click on any category
Then click on GL code or Payroll code field
Verify upgrade intro page shows the correct icon
Go to more features page
Enable Per diem
Verify upgrade intro page shows the correct icon

Verify that no errors appear in the JS console

Offline tests

Create a Workspace
Go to Categories > click on any category
Then click on GL code or Payroll code field
Verify upgrade intro page shows the correct icon
Go to more features page
Enable Per diem
Verify upgrade intro page shows the correct icon

QA Steps

Create a Workspace
Go to Categories > click on any category
Then click on GL code or Payroll code field
Verify upgrade intro page shows the correct icon
Go to more features page
Enable Per diem
Verify upgrade intro page shows the correct icon

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…tar icon. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

codecov · 2025-10-10T22:55:15Z

Codecov Report

❌ Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/hooks/useLazyAsset.ts	0.00%	8 Missing ⚠️
src/components/Icon/chunks/illustrations.chunk.ts	0.00%	2 Missing ⚠️

Files with missing lines	Coverage Δ
src/CONST/index.ts	`85.84% <ø> (ø)`
src/components/Icon/IllustrationLoader.ts	`7.69% <ø> (ø)`
src/pages/workspace/upgrade/UpgradeIntro.tsx	`87.50% <100.00%> (+3.62%)`	⬆️
src/components/Icon/chunks/illustrations.chunk.ts	`0.00% <0.00%> (ø)`
src/hooks/useLazyAsset.ts	`41.66% <0.00%> (ø)`

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mountiny · 2025-10-13T10:54:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2025-10-13T10:54:49Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-10-13T10:58:39Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72367.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	https://72367.pr-testing.expensify.com
The build for Desktop was skipped

👀 View the workflow run that generated this build 👀

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2025-10-13T11:20:35Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2025-10-13T11:22:31Z

@QichenZhu sorry for the bump. No review is required here.

mountiny · 2025-10-13T11:25:51Z

mountiny · 2025-10-13T11:28:06Z

@martasudol can you please make sure to go through the other actions and flows to make sure we do not miss any other icons that are used somewhere?

(cherry picked from commit 4e6aa40) (cherry-picked to staging by lakchote)

OSBotify · 2025-10-13T11:39:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-13T12:06:52Z

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.29-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-13T21:01:26Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.29-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-13T21:22:51Z

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.30-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-14T17:37:17Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.30-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

dukenv0307 · 2025-11-27T02:21:11Z

+    const allIconNames = Object.values(CONST.UPGRADE_FEATURE_INTRO_MAPPING)
+        .map((feat) => feat?.icon)
+        .filter((icon) => icon !== undefined);
+    const illustrations = useMemoizedLazyIllustrations(['FolderOpen', 'Tag', 'Coins', 'Rules', 'CompanyCard', 'PerDiem', 'ReportReceipt', 'CarIce']);


Coming from #73865, we need to include Luggage icon here as well

fix: Category - The "GL & Payroll codes" feature shows a fallback ava…

cb31e28

…tar icon. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot Bot assigned Krishna2323 Oct 10, 2025

Krishna2323 mentioned this pull request Oct 10, 2025

[Due for payment 2025-10-21] Category - The "GL & Payroll codes" feature shows a fallback avatar icon #72319

Closed

8 tasks

Merge branch 'Expensify:main' into krishna2323/issue/72319

6bb16f3

remove comment.

e3bf485

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review October 13, 2025 11:20

Krishna2323 requested a review from a team as a code owner October 13, 2025 11:20

melvin-bot Bot requested review from QichenZhu and removed request for a team October 13, 2025 11:20

mountiny changed the title ~~fix: Category - The "GL & Payroll codes" feature shows a fallback avatar icon.~~ [CP Staging] fix: Category - The "GL & Payroll codes" feature shows a fallback avatar icon. Oct 13, 2025

mountiny removed the request for review from QichenZhu October 13, 2025 11:26

mountiny approved these changes Oct 13, 2025

View reviewed changes

mountiny merged commit 4e6aa40 into Expensify:main Oct 13, 2025
23 checks passed

OSBotify pushed a commit that referenced this pull request Oct 13, 2025

Merge pull request #72367 from Krishna2323/krishna2323/issue/72319

3b120e8

(cherry picked from commit 4e6aa40) (cherry-picked to staging by lakchote)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 13, 2025

OSBotify mentioned this pull request Oct 13, 2025

Deploy Checklist: New Expensify 2025-10-10 #72300

Closed

81 tasks

dukenv0307 reviewed Nov 27, 2025

View reviewed changes

Uh oh!

Conversation

Krishna2323 commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mountiny commented Oct 13, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Oct 13, 2025

Uh oh!

github-actions Bot commented Oct 13, 2025

Uh oh!

melvin-bot Bot commented Oct 13, 2025

Uh oh!

Krishna2323 commented Oct 13, 2025

Uh oh!

mountiny commented Oct 13, 2025

Uh oh!

mountiny commented Oct 13, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 14, 2025

Uh oh!

dukenv0307 Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Krishna2323 commented Oct 10, 2025 •

edited

Loading

codecov Bot commented Oct 10, 2025 •

edited

Loading