Skip to content

Fix - Track distance - No map preview when switch from offline to online mode #72364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arosiclair merged 1 commit into from
Oct 13, 2025
Merged

Fix - Track distance - No map preview when switch from offline to online mode #72364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/components/MapView/MapView.website.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, {lazy, Suspense, useEffect, useMemo, useState} from 'react';
import React, {lazy, Suspense, useEffect, useState} from 'react';
import {ErrorBoundary} from 'react-error-boundary';
import FullScreenLoadingIndicator from '@components/FullscreenLoadingIndicator';
import useLocalize from '@hooks/useLocalize';
Expand All @@ -8,6 +8,8 @@ import useThemeStyles from '@hooks/useThemeStyles';
import type {MapViewProps} from './MapViewTypes';
import PendingMapView from './PendingMapView';

const MapViewImpl = lazy(() => import('./MapViewImpl.website'));

function MapView({ref, ...props}: MapViewProps) {
const {isOffline} = useNetwork();
const {translate} = useLocalize();
Expand All @@ -23,13 +25,6 @@ function MapView({ref, ...props}: MapViewProps) {
setErrorResetKey((key) => key + 1);
}, [isOffline, wasOffline]);

// The only way to retry loading the module is to call `React.lazy` again.
const MapViewImpl = useMemo(
() => lazy(() => import('./MapViewImpl.website')),
// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
[errorResetKey],
);

return (
<ErrorBoundary
resetKeys={[errorResetKey]}
Expand Down
Loading