[CP Staging] Expense - Add to unreported expenses issues by lorretheboy · Pull Request #72339 · Expensify/App

lorretheboy · 2025-10-10T15:17:50Z

Explanation of Change

Fixed Issues

$ #72336
$ #72355
$ #72310
$ #69978
PROPOSAL:

Tests

Test 1: Add to report button is hidden behind the keyboard

Precondition:
Create at least 16 unreported expenses.

Launch Expensify app.
Go to workspace chat.
Create a new report in workspace chat.
Tap Add expense > Add unreported expense.
Tap on the search field.
Verify that add to report button will appear above the keyboard.

Test 2: No result screen persists when search field disappears in unreported expense list

Precondition:
Create at least 16 unreported expenses in self DM.

Go to ND
Go to self DM.
Go offline.
Delete a few unreported expenses so that there are less than 16 unreported expenses.
Go to workspace chat.
Create an empty report in workspace chat.
Click Add expense > Add unreported expense.
Click on the search field.
Type anything that will not return result.
Go online.
Verify that After returning online, search field will disappear and all unreported expenses will appear.

Test 3: "Select at least one expense" error is not shown when there is no result

Precondition:
Have at least 16 unreported expenses in self DM.

Go to ND
Go to workspace chat.
Create an empty report in workspace chat.
Click Add expense > Add unreported expense.
Enter anything that will not return any result.
Click Add to report.
Verify that "Select at least one expense" error will be shown when there is no result

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

ANDROID.mov

Android: mWeb Chrome

WEBSITE.ANDROID.mov

iOS: Native

IOS.mov

iOS: mWeb Safari

WEBSITE.IOS.mov

MacOS: Chrome / Safari

WEBSITE.mov

MacOS: Desktop

DESKTOP.mov

melvin-bot · 2025-10-10T15:34:36Z

@brunovjk @mjasikowski One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-10-11T12:36:13Z

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/pages/AddUnreportedExpense.tsx	0.00%	21 Missing ⚠️

Files with missing lines	Coverage Δ
src/pages/AddUnreportedExpense.tsx	`0.00% <0.00%> (ø)`

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lorretheboy · 2025-10-11T13:06:55Z

+
    const filteredTransactions = useMemo(() => {
-        if (!debouncedSearchValue.trim()) {
+        if (!debouncedSearchValue.trim() || !shouldShowTextInput) {


This is to fix the empty list issue

lorretheboy · 2025-10-11T13:07:15Z

+        setErrorMessage('');
+    }, [selectedIds, translate, report, isASAPSubmitBetaEnabled, session?.accountID, session?.email, policy, reportNextStep, policyCategories]);
+
+    const footerContent = useMemo(() => {


This is to fix the error message not showing issue

lorretheboy · 2025-10-11T13:07:34Z

            includeSafeAreaPaddingBottom
            shouldEnablePickerAvoiding={false}
+            shouldEnableMaxHeight
+            enableEdgeToEdgeBottomSafeAreaPadding


This is to fix the button is hidden by keyboard issue

brunovjk · 2025-10-11T16:05:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

72339_android_native.mov

Android: mWeb Chrome

iOS: HybridApp

72339_ios_native.mov

iOS: mWeb Safari

72339_ios_web.mov

MacOS: Chrome / Safari

72339_web_chrome.mov

MacOS: Desktop

72339_web_desktop.mov

brunovjk · 2025-10-11T17:08:53Z

+                    />
+                )}
+                <Button
+                    success


@lorretheboy, to clarify, why did we create this button, instead of using the ScreenWrapper one as before? Thank you.

@brunovjk if so there is no error message on empty state. This is also one of the current pattern in codebase

App/src/pages/iou/SplitExpensePage.tsx

Line 266 in c8684e2

const footerContent = useMemo(() => {

brunovjk · 2025-10-11T17:10:44Z

The space between the button and the alert is small:

lorretheboy · 2025-10-11T18:51:48Z

The space between the button and the alert is small:

I have fixed this by adding addBottomSafeAreaPadding = true to SelectionList, btw I think this issue exists before my PR since it doesn't have this prop from beginning @brunovjk

https://github.com/Expensify/App/pull/72339/files#diff-572c59dbb9931b341bde48497df9a583581a4514c5066c1721885cf3f644117eR311

brunovjk

LGTM

mjasikowski · 2025-10-13T08:17:12Z

@JS00001 all yours

OSBotify · 2025-10-13T09:53:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[CP Staging] Expense - Add to unreported expenses issues (cherry picked from commit 45472c3) (cherry-picked to staging by mountiny)

OSBotify · 2025-10-13T10:40:49Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.29-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-13T21:01:23Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.29-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-13T21:22:36Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.30-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-14T17:37:02Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.30-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: add button is hidden

b828e80

melvin-bot Bot assigned lorretheboy Oct 10, 2025

lorretheboy changed the title ~~fix: add button is hidden~~ Expense - Add to report button is hidden behind the keyboard Oct 10, 2025

JS00001 self-requested a review October 10, 2025 15:21

fix: safari

2a8169b

lorretheboy marked this pull request as ready for review October 10, 2025 15:34

lorretheboy requested a review from a team as a code owner October 10, 2025 15:34

melvin-bot Bot requested review from brunovjk and mjasikowski and removed request for a team October 10, 2025 15:34

lorretheboy mentioned this pull request Oct 10, 2025

[Due for payment 2025-10-21] Expense - Add to report button is hidden behind the keyboard #72336

Closed

8 tasks

lorretheboy added 2 commits October 11, 2025 19:58

Merge branch 'main' of https://github.com/Expensify/App into fix/72336

eabdfd0

fix: err message

ecac3a0

fix: empty search

c2c8fe6

lorretheboy changed the title ~~Expense - Add to report button is hidden behind the keyboard~~ Expense - Add to unreported expenses issues Oct 11, 2025

lorretheboy commented Oct 11, 2025

View reviewed changes

brunovjk reviewed Oct 11, 2025

View reviewed changes

fix: add addBottomSafeAreaPadding

a78f3ce

brunovjk approved these changes Oct 12, 2025

View reviewed changes

mjasikowski approved these changes Oct 13, 2025

View reviewed changes

lakchote changed the title ~~Expense - Add to unreported expenses issues~~ [CP Staging] Expense - Add to unreported expenses issues Oct 13, 2025

lakchote removed the request for review from JS00001 October 13, 2025 09:39

lakchote self-requested a review October 13, 2025 09:39

lakchote approved these changes Oct 13, 2025

View reviewed changes

lakchote merged commit 45472c3 into Expensify:main Oct 13, 2025
23 checks passed

OSBotify pushed a commit that referenced this pull request Oct 13, 2025

Merge pull request #72339 from lorretheboy/fix/72336

23a48ad

[CP Staging] Expense - Add to unreported expenses issues (cherry picked from commit 45472c3) (cherry-picked to staging by mountiny)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 13, 2025

OSBotify mentioned this pull request Oct 13, 2025

Deploy Checklist: New Expensify 2025-10-10 #72300

Closed

81 tasks

brunovjk mentioned this pull request Oct 13, 2025

[Due for payment 2025-10-21] Expense - "Select at least one expense" error is not shown when there is no result #72310

Closed

8 tasks

Christinadobrzyn mentioned this pull request Oct 14, 2025

[Due for payment 2025-10-21] Expense - No result screen persists when search field disappears in unreported expense list #72355

Closed

8 tasks

melvin-bot Bot mentioned this pull request Oct 14, 2025

[Due for payment 2025-10-21] Add search input field to top of "Add unreported expense" screen #69978

Closed

Uh oh!

Conversation

lorretheboy commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 10, 2025

Uh oh!

codecov Bot commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lorretheboy Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

lorretheboy Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

lorretheboy Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

brunovjk commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

brunovjk Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

lorretheboy Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

brunovjk commented Oct 11, 2025

Uh oh!

lorretheboy commented Oct 11, 2025

Uh oh!

brunovjk left a comment

Choose a reason for hiding this comment

Uh oh!

mjasikowski commented Oct 13, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lorretheboy commented Oct 10, 2025 •

edited

Loading

codecov Bot commented Oct 11, 2025 •

edited

Loading

brunovjk commented Oct 11, 2025 •

edited

Loading