Skip to content

[Search] Clear selections when sorting to prevent stale selection state #72334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cead22 merged 8 commits into from
Nov 5, 2025
Merged

[Search] Clear selections when sorting to prevent stale selection state #72334

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c3ef455
[Search] Clear selections when sorting to prevent stale selection state
abzokhattab Oct 10, 2025
b10e470
Merge remote-tracking branch 'origin/main' into fix/70594-clear-selec…
abzokhattab Oct 27, 2025
35eafa9
cleaning up comments
abzokhattab Oct 27, 2025
8c4cd49
Merge remote-tracking branch 'origin/main' into fix/70594-clear-selec…
abzokhattab Oct 31, 2025
129c275
adding setSelectedTransactions([]) back to clearSelectedTransactions
abzokhattab Oct 31, 2025
a757586
reverting setSearchContextData changes
abzokhattab Oct 31, 2025
efd6a1e
minor edit
abzokhattab Oct 31, 2025
4c7bb70
minor edit
abzokhattab Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/Search/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,7 @@

openSearchReport(reportID, backTo);
},
[isMobileSelectionModeEnabled, type, toggleTransaction, hash, queryJSON, handleSearch, searchKey, markReportIDAsExpense],

Check warning on line 716 in src/components/Search/index.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

React Hook useCallback has an unnecessary dependency: 'type'. Either exclude it or remove the dependency array

Check warning on line 716 in src/components/Search/index.tsx

View workflow job for this annotation

GitHub Actions / ESLint check 

React Hook useCallback has an unnecessary dependency: 'type'. Either exclude it or remove the dependency array
);

const currentColumns = useMemo(() => {
Expand Down Expand Up @@ -892,6 +892,7 @@
}

const onSortPress = (column: SearchColumnType, order: SortOrder) => {
clearSelectedTransactions();
const newQuery = buildSearchQueryString({...queryJSON, sortBy: column, sortOrder: order});
onSortPressedCallback?.();
navigation.setParams({q: newQuery});
Expand Down
Loading