Skip to content

fix: show offline indicator in RHP in wide screen part 3 #72296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoisl merged 8 commits into from
Oct 20, 2025
Merged

fix: show offline indicator in RHP in wide screen part 3 #72296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e949386
fix: show offline indicator in RHP in wide screen part 3
nkdengineer Oct 10, 2025
297d527
Merge branch 'main' into fix/69208-3
nkdengineer Oct 13, 2025
b4ddfbc
Add offline indicator in validate code page
nkdengineer Oct 13, 2025
361e19f
fix ts
nkdengineer Oct 15, 2025
0ee779f
remove useless code
nkdengineer Oct 15, 2025
051f87d
Merge branch 'main' into fix/69208-3
nkdengineer Oct 15, 2025
38d2e45
fix logic show offline indicator
nkdengineer Oct 15, 2025
6571836
Merge branch 'main' into fix/69208-3
nkdengineer Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/pages/MissingPersonalDetails/MissingPersonalDetailsContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ function MissingPersonalDetailsContent({privatePersonalDetails, draftValues}: Mi
includeSafeAreaPaddingBottom={false}
shouldEnableMaxHeight
testID={MissingPersonalDetailsContent.displayName}
shouldShowOfflineIndicatorInWideScreen={!!isValidateCodeActionModalVisible}
>
<HeaderWithBackButton
title={translate('workspace.expensifyCard.addShippingDetails')}
Expand Down
1 change: 1 addition & 0 deletions src/pages/ReimbursementAccount/NonUSD/BeneficialOwnerInfo/BeneficialOwnerInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,7 @@ function BeneficialOwnerInfo({onBackButtonPress, onSubmit, stepNames}: Beneficia
handleBackButtonPress={handleBackButtonPress}
headerTitle={translate('ownershipInfoStep.ownerInfo')}
stepNames={stepNames}
shouldShowOfflineIndicatorInWideScreen={currentSubStep === SUBSTEP.BENEFICIAL_OWNERS_LIST}
startStepIndex={3}
>
{currentSubStep === SUBSTEP.IS_USER_BENEFICIAL_OWNER && (
Expand Down
1 change: 1 addition & 0 deletions src/pages/ReimbursementAccount/USD/BeneficialOwnerInfo/BeneficialOwnersStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ function BeneficialOwnersStep({onBackButtonPress}: BeneficialOwnersStepProps) {
shouldEnableMaxHeight
headerTitle={translate('beneficialOwnerInfoStep.companyOwner')}
handleBackButtonPress={handleBackButtonPress}
shouldShowOfflineIndicatorInWideScreen={currentUBOSubStep === SUBSTEP.UBOS_LIST}
startStepIndex={5}
stepNames={CONST.BANK_ACCOUNT.STEP_NAMES}
>
Expand Down
1 change: 1 addition & 0 deletions src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ function VerifiedBankAccountFlowEntryPoint({
<ScreenWrapper
includeSafeAreaPaddingBottom={false}
testID={VerifiedBankAccountFlowEntryPoint.displayName}
shouldShowOfflineIndicatorInWideScreen={!!isValidateCodeActionModalVisible}
>
<HeaderWithBackButton
title={translate('bankAccount.addBankAccount')}
Expand Down
1 change: 1 addition & 0 deletions src/pages/Travel/TravelUpgrade.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ function TravelUpgrade({route}: TravelUpgradeProps) {
shouldShowOfflineIndicator
testID={TravelUpgrade.displayName}
offlineIndicatorStyle={styles.mtAuto}
shouldShowOfflineIndicatorInWideScreen={!isUpgraded}
>
<HeaderWithBackButton
title={translate('common.upgrade')}
Expand Down
1 change: 1 addition & 0 deletions src/pages/iou/request/step/IOURequestStepUpgrade.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ function IOURequestStepUpgrade({
shouldShowOfflineIndicator
testID="workspaceUpgradePage"
offlineIndicatorStyle={styles.mtAuto}
shouldShowOfflineIndicatorInWideScreen={!isUpgraded && !showConfirmationForm}
>
{(!!isUpgraded || !showConfirmationForm) && (
<HeaderWithBackButton
Expand Down
1 change: 1 addition & 0 deletions src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ function NewContactMethodPage({route}: NewContactMethodPageProps) {
onEntryTransitionEnd={() => loginInputRef.current?.focus()}
includeSafeAreaPaddingBottom
shouldEnableMaxHeight
shouldShowOfflineIndicatorInWideScreen
testID={NewContactMethodPage.displayName}
>
<DelegateNoAccessWrapper accessDeniedVariants={[CONST.DELEGATE.DENIED_ACCESS_VARIANTS.DELEGATE]}>
Expand Down
1 change: 1 addition & 0 deletions src/pages/settings/Security/MergeAccounts/AccountValidatePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ function AccountValidatePage() {
shouldEnableMaxHeight
includeSafeAreaPaddingBottom
testID={AccountValidatePage.displayName}
shouldShowOfflineIndicatorInWideScreen
>
<HeaderWithBackButton
title={translate('mergeAccountsPage.mergeAccount')}
Expand Down
1 change: 1 addition & 0 deletions src/pages/settings/Wallet/ReportCardLostPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ function ReportCardLostPage({
<ScreenWrapper
includeSafeAreaPaddingBottom
testID={ReportCardLostPage.displayName}
shouldShowOfflineIndicatorInWideScreen={!!isValidateCodeActionModalVisible}
>
<HeaderWithBackButton
title={newCardID ? translate('common.success') : translate('reportCardLostOrDamaged.screenTitle')}
Expand Down
1 change: 1 addition & 0 deletions src/pages/workspace/categories/ImportedCategoriesPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ function ImportedCategoriesPage({route}: ImportedCategoriesPageProps) {
<ScreenWrapper
testID={ImportedCategoriesPage.displayName}
enableEdgeToEdgeBottomSafeAreaPadding
shouldShowOfflineIndicatorInWideScreen
>
<HeaderWithBackButton
title={translate('workspace.categories.importCategories')}
Expand Down
1 change: 1 addition & 0 deletions src/pages/workspace/downgrade/WorkspaceDowngradePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ function WorkspaceDowngradePage({route}: WorkspaceDowngradePageProps) {
shouldShowOfflineIndicator
testID="workspaceDowngradePage"
offlineIndicatorStyle={styles.mtAuto}
shouldShowOfflineIndicatorInWideScreen
Comment thread
nkdengineer marked this conversation as resolved.
>
<HeaderWithBackButton
title={translate('common.downgradeWorkspace')}
Expand Down
1 change: 1 addition & 0 deletions src/pages/workspace/expensifyCard/issueNew/ConfirmationStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ function ConfirmationStep({policyID, backTo, stepNames, startStepIndex}: Confirm
startStepIndex={startStepIndex}
stepNames={stepNames}
enableEdgeToEdgeBottomSafeAreaPadding
shouldShowOfflineIndicatorInWideScreen
>
<ScrollView
style={styles.pt0}
Expand Down
1 change: 1 addition & 0 deletions src/pages/workspace/perDiem/ImportedPerDiemPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ function ImportedPerDiemPage({route}: ImportedPerDiemPageProps) {
<ScreenWrapper
testID={ImportedPerDiemPage.displayName}
enableEdgeToEdgeBottomSafeAreaPadding
shouldShowOfflineIndicatorInWideScreen
>
<HeaderWithBackButton
title={translate('workspace.perDiem.importPerDiemRates')}
Expand Down
1 change: 1 addition & 0 deletions src/pages/workspace/tags/ImportedMultiLevelTagsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ function ImportedMultiLevelTagsPage({route}: ImportedMultiLevelTagsPageProps) {
<ScreenWrapper
testID={ImportedMultiLevelTagsPage.displayName}
enableEdgeToEdgeBottomSafeAreaPadding
shouldShowOfflineIndicatorInWideScreen
>
<HeaderWithBackButton
title={translate('workspace.tags.importTags')}
Expand Down
1 change: 1 addition & 0 deletions src/pages/workspace/tags/ImportedTagsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ function ImportedTagsPage({route}: ImportedTagsPageProps) {
<ScreenWrapper
testID={ImportedTagsPage.displayName}
enableEdgeToEdgeBottomSafeAreaPadding
shouldShowOfflineIndicatorInWideScreen
>
<HeaderWithBackButton
title={translate('workspace.tags.importTags')}
Expand Down
1 change: 1 addition & 0 deletions src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ function WorkspaceUpgradePage({route}: WorkspaceUpgradePageProps) {
shouldShowOfflineIndicator
testID="workspaceUpgradePage"
offlineIndicatorStyle={styles.mtAuto}
shouldShowOfflineIndicatorInWideScreen={!isUpgraded}
>
<HeaderWithBackButton
title={translate('common.upgrade')}
Expand Down
Loading