Skip to content

Revert "fix: Tax is not set to default for distance expense." #72276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarioExpensify merged 1 commit into from
Oct 10, 2025
Merged

Revert "fix: Tax is not set to default for distance expense." #72276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 1 addition & 20 deletions src/components/MoneyRequestConfirmationList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ import {
getTaxValue,
hasMissingSmartscanFields,
hasRoute as hasRouteUtil,
isCustomUnitRateIDForP2P as isCustomUnitRateIDForP2PUtil,
isMerchantMissing,
isScanRequest as isScanRequestUtil,
} from '@libs/TransactionUtils';
Expand Down Expand Up @@ -293,7 +292,6 @@ function MoneyRequestConfirmationList({
const isTypeInvoice = iouType === CONST.IOU.TYPE.INVOICE;
const isScanRequest = useMemo(() => isScanRequestUtil(transaction), [transaction]);
const isCreateExpenseFlow = !!transaction?.isFromGlobalCreate && !isPerDiemRequest;
const isCustomUnitRateIDForP2P = isCustomUnitRateIDForP2PUtil(transaction);

const transactionID = transaction?.transactionID;
const customUnitRateID = getRateID(transaction);
Expand Down Expand Up @@ -452,26 +450,9 @@ function MoneyRequestConfirmationList({
return;
}

if (isCustomUnitRateIDForP2P && DistanceRequestUtils.getDefaultMileageRate(policy)) {
const defaultMileageRatePolicy = DistanceRequestUtils.getDefaultMileageRate(policy);
setCustomUnitRateID(transactionID, defaultMileageRatePolicy?.customUnitRateID);
return;
}

// If none of the above conditions are met, display the rate error
setFormError(errorKey);
}, [
isDistanceRequest,
isPolicyExpenseChat,
transactionID,
mileageRate,
customUnitRateID,
policy,
isMovingTransactionFromTrackExpense,
setFormError,
clearFormErrors,
isCustomUnitRateIDForP2P,
]);
}, [isDistanceRequest, isPolicyExpenseChat, transactionID, mileageRate, customUnitRateID, policy, isMovingTransactionFromTrackExpense, setFormError, clearFormErrors]);

@github-actions github-actions Bot Oct 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ PERF-6 (docs)

Passing entire objects as dependencies causes hooks to re-execute whenever any property changes, even unrelated ones. Specifying individual properties creates more granular dependency tracking, reducing unnecessary hook executions and improving performance predictability.

Replace the mileageRate dependency with its specific properties that are actually used in the effect:

}, [isDistanceRequest, isPolicyExpenseChat, transactionID, mileageRate.rate, mileageRate.unit, customUnitRateID, policy, isMovingTransactionFromTrackExpense, setFormError, clearFormErrors]);


const routeError = Object.values(transaction?.errorFields?.route ?? {}).at(0);
const isFirstUpdatedDistanceAmount = useRef(false);
Expand Down
Loading