fix: self-dm not present during expense creation by pasyukevich · Pull Request #72222 · Expensify/App

pasyukevich · 2025-10-09T14:17:54Z

Explanation of Change

Fixed Issues

$ #72152 (comment)
PROPOSAL:

Tests

Open the Expensify app.
Sign up with a new account.
Complete onboarding modal selecting "Track and budget expenses" option.
Once on "Inbox", tap on FAB and select "Create Expense"
Add any amount and tap on "Next"
Note that Self DM is present on recipient list.

📱 Mobile

1️⃣ Verify negative expense can be created without a workspace only to DM

(account without workspaces needed)

Open the Create Expense screen.
Enter an amount and press Flip.
Verify that a minus sign appears before the currency.
Press Next.
Verify that you can proceed only with the DM.

2️⃣ Verify negative value functionality

(workspace required before running this test)

Open the Create Expense screen.
Enter an amount and press Flip.
Verify that a minus sign appears before the currency.
Press Next.
Verify that the selected workspace is the receiver.
Confirm the amount is negative on the current screen and submit the expense.
Open the newly created expense.
Verify that the amount has a minus sign.
Tap the amount and confirm that the minus sign appears before the currency.
Enter a new amount, press Flip, and submit.
Verify that the updated value is correct.
Verify that the update confirmation message is correct.

3️⃣ Verify negative value option is not hidden for DM

Open DM.
Open the Create Expense screen.
Verify that the Flip button is not hidden.

💻 Desktop

⚠️ Note: No Flip button — negative value input is manual using -.

1️⃣ Verify negative expense can be created without a workspace

(account without workspaces needed)

Open the Create Expense screen.
Place the cursor at the start of the amount field and enter - followed by a number.
Verify that a minus sign appears before the currency.
Press Next.
Verify that you can proceed only to DM.

2️⃣ Verify negative value option is not hidden for DM

Open DM.
Open the Create Expense screen.
Attempt to enter -.
Verify that:
- The minus sign is added

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as above
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native-converted.webm

Android: mWeb Chrome

adroid-web-converted.webm

iOS: Native

ios-native-converted.mov

iOS: mWeb Safari

ios-web-converted.mov

MacOS: Chrome / Safari

desktop-web-converted.mov

MacOS: Desktop

desktop-native-converted.mov

codecov · 2025-10-09T14:29:03Z

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...s/iou/request/MoneyRequestParticipantsSelector.tsx	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #72222      +/-   ##
==========================================
+ Coverage   28.11%   35.07%   +6.95%     
==========================================
  Files        3317     3317              
  Lines      108746   108807      +61     
  Branches    34675    34734      +59     
==========================================
+ Hits        30577    38163    +7586     
+ Misses      78009    70460    -7549     
- Partials      160      184      +24

Files with missing lines	Coverage Δ
...s/iou/request/MoneyRequestParticipantsSelector.tsx	`0.00% <0.00%> (ø)`

... and 328 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-09T15:55:30Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-10-09T16:24:43Z

@situchan
Oh
Sorry
I suppose it's my PR
Since it's a regression fix for the PR, which I reviewed

ZhenjaHorbach · 2025-10-09T16:35:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2025-10-09.19.13.03.mov

Android: mWeb Chrome

2025-10-09.19.13.03.mov

iOS: HybridApp

iOS: mWeb Safari

2025-10-09.18.51.05.mov

MacOS: Chrome / Safari

2025-10-09.18.44.39.mov

MacOS: Desktop

2025-10-09.18.44.39.mov

ZhenjaHorbach · 2025-10-09T17:26:21Z

LGTM
And Spell check issue is not related to this PR

situchan · 2025-10-09T17:27:08Z

iOS:

Screen.Recording.2025-10-09.at.11.24.59.PM.mov

luacmartins

LGTM

lakchote · 2025-10-09T19:43:25Z

I think we can merge this one, no need to hold as the other CP run won't affect this flow (#72252 (comment))

melvin-bot · 2025-10-09T19:44:21Z

@lakchote looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

lakchote · 2025-10-09T19:44:44Z

Not an emergency, spell check was failing already
#72222 (comment)

OSBotify · 2025-10-09T19:55:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…sent fix: self-dm not present during expense creation (cherry picked from commit 6823a58) (cherry-picked to staging by lakchote)

OSBotify · 2025-10-09T20:44:12Z

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.28-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-10T10:52:28Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.28-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-10T11:13:52Z

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.29-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-13T21:00:50Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.29-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: self-dm not present during expense creation

67a489f

melvin-bot Bot assigned pasyukevich Oct 9, 2025

pasyukevich marked this pull request as ready for review October 9, 2025 15:55

pasyukevich requested a review from a team as a code owner October 9, 2025 15:55

melvin-bot Bot requested review from situchan and removed request for a team October 9, 2025 15:55

mountiny requested review from ZhenjaHorbach and removed request for situchan October 9, 2025 16:34

ZhenjaHorbach approved these changes Oct 9, 2025

View reviewed changes

melvin-bot Bot requested a review from lakchote October 9, 2025 17:26

luacmartins approved these changes Oct 9, 2025

View reviewed changes

luacmartins changed the title ~~fix: self-dm not present during expense creation~~ [HOLD regression] fix: self-dm not present during expense creation Oct 9, 2025

lakchote approved these changes Oct 9, 2025

View reviewed changes

lakchote changed the title ~~[HOLD regression] fix: self-dm not present during expense creation~~ fix: self-dm not present during expense creation Oct 9, 2025

lakchote merged commit 6823a58 into Expensify:main Oct 9, 2025
25 of 31 checks passed

melvin-bot Bot added the Emergency label Oct 9, 2025

lakchote removed the Emergency label Oct 9, 2025

OSBotify pushed a commit that referenced this pull request Oct 9, 2025

Merge pull request #72222 from callstack-internal/fix/self-dm-not-pre…

8a75a45

…sent fix: self-dm not present during expense creation (cherry picked from commit 6823a58) (cherry-picked to staging by lakchote)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 9, 2025

OSBotify mentioned this pull request Oct 9, 2025

Deploy Checklist: New Expensify 2025-10-08 #72135

Closed

62 tasks

melvin-bot Bot mentioned this pull request Oct 10, 2025

[Due for payment 2025-10-17] Expense - Self DM is not present on recipient list during expense creation. #72152

Closed

8 tasks

Uh oh!

Conversation

pasyukevich commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

📱 Mobile

1️⃣ Verify negative expense can be created without a workspace only to DM

2️⃣ Verify negative value functionality

3️⃣ Verify negative value option is not hidden for DM

💻 Desktop

1️⃣ Verify negative expense can be created without a workspace

2️⃣ Verify negative value option is not hidden for DM

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 9, 2025

Uh oh!

ZhenjaHorbach commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

situchan commented Oct 9, 2025

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

lakchote commented Oct 9, 2025

Uh oh!

Uh oh!

melvin-bot Bot commented Oct 9, 2025

Uh oh!

lakchote commented Oct 9, 2025

Uh oh!

OSBotify commented Oct 9, 2025

Uh oh!

OSBotify commented Oct 9, 2025

Uh oh!

OSBotify commented Oct 10, 2025

Uh oh!

OSBotify commented Oct 10, 2025

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pasyukevich commented Oct 9, 2025 •

edited

Loading

codecov Bot commented Oct 9, 2025 •

edited

Loading

ZhenjaHorbach commented Oct 9, 2025 •

edited

Loading

ZhenjaHorbach commented Oct 9, 2025 •

edited

Loading

ZhenjaHorbach commented Oct 9, 2025 •

edited

Loading