Fix/70820/follow up by Eskalifer1 · Pull Request #72200 · Expensify/App

Eskalifer1 · 2025-10-09T11:43:56Z

Explanation of Change

Follow up for #69781

We pass stable function to ensure that the event listener always calls the latest version of the onClose function without being affected by stale closures. By using a stable handler that references a mutable ref, we keep the listener constant while allowing its behavior to stay up to date.

Fixed Issues

$#69781
PROPOSAL:

Tests

Precondition: Have a Workspace with CAD currency

Test 1:

Go to Workspace setting - Workflows - add bank account
Click on Connect Manually and reach step 2
Fill the fields with valid data except for the Bank Region selector
Click on Bank Region selector and click on the back arrow in the corner
Make sure you get error only for this field(Bank Region)

Test 2:

Go to Workspace setting - Workflows - add bank account
Click on Connect Manually and reach step 2
Fill the fields with invalid data except for the Bank Region selector
Click on Bank Region selector and click on the back arrow in the corner
Make sure you get errors for all invalid fields
Change all field values from invalid to valid
Click on Bank Region selector and click on the back arrow in the corner
Make sure you get error only for this field(Bank Region)

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

69781-android-native.1.mp4

Android: mWeb Chrome

69781-android-web.mp4

iOS: Native

69781-ios-native.1.mp4

iOS: mWeb Safari

69781-ios-web.1.mp4

MacOS: Chrome / Safari

69781-web.1.mp4

MacOS: Desktop

69781-desktop.1.mp4

melvin-bot · 2025-10-09T11:44:03Z

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-10-09T11:55:36Z

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/Modal/index.tsx	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #72200      +/-   ##
==========================================
+ Coverage   35.13%   35.52%   +0.38%     
==========================================
  Files        3307     3330      +23     
  Lines      108351   109440    +1089     
  Branches    34619    35002     +383     
==========================================
+ Hits        38069    38876     +807     
- Misses      70096    70383     +287     
+ Partials      186      181       -5

Files with missing lines	Coverage Δ
src/components/Modal/index.tsx	`0.00% <0.00%> (ø)`

... and 340 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Eskalifer1 · 2025-10-10T12:02:25Z

Updated PR!

linhvovan29546 · 2025-10-10T13:02:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-12.at.10.56.07.mov

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2025-10-12.at.10.48.05.mov

iOS: mWeb Safari

Screen.Recording.2025-10-12.at.10.50.18.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-12.at.10.19.53.mov

MacOS: Desktop

Screen.Recording.2025-10-12.at.11.17.34.mov

puneetlath · 2025-10-14T21:46:33Z

        // eslint-disable-next-line react-hooks/exhaustive-deps
    }, [rest.onClose]);

+    // We need to pass stable version of the function to properly work in eventListener


Can you update this comment to explain "why" this is. Generally the rule of thumb for comments is "why" not "what". This comment is currently telling us what it is doing, but not really why. Why is this necessary for the function to work properly in the eventListener?

Updated PR!

puneetlath

This is great, thanks!

OSBotify · 2025-10-14T22:20:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-15T23:14:20Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.2.32-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-16T23:20:47Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.32-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

follow-up:69781: added stable function call is eventListener

a7f7864

Eskalifer1 requested a review from a team as a code owner October 9, 2025 11:43

melvin-bot Bot assigned Eskalifer1 Oct 9, 2025

melvin-bot Bot requested review from linhvovan29546 and removed request for a team October 9, 2025 11:44

Eskalifer1 mentioned this pull request Oct 9, 2025

fix: execute onBlur with correct values on close modal inside form #70820

Merged

51 tasks

linhvovan29546 reviewed Oct 10, 2025

View reviewed changes

Comment thread src/components/Modal/index.tsx

linhvovan29546 suggested changes Oct 10, 2025

View reviewed changes

Comment thread src/components/Modal/index.tsx Outdated

chore: C+ comments

765080f

linhvovan29546 approved these changes Oct 12, 2025

View reviewed changes

melvin-bot Bot requested a review from puneetlath October 12, 2025 04:59

Eskalifer1 mentioned this pull request Oct 14, 2025

User navigates to workspace settings while entering expense details after importing categories #72522

Closed

8 tasks

puneetlath requested changes Oct 14, 2025

View reviewed changes

chore: added comment

17b24da

puneetlath approved these changes Oct 14, 2025

View reviewed changes

puneetlath merged commit af76aaf into Expensify:main Oct 14, 2025
22 checks passed

OSBotify mentioned this pull request Oct 15, 2025

Deploy Checklist: New Expensify 2025-10-15 #72723

Closed

52 tasks

melvin-bot Bot mentioned this pull request Oct 16, 2025

[Due for payment 2025-10-23] [Due for payment 2025-10-17] [$250] Bank Account - Back button in selectors triggers error message in other fields #69781

Closed

8 tasks

linhvovan29546 mentioned this pull request Oct 21, 2025

35756 close emoji when navigation back #38693

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/70820/follow up#72200

Fix/70820/follow up#72200
puneetlath merged 3 commits into
Expensify:mainfrom
Eskalifer1:fix/70820/follow-up

Eskalifer1 commented Oct 9, 2025

Uh oh!

melvin-bot Bot commented Oct 9, 2025

Uh oh!

codecov Bot commented Oct 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Eskalifer1 commented Oct 10, 2025

Uh oh!

linhvovan29546 commented Oct 10, 2025 •

edited

Loading

Uh oh!

puneetlath Oct 14, 2025

Uh oh!

Eskalifer1 Oct 14, 2025

Uh oh!

puneetlath left a comment

Uh oh!

Uh oh!

OSBotify commented Oct 14, 2025

Uh oh!

OSBotify commented Oct 15, 2025

Uh oh!

OSBotify commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Eskalifer1 commented Oct 9, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 9, 2025

Uh oh!

codecov Bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Eskalifer1 commented Oct 10, 2025

Uh oh!

linhvovan29546 commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

puneetlath Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Eskalifer1 Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

puneetlath left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 14, 2025

Uh oh!

OSBotify commented Oct 15, 2025

Uh oh!

OSBotify commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Oct 9, 2025 •

edited

Loading

linhvovan29546 commented Oct 10, 2025 •

edited

Loading