fix: migrate scheduledCall to use parameter instead of split keys#72164
Conversation
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| <Text style={[styles.textStrong, styles.colorMuted]}> | ||
| {DateUtils.formatInTimeZoneWithFallback(scheduleCallDraft.date, userTimezone, CONST.DATE.MONTH_DAY_YEAR_FORMAT)} | ||
| </Text> | ||
| <Text style={[styles.mb5]}> |
There was a problem hiding this comment.
| <Text style={[styles.mb5]}> | |
| <View style={[styles.mb5]}> |
There was a problem hiding this comment.
@dukenv0307 FYI, if we replace the Text tag with View tag it will cause another bug which is the text will not be displayed on native
Context/Example issue: #71643
RCA/Solution: #71643 (comment)
Please let me know wdyt?. Thanks
There was a problem hiding this comment.
Oh I see. Lemme test it
Reviewer Checklist
Screenshots/Videos |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/amyevans in version: 9.2.30-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.30-6 🚀
|






Explanation of Change
Fix/Migrate
scheduledCall.book.slotsto use parameter instead of split keys stringFixed Issues
$ #72056
PROPOSAL: #72056 (comment)
Tests
Prerequisite: Don't use a
+prefix in the email address#adminsroom if any / or create new oneSchedule callbuttonAvailable times fordisplay the correct text along with the date using the bold formatOffline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-10-09.at.13.55.01.mov
Android: mWeb Chrome
Screen.Recording.2025-10-09.at.13.57.45.mov
iOS: Native
Screen.Recording.2025-10-09.at.14.07.13.mov
iOS: mWeb Safari
Screen.Recording.2025-10-09.at.14.01.17.mov
MacOS: Chrome / Safari
Screen.Recording.2025-10-09.at.13.17.52.mov
MacOS: Desktop
Screen.Recording.2025-10-09.at.13.23.32.mov