A horizontal thumbnail is displayed for a vertical video attachment by lorretheboy · Pull Request #72023 · Expensify/App

lorretheboy · 2025-10-07T16:19:20Z

Explanation of Change

Fixed Issues

$ #71072
PROPOSAL: #71072 (comment)

Tests

Navigate to ND
Open any chat
Click on the + button next to the composer
Click on Add attachment
Select a vertically oriented video
Click on Send
The video should appear in the chat, with a vertical thumbnail (i.e. height greater than width).

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

https://drive.google.com/file/d/1zTqw2Sii1ZyhMsqDh4_BUu8cWDKNeilQ/view?usp=sharing

Android: mWeb Chrome

WEBSITE.ANDROID.mov

iOS: Native

https://drive.google.com/file/d/1WyqOz3finys7KShN1RGOtpK6fq_Y2H0Y/view?usp=sharing

iOS: mWeb Safari

WEBSITE.IOS.mov

MacOS: Chrome / Safari

WEBSITE.mov

MacOS: Desktop

DESKTOP_.mov

lorretheboy · 2025-10-07T16:48:40Z

Pipelines are failing in main. We just need wait main to fix them

Besides, I'm having problems with native build (ios+android). I will upload the recording for them as soon as possible

melvin-bot · 2025-10-07T16:57:22Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-10-07T17:05:05Z

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/VideoPlayerPreview/index.tsx	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #72023      +/-   ##
==========================================
- Coverage   35.21%   35.07%   -0.14%     
==========================================
  Files        3297     3318      +21     
  Lines      108175   108880     +705     
  Branches    34579    34773     +194     
==========================================
+ Hits        38089    38194     +105     
- Misses      69898    70501     +603     
+ Partials      188      185       -3

Files with missing lines	Coverage Δ
src/components/VideoPlayerPreview/index.tsx	`11.11% <0.00%> (-3.18%)`	⬇️

... and 219 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ishpaul777 · 2025-10-07T18:45:13Z

    const navigation = useNavigation();

+    useEffect(() => {
+        if (typeof videoUrl !== 'string' || !videoUrl || (getPlatform() !== CONST.PLATFORM.WEB && getPlatform() !== CONST.PLATFORM.DESKTOP)) {


NAB

Suggested change

if (typeof videoUrl !== 'string' || !videoUrl || (getPlatform() !== CONST.PLATFORM.WEB && getPlatform() !== CONST.PLATFORM.DESKTOP)) {

const platform = getPlatform();

const isWebOrDesktop = platform === CONST.PLATFORM.WEB || platform === CONST.PLATFORM.DESKTOP;

if (typeof videoUrl !== 'string' || !videoUrl || !isWebOrDesktop)) {

ishpaul777 · 2025-10-07T19:42:39Z

@lorretheboy it seems to be not working on android, can you please check that?

lorretheboy · 2025-10-07T19:44:10Z

@ishpaul777 Hi lemme check again tmr. I am having a prblem related to build the native app.

For the issue above, i think we just need to remove the platform check to solve the issue

lorretheboy · 2025-10-08T15:58:57Z

Hmm as far as I check, on native platforms, it only happens when we pick the file using Choose file but not Choose from gallery (this is because Choose file are not using image picker lib to pick video)

I have updated the code to fix it. However, we have no way to access the image before getting data back from BE (native platforms don't support to create DOM element like web or desktop), so that the dimensions will be wrong in loading state (it uses default ratio). It will be correct once API call is done @ishpaul777

ishpaul777 · 2025-10-08T18:54:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-09.at.1.20.10.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-10-09.at.1.33.26.AM.mov

iOS: HybridApp

Screen.Recording.2025-10-09.at.12.38.41.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-10-08.at.12.37.44.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-08.at.12.35.09.AM.mov

MacOS: Desktop

Screen.Recording.2025-10-09.at.2.33.24.AM.mov

ishpaul777 · 2025-10-08T21:10:10Z

i have updated the code to fix it. However, we have no way to access the image before getting data back from BE (native platforms don't support to create DOM element like web or desktop), so that the dimensions will be wrong in loading state (it uses default ratio). It will be correct once API call is done @ishpaul777

Thanks for investigation! If that’s a platform limitation, then it’s ok. The current approach makes sense given the constraints.

amyevans

One quick request, otherwise looks good!

lorretheboy · 2025-10-09T18:24:11Z

@amyevans I have added code comment for that. Thanks

amyevans · 2025-10-09T18:25:10Z

Thank you!

OSBotify · 2025-10-09T18:48:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-10T11:13:10Z

🚀 Deployed to staging by https://github.com/amyevans in version: 9.2.29-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-13T21:00:08Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.29-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: thumbnail for video attachment

8dd2f5a

melvin-bot Bot assigned lorretheboy Oct 7, 2025

lorretheboy changed the title ~~fix: thumbnail for video attachment~~ A horizontal thumbnail is displayed for a vertical video attachment Oct 7, 2025

fix: add desktop

b59c8c5

lorretheboy marked this pull request as ready for review October 7, 2025 16:57

lorretheboy requested a review from a team as a code owner October 7, 2025 16:57

melvin-bot Bot requested review from ishpaul777 and removed request for a team October 7, 2025 16:57

ishpaul777 reviewed Oct 7, 2025

View reviewed changes

Merge branch 'main' of https://github.com/Expensify/App into fix/71072

eae5703

lorretheboy added 2 commits October 9, 2025 00:00

fix: native

1333dc9

fix: native

1c26217

ishpaul777 approved these changes Oct 8, 2025

View reviewed changes

melvin-bot Bot requested a review from amyevans October 8, 2025 21:10

amyevans requested changes Oct 9, 2025

View reviewed changes

Comment thread src/components/VideoPlayerPreview/index.tsx

chore: add code comment

e24c9c4

amyevans approved these changes Oct 9, 2025

View reviewed changes

amyevans merged commit 764304e into Expensify:main Oct 9, 2025
20 checks passed

OSBotify mentioned this pull request Oct 10, 2025

Deploy Checklist: New Expensify 2025-10-10 #72300

Closed

81 tasks

-        if (typeof videoUrl !== 'string' || !videoUrl || (getPlatform() !== CONST.PLATFORM.WEB && getPlatform() !== CONST.PLATFORM.DESKTOP)) {
+        const platform = getPlatform();
+        const isWebOrDesktop = platform === CONST.PLATFORM.WEB || platform === CONST.PLATFORM.DESKTOP;
+        if (typeof videoUrl !== 'string' || !videoUrl || !isWebOrDesktop)) {

Conversation

lorretheboy commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

lorretheboy commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented Oct 7, 2025

Uh oh!

codecov Bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ishpaul777 Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

ishpaul777 commented Oct 7, 2025

Uh oh!

lorretheboy commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lorretheboy commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented Oct 8, 2025

Uh oh!

amyevans left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lorretheboy commented Oct 9, 2025

Uh oh!

amyevans commented Oct 9, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 9, 2025

Uh oh!

OSBotify commented Oct 10, 2025

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lorretheboy commented Oct 7, 2025 •

edited

Loading

lorretheboy commented Oct 7, 2025 •

edited

Loading

codecov Bot commented Oct 7, 2025 •

edited

Loading

lorretheboy commented Oct 7, 2025 •

edited

Loading

lorretheboy commented Oct 8, 2025 •

edited

Loading

ishpaul777 commented Oct 8, 2025 •

edited

Loading